Is the MapServer code supposed to be ANSI C?

Petter Reinholdtsen pere at HUNGRY.COM
Sun Feb 6 03:04:17 EST 2005

[Frank Warmerdam]
> My thinking is that we should not be using signed chars for class
> indexes anyways.  We don't want to restrict ourselves to 128
> classes.  Perhaps the code in question should just be using short or
> int for class index.

You might be correct (I do not know the code in question well enough
to know if this index might end up above 128), but I would consider it
dangerous to change the type to a wider one, as it should change the
size of the structure and break compiled programs linked against

> I notice that in other places (such as labelCacheMemberObj) the
> classindex is an int. That is certainly what I have used in the
> raster code.

You are right, almost all other index types are 'int', with the
possible exception of tileindex in layerObj.

More information about the mapserver-dev mailing list