mapserver-4.8.0-rc2 wfs filter bugs

[Yewondwossen Assefa]

Jani,

 Thanks for looking into this. I have updated bug 1615 with the 
informatuion and  commited the fix in the cvs head.

 I think there is seem to be general consusus not add anything for the 
4.8 release so It can be relased. What do you think if we add it for the 
4.8.1 release ?

 Thanks


Jani Averbach wrote:

>>-----Original Message-----
>>From: Yewondwossen Assefa
>>Subject: Re: mapserver-4.8.0-rc2 wfs filter bugs
>>
>> I was looking into bug 1615 and would like to have your comments on
>>it.  What we end up in this case is that a tile layer is using
>>functions of a flat shape file.  From what I can see, a possible
>>source of problem in this case would be that function
>>msInitializeVirtualTable does not include some logic that is
>>included for example in msLayerOpen :
>>
>> if(layer->features && layer->connectiontype != MS_GRATICULE )
>>    layer->connectiontype = MS_INLINE;
>>
>>  if(layer->tileindex && layer->connectiontype == MS_SHAPEFILE)
>>    layer->connectiontype = MS_TILED_SHAPEFILE;
>>
>>  if(layer->type == MS_LAYER_RASTER )
>>    layer->connectiontype = MS_RASTER;
>>
>> Do it make sense to have these in msInitializeVirtualTable  ?
>>    
>>
>
>Hello,
>
>Thanks for looking this. I think it would be a good thing to move this
>logic to msInitializeVirtualTable.  In the perfect world msLayerOpen
>should be the first action with layer, but we are any way assuring
>that vtable is initialized by initializing it if it's null, so it
>should be ok and correct thing to move this logic out of msLayerOpen.
>
>At the same time, could you also commit this fix:
>
>Index: maplayer.c
>===================================================================
>RCS file: /data2/cvsroot/mapserver/maplayer.c,v
>retrieving revision 1.108
>diff -u -r1.108 maplayer.c
>--- maplayer.c  29 Oct 2005 02:03:43 -0000      1.108
>+++ maplayer.c  31 Jan 2006 16:39:44 -0000
>@@ -1138,7 +1138,7 @@
> createVirtualTable(layerVTableObj **vtable)
> {
>     *vtable = malloc(sizeof(**vtable));
>-    if ( ! vtable) {
>+    if ( ! *vtable) {
>         return MS_FAILURE;
>     }
>     return populateVirtualTable(*vtable);
>
>I think both of these fixes should be back ported to 4.8, so it would be nice
>if they are within one commit.
>
>Thanks again for looking this, 
>Jani
>  
>


-- 
----------------------------------------------------------------
Assefa Yewondwossen           
Software Analyst   

Email: assefa at dmsolutions.ca    
http://www.dmsolutions.ca/

Phone: (613) 565-5056 (ext 14)
Fax:   (613) 565-0925
----------------------------------------------------------------