agg changes

[Steve Lime]

I would agree with Zak, round for both (mimic the circular brush in GD). We'll have to move those
keywords out of symbolObj's and into styleObj's.

My quick testing finds no new problems other than what Steve W. has pointed out.

One thing I did notice (this isn't new) are some inconsistencies when overlaying thick lines on top
of one another to create hollow lines. Check out:

  http://www.dnr.state.mn.us/maps/compass-agg.html?map=%2Fusr%2Flocal%2Fwww%2Fdocs_maps%2Fcompass%2Fview-agg.map&imgext=481466.667685+4987788.229503+485589.755737+4991360.102575&mode=browse&zoomdir=1&zoomsize=2&layers=&imgxy=187.5+162.5&imgbox=-1+-1+-1+-1

and 

  http://www.dnr.state.mn.us/maps/compass-agg.html?map=%2Fusr%2Flocal%2Fwww%2Fdocs_maps%2Fcompass%2Fview-agg.map&imgext=482502.951848+4988675.685621+484564.495874+4990461.622157&mode=browse&zoomdir=1&zoomsize=2&layers=&imgxy=187.5+162.5&imgbox=-1+-1+-1+-1

Notice how the outline is much heavier in the first image versus the second. 

Steve

>>> On 8/27/2007 at 1:42 AM, in message
<d2b988930708262342t2819180vba1759cbf1b94a86 at mail.gmail.com>, thomas bonfort
<thomas.bonfort at GMAIL.COM> wrote:
> the fix for 
> http://trac.osgeo.org/mapserver/ticket/2264<http://trac.osgeo.org/mapserver/t 
> icket/2264#comment:6>introduced
> some regressions that result in artifacts on thick lines and font
> outlines (anywhere else ?). will be looking into this soon.
> 
> as for cartoline endcaps and joins, the documentation already exists, but
> will have to be updated for agg:
> http://mapserver.gis.umn.edu/docs/reference/symbology/syntax 
> I'll keep you updated when those keywords will be taken into account for
> line drawing
> 
> what should the default endcaps and joins be?
> 
> On 8/27/07, Stephen Woodbridge <woodbri at swoodbridge.com> wrote:
>>
>> thomas bonfort wrote:
>> > hi devs,
>> > I've commited a few changes to the agg rendering logic, which greatly
>> > increase performance when drawing many shapes. what's changed is that
>> > the imageObj now holds a pointer to the rendering object and all it's
>> > dependencies, instead of recreating them nearly from scratch each time a
>> > shape is drawn.
>> > on the "ntdb_roads_50" from a recent osgeo-discuss post
>> > before: 1.1seconds
>> > after: 0.5 seconds
>> >
>> > this is still much more than what gd does, but getting closer (that
>> > particular test file is probably a worst case scenario when comparing
>> > rendering times: many tiny line segments that just show up as a pixel
>> > with gd, but all have to be antialiased in agg)
>> >
>> > all this to say that I don't think there should be much breakage arising
>> > from this, but I'd appreciate if all of you who are set up to test agg
>> > could give the new version a run and report if anything weird is
>> happening.
>> >
>> > thanks,
>> > thomas
>>
>> Thomas,
>>
>> This is built with SVN revision 6709.
>>
>>
>> http://imaptools.com/cgi-bin/mapserv-4.99?mode=map&map=/u/data/test/spiral.map 
>>
>> 
> http://imaptools.com/maps/compare-maps2.php?loc=1&ll=42.61935+-71.38918&address=&c 
> ity=le+paso&state=tx&zipcode=&country=&asrv=1&amf=%2Fu%2Fdata%2Fmaps%2Fgoogle-aa2.m
> ap&msa=mapserv-4.10&bsrv=1&bmf=%2Fu%2Fdata%2Fmaps%2Fgoogle-agg.map&msb=mapserv-4.99&s
> ubmit=Show
>>
>> I noticed that the endcaps of fat lines used to be rounded like GD, but
>> now it abruptly ends. look at the ends of the test spiral and the roads
>> on the bottom of the side by side comparison.
>>
>> Also, You meantioned a while back that some or all of the cartoline
>> endcap styles worked with AGG, could you review for me and the doc team
>> what the keywords are and how to include them in the AGG layer definition.
>>
>> Thanks,
>>    -Steve W
>>