[mapserver-dev] code formatting and astyle

[Kralidis,Tom [Ontario]]

Thomas: for sure.

Steve and I were thinking a sandbox would be a good idea to try this, and have devs comment/etc.

..Tom



-----Original Message-----
From: mapserver-dev-bounces at lists.osgeo.org on behalf of thomas bonfort
Sent: Fri 13-Mar-09 17:25
To: Kralidis,Tom [Ontario]
Cc: mapserver-dev
Subject: Re: [mapserver-dev] code formatting and astyle
 
Hi,

as I'm currently working on the graphics branch, I would be very
grateful if an eventual code style change would not take place before
the merge, or else it's going to be hell for me to apply patches.

aside from  that, I'm supportive of the idea, whatever the chosen coding style

regards,
thomas

On Fri, Mar 13, 2009 at 04:42, Kralidis,Tom [Ontario]
<Tom.Kralidis at ec.gc.ca> wrote:
>>>Steve Lime wrote:
>>> I'd be ok with this. It's pretty interesting stomping around in places where a number
>>> of developers have contributed code. Personally I'm a fan of K&R formatting with a
>>> two-space indent, no padding around parens, and allowing one-liners.
>>>
>>> Steve
>>>
>>>>> "Kralidis,Tom [Ontario]" <Tom.Kralidis at ec.gc.ca> 03/11/09 6:47 AM >>>
>>>>
>>>> devs: inspired by pramsey's post on geos-devel [1], I wonder what dev's
>>>> think about running the MapServer codebase through an agreed upon
>>>> convention via astyle [2], and sticking to it for future development.
>>>>
>>>> Thoughts?
>>
>>Folks,
>>
>>I'm personally mildly against doing this.  I prefer to use "my own style"
>>in code I primarily maintain within MapServer and I try to fit with other code
>>when modifying other areas.  I think that strict coding conventions is a
>>modest disincentive to casual contributions.
>>
>>Of course if it is the will of the majority I will cooperate.
>
> I can appreciate your point of view.  Keep in mind that casual contributions can be still be put forth as present, and can be run through a tool like astyle.
>
> I think having coding conventions will make the codebase easier to maintain.
>
> I've posted a wiki page with notes/ideas at http://trac.osgeo.org/mapserver/wiki/CodingStyle
>
> ..Tom
> _______________________________________________
> mapserver-dev mailing list
> mapserver-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapserver-dev
>
_______________________________________________
mapserver-dev mailing list
mapserver-dev at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapserver-dev