[mapserver-dev] [WFS] define the geometry column in WFS as datasource

[Lime, Steve D (DNR)]

I think I'd recommend creating a single ticket that refers to your pull request. The ticket will should provide the necessary context to understand what you've done. I think once we get a look at the changes we can make a decision on if and when to include the changes. The metadata addition doesn't seem disruptive since by default things should work as they do now. The other seems, potentially, more disruptive.

We welcome contributions from all users, hardcore devs or not so *thank you*!

Steve

-----Original Message-----
From: mapserver-dev-bounces at lists.osgeo.org [mailto:mapserver-dev-bounces at lists.osgeo.org] On Behalf Of Yves Jacolin
Sent: Thursday, September 20, 2012 10:43 AM
To: mapserver-dev List
Subject: [mapserver-dev] [WFS] define the geometry column in WFS as datasource

Hello,

This week I find a limitation in MapServer configuration when using a WFS servcie as a datasource (aka MS as a WFS client).

As you can see here [1] the geometry column is hardcoded in code but some WFS services are not using Geometry as a column name (ArcGIS WFS sercices are using Shape instead, GeoServer is depending configuration of the layer).

I prepared a PR this week and tested it with a GeoServer instance. this PR add a new metadata for WFS client nammed geometryName (it could be a better name of course) to setup the name of the geometry column in the filter send by MS.

I have also some modifications related to namespace issue which should be added in tags, two examples:

<ogc:Filter xmlns:ogc='http://www.opengis.net/ogc'>
<gml:Box xmlns:gml="http://www.opengis.net/gml">

I would like to know what is the best process: do I need to create two tickets and propose my PR in some way?

Does MapServer developers are interesting about this two modifications?

Does this contribution could be added in the next release of MS (aka 6.2), is it too late? Are you interesting to get a PR in 6.0.x branche?

The last information is that I am **not** a developper at all but it was not so hard to do it finally :)

Thanks,

Y.
[1] https://github.com/mapserver/mapserver/blob/master/mapwfslayer.c#L242
--
Responsable Formation et Support
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac, Cedex
Tel (France) : +33 4 79 26 57 98
Mob. : +33 6 18 75 42 21
Fax : 04 79 70 15 81
Mail : yves.jacolin at camptocamp.com
http://www.camptocamp.com
_______________________________________________
mapserver-dev mailing list
mapserver-dev at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapserver-dev