[mapserver-dev] When to mark an error as "reported"?

[Lime, Steve D (MNIT)]

Hi Andreas: Do you have some examples of strange error reporting? Just trying to wrap my head around the issue. --Steve

________________________________
From: mapserver-dev <mapserver-dev-bounces at lists.osgeo.org> on behalf of Eichner, Andreas - SID <Andreas.Eichner at sid.sachsen.de>
Sent: Wednesday, December 27, 2017 4:23:42 AM
To: mapserver-dev at lists.osgeo.org
Subject: [mapserver-dev] When to mark an error as "reported"?

Hi devs,

I just found that msResetErrorList() in maperror.c does not reset the "isreported" field to MS_FALSE. This can cause strange error reporting behavior when in FastCGI mode. While checking the uses of this field I found that msWriteError() and msWriteErrorXML() mark errors as reported while msWriteErrorImage() does not.
The problem is that msWriteErrorImage() does not access the errorObj directly but uses msGetErrorString(). So my question is: is it OK to let msGetErrorString() mark the errors as reported or should this be done in msWriteErrorImage()?
I think it's truly a bug but I'm not sure what the best solution would be. Any ideas?

Regards,
Andreas

_______________________________________________
mapserver-dev mailing list
mapserver-dev at lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/mapserver-dev/attachments/20171231/8735e53a/attachment.html>