Bug in msCopy

[Benedikt Rothe]

hi  frank

i did it -> bug 1403

bye
benedikt

Frank Warmerdam <fwarmerdam at gmail.com> schrieb am 29.06.2005 16:16:16:

> On 6/29/05, Benedikt Rothe <umn-ms at hydrotec.de> wrote:
> > 
> > Dear List 
> > 
> > We are using MapScript/Tomcat/Java/OracleSpatial. 
> > 
> > We use mapObj.mapClone() to get a fresh mapObject 
> > in each request without reading the Mapfile. 
> > 
> > We detected problems after we activated Connection-Pooling: 
> > Tomcat crashed in mapObj.delete() 
> > 
> > Hole thing turned out to be a bug in mapcopy.c where 
> > the joins are copied: 
> > -------------------- 
> > MS_COPYSTELEM(numjoins); 
> > 
> > for (i = 0; i < dst->numprocessing; i++) { 
> >    return_value = msCopyJoin(&(dst->joins[i]), &(src->joins[i])); 
> > -------------------- 
> > 
> > This must be changed to 
> > -------------------- 
> > MS_COPYSTELEM(numjoins); 
> > 
> > for (i = 0; i < dst->numjoins; i++) { 
> >    return_value = msCopyJoin(&(dst->joins[i]), &(src->joins[i])); 
> > -------------------- 
> > 
> > There is some other code in mapobject.c, wich didn't 
> > raise any problems for us, but from wich I do think 
> > that array-allocs are missing. 
> > I watched the code an *think* these are are not allocated 
> > anywhere. I hope, there is no misleading hint: 
> 
> Benedikt, 
> 
> I would encourage you to submit this via bugzilla, 
> and ensure it gets assigned to Sean Gilles who
> takes care of map cloning problems. 
> 
> The cloning is a bit prone to bugs, but we want to fix it
> up. 
> 
> Best regards,
> -- 
> 
---------------------------------------+--------------------------------------
> I set the clouds in motion - turn up   | Frank Warmerdam, 
warmerdam at pobox.com
> light and sound - activate the windows | http://pobox.com/~warmerdam
> and watch the world go round - Rush    | Geospatial Programmer for Rent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/mapserver-users/attachments/20050629/ea940c8c/attachment.htm>