[mapserver-users] Getting an empty MVT output for a point layer

[Lime, Steve D (MNIT)]

I should add that if there’s a clearer way to do that I’m all ears.

From: mapserver-users [mailto:mapserver-users-bounces at lists.osgeo.org] On Behalf Of Lime, Steve D (MNIT)
Sent: Thursday, August 30, 2018 10:07 AM
To: Rahkonen Jukka (MML) <jukka.rahkonen at maanmittauslaitos.fi>; Mapserver-Users (mapserver-users at lists.osgeo.org) <mapserver-users at lists.osgeo.org>
Subject: Re: [mapserver-users] Getting an empty MVT output for a point layer

If the layer isn’t a point layer we need numlines>1 and a non-degenerate bounding box.
If the layer is a point layer we only need numlines>1 (the actual point is stored in the line array).

From: mapserver-users [mailto:mapserver-users-bounces at lists.osgeo.org] On Behalf Of Rahkonen Jukka (MML)
Sent: Thursday, August 30, 2018 7:31 AM
To: Mapserver-Users (mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>) <mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>>
Subject: Re: [mapserver-users] Getting an empty MVT output for a point layer

Hi,

I can’t really read the code but I still try to look at the changeset with layman eyes

   /* success if at least one line and not a degenerate bounding box */
-  if(shape->numlines > 0 && (shape->bounds.minx != shape->bounds.maxx || shape->bounds.miny != shape->bounds.maxy))
+  if(shape->numlines > 0 && (layer_type == MS_LAYER_POINT || (shape->bounds.minx != shape->bounds.maxx || shape->bounds.miny != shape->bounds.maxy)))
     return MS_SUCCESS;
   else
     return MS_FAILURE;

I wonder two things:
What happens now if the layer type is not MS_LAYER_POINT?
What if layer is of type MS_LAYER_POINT and numlines=1, which means that the bounding box of the result set is just a point and minx=maxx and miny=maxy?

-Jukka Rahkonen-



Lähettäjä: Lime, Steve D (MNIT) [mailto:steve.lime at state.mn.us]
Lähetetty: 29. elokuuta 2018 22:52
Vastaanottaja: Lime, Steve D (MNIT) <steve.lime at state.mn.us<mailto:steve.lime at state.mn.us>>; Rahkonen Jukka (MML) <jukka.rahkonen at maanmittauslaitos.fi<mailto:jukka.rahkonen at maanmittauslaitos.fi>>; Caleb Lee <caleblee at hotmail.com<mailto:caleblee at hotmail.com>>; mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>
Aihe: RE: Getting an empty MVT output for a point layer

Fix is in place in the 7.2 branch. If folks would let me know how it goes I’d appreciate it. --Steve

From: mapserver-users [mailto:mapserver-users-bounces at lists.osgeo.org] On Behalf Of Lime, Steve D (MNIT)
Sent: Wednesday, August 29, 2018 11:54 AM
To: Rahkonen Jukka (MML) <jukka.rahkonen at maanmittauslaitos.fi<mailto:jukka.rahkonen at maanmittauslaitos.fi>>; Caleb Lee <caleblee at hotmail.com<mailto:caleblee at hotmail.com>>; mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>
Subject: Re: [mapserver-users] Getting an empty MVT output for a point layer

Found the issue – clipping logic error. Will commit a fix today…

From: Lime, Steve D (MNIT)
Sent: Wednesday, August 22, 2018 9:11 AM
To: 'Rahkonen Jukka (MML)' <jukka.rahkonen at maanmittauslaitos.fi<mailto:jukka.rahkonen at maanmittauslaitos.fi>>; Caleb Lee <caleblee at hotmail.com<mailto:caleblee at hotmail.com>>; mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>
Subject: RE: Getting an empty MVT output for a point layer

A ticket would be terrific. I’m on this one… --Steve

From: mapserver-users [mailto:mapserver-users-bounces at lists.osgeo.org] On Behalf Of Rahkonen Jukka (MML)
Sent: Tuesday, August 21, 2018 8:28 AM
To: Caleb Lee <caleblee at hotmail.com<mailto:caleblee at hotmail.com>>; mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>
Subject: Re: [mapserver-users] Getting an empty MVT output for a point layer

Hi,

I haven’t heard any feedback yet. Test data seems to be still available and I believe that the issue is real. It seems that nobody has bothered to create a ticket yet https://github.com/mapserver/mapserver/issues.

-Jukka Rahkonen-


Lähettäjä: mapserver-users [mailto:mapserver-users-bounces at lists.osgeo.org] Puolesta Caleb Lee
Lähetetty: 21. elokuuta 2018 16:20
Vastaanottaja: mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>
Aihe: Re: [mapserver-users] Getting an empty MVT output for a point layer

Hi, is there any update regarding this MVT output problem for point layers?

Thanks,

Caleb
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/mapserver-users/attachments/20180830/3bab86e4/attachment.htm>