[MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

[Jeff McKenna]

Hi Oliver, a pull request in the documentation repository would be 
warmly received: https://github.com/MapServer/MapServer-documentation 
Thank-you for catching this.  -jeff






-- 
Jeff McKenna
GatewayGeo: Developers of MS4W, MapServer Consulting and Training
co-founder of FOSS4G
http://gatewaygeo.com/




On 2023-05-30 9:20 a.m., Oliver Christen wrote:
> before that commit, the following code was working:
> 
>      STYLE
>        COLOR 255 255 255
>        SYMBOL "rectangle3"
>        ANGLE -45
>        SIZE 8
>        GAP 10
>      END
> 
> after that commit, it no longer works, as ANGLE -45 is not accepted 
> anymore, instead it had to be changed to
> 
> STYLE
>        COLOR 255 255 255
>        SYMBOL "rectangle3"
>        ANGLE 315
>        SIZE 8
>        GAP 10
>      END
> 
> the documentation https://mapserver.org/mapfile/style.html 
> <https://mapserver.org/mapfile/style.html> say it must be of type 
> DOUBLE, but double can be negative and nothing say explicitly in the 
> documentation that the value can not be negative.
> 
> I see this discussion here:
> https://github.com/MapServer/MapServer/issues/6463 
> <https://github.com/MapServer/MapServer/issues/6463>
> but no comment if something was done or agreed on about this.
> A note should be added to the documentation to make that clear, as it 
> was done for label size (see below).
> I can do a PR if that would be acceptable ?
> 
> for label size, I see that a note was added saying the value must be 
> greater than zero on 26 january 2022, so I guess this is on me for not 
> noticing it (but im not alone not noticing it so I guess it wasnt 
> clearly stated/announced either)
> 
> Best regards
> Oliver
> 
> 
> 
> 
> 
> On Tue, May 30, 2023 at 1:27 PM Rahkonen Jukka 
> <jukka.rahkonen at maanmittauslaitos.fi 
> <mailto:jukka.rahkonen at maanmittauslaitos.fi>> wrote:
> 
>     Hi,____
> 
>     __ __
> 
>     Maybe the commit could be adjusted in Mapserver 7. Out of curiosity,
>     what is the use case for zero sized labels and symbols? To disable
>     them, or? About the angle, by the Mapserver 7.0 documentation,
>     doesn’t it feel like negative angles were not thought to work ever?____
> 
> 
>     “Angle, given in degrees, to rotate the symbol (counter clockwise).
>     Default is 0 (no rotation). If you have an attribute that specifies
>     angles in a clockwise direction (compass direction), you have to
>     adjust the angle attribute values before they reach MapServer
>     (360-ANGLE), as it is not possible to use a mathematical expression
>     for ANGLE.”____
> 
>     __ __
> 
>     -Jukka Rahkonen-____
> 
>     __ __
> 
>     *Lähettäjä:*MapServer-users <mapserver-users-bounces at lists.osgeo.org
>     <mailto:mapserver-users-bounces at lists.osgeo.org>> *Puolesta *Oliver
>     Christen
>     *Lähetetty:* tiistai 30. toukokuuta 2023 13.59
>     *Vastaanottaja:* mapserver-users at lists.osgeo.org
>     <mailto:mapserver-users at lists.osgeo.org>
>     *Aihe:* [MapServer-users] breaking changes in branch-7-6 after
>     commit of experimental changes from branch-8-0____
> 
>     __ __
> 
>     Dear Mapserver commiters____
> 
>     __ __
> 
>     this commit there:____
> 
>     https://github.com/MapServer/MapServer/pull/6818
>     <https://github.com/MapServer/MapServer/pull/6818>____
> 
>     __ __
> 
>     broke a lot of things, ____
> 
>     like style angles not supporting negative values anymore or label
>     size mandatorily greater than zero (also possibly for symbol)____
> 
>     __ __
> 
>     Im not against changes, but changes should be: ____
> 
>     a) documented ____
> 
>     b) announced with preferably a deprecation period____
> 
>     __ __
> 
>     so, please revert that commit or provide adequate
>     change/documentation for all the breaking changes.____
>