[OpenLayers-Commits] r10831 - in trunk/openlayers/lib: . OpenLayers

[commits-20090109 at openlayers.org]

Author: ahocevar
Date: 2010-10-14 01:08:54 -0700 (Thu, 14 Oct 2010)
New Revision: 10831

Modified:
   trunk/openlayers/lib/OpenLayers.js
   trunk/openlayers/lib/OpenLayers/SingleFile.js
Log:
Also handle the case where the regex does not match in OpenLayers.js::_getScriptLocation, and use a shorter variable name for the match. In addition to the reviewed patch, also added some comments about simplification in 3.0, and to make jorix happy. Finally, moved VERSION_NUMBER to the top to make it easy to see it in a minified build. r=elemoine (closes #2873)


Modified: trunk/openlayers/lib/OpenLayers/SingleFile.js
===================================================================
--- trunk/openlayers/lib/OpenLayers/SingleFile.js	2010-10-13 22:16:49 UTC (rev 10830)
+++ trunk/openlayers/lib/OpenLayers/SingleFile.js	2010-10-14 08:08:54 UTC (rev 10831)
@@ -4,16 +4,30 @@
  * full text of the license. */
 
 var OpenLayers = {
+    /**
+     * Constant: VERSION_NUMBER
+     */
+    VERSION_NUMBER: "$Revision$",
+
+    /**
+     * Constant: singleFile
+     * TODO: remove this in 3.0 when we stop supporting build profiles that
+     * include OpenLayers.js
+     */
     singleFile: true,
+
+    /**
+     * Method: _getScriptLocation
+     * Return the path to this script. This is also implemented in
+     * OpenLayers.js
+     *
+     * Returns:
+     * {String} Path to this script
+     */
     _getScriptLocation: (function() {
         var s = document.getElementsByTagName('script');
-        var match = s[s.length-1].getAttribute("src").match(/(^|(.*?\/))(OpenLayers\.js)(\?|$)/);
-        var l = match ? match[1] : "";
+        var m = s[s.length-1].getAttribute("src").match(/(^|(.*?\/))(OpenLayers\.js)(\?|$)/);
+        var l = m ? m[1] : "";
         return (function() { return l; });
     })()
 };
-
-/**
- * Constant: VERSION_NUMBER
- */
-OpenLayers.VERSION_NUMBER="$Revision$";

Modified: trunk/openlayers/lib/OpenLayers.js
===================================================================
--- trunk/openlayers/lib/OpenLayers.js	2010-10-13 22:16:49 UTC (rev 10830)
+++ trunk/openlayers/lib/OpenLayers.js	2010-10-14 08:08:54 UTC (rev 10831)
@@ -7,7 +7,13 @@
  * @requires OpenLayers/BaseTypes.js
  * @requires OpenLayers/Lang/en.js
  * @requires OpenLayers/Console.js
- */ 
+ */
+ 
+/*
+ * TODO: In 3.0, we will stop supporting build profiles that include
+ * OpenLayers.js. This means we will not need the singleFile and scriptFile
+ * variables, because we don't have to handle the singleFile case any more.
+ */
 
 (function() {
     /**
@@ -30,8 +36,9 @@
      */
     window.OpenLayers = {
         /**
-         * Function: _getScriptLocation
-         * Return the path to this script.
+         * Method: _getScriptLocation
+         * Return the path to this script. This is also implemented in
+         * OpenLayers/SingleFile.js
          *
          * Returns:
          * {String} Path to this script
@@ -39,7 +46,8 @@
         _getScriptLocation: (function() {
             var r = new RegExp("(^|(.*?\\/))(" + scriptName + ")(\\?|$)");
             var s = document.getElementsByTagName('script');
-            var l = s[s.length-1].getAttribute("src").match(r)[1];
+            var m = s[s.length-1].getAttribute("src").match(r);
+            var l = m ? m[1] : "";
             return (function() { return l; });
         })()
     };
@@ -52,7 +60,7 @@
      * 
      * When we *are* part of a SFL build we do not dynamically include the 
      * OpenLayers library code as it will be appended at the end of this file.
-      */
+     */
     if(!singleFile) {
         var jsfiles = new Array(
             "OpenLayers/Util.js",