[OpenLayers-Commits] r11881 - in trunk/openlayers: lib/OpenLayers/Renderer tests/Renderer

[commits-20090109 at openlayers.org]

Author: tschaub
Date: 2011-04-06 08:35:24 -0700 (Wed, 06 Apr 2011)
New Revision: 11881

Modified:
   trunk/openlayers/lib/OpenLayers/Renderer/Canvas.js
   trunk/openlayers/tests/Renderer/Canvas.html
Log:
Making it so the Canvas renderer does not draw features with display "none" or those with geometries outside the renderer extent.  p=me,ahocevar r=erilem (closes #3224)

Modified: trunk/openlayers/lib/OpenLayers/Renderer/Canvas.js
===================================================================
--- trunk/openlayers/lib/OpenLayers/Renderer/Canvas.js	2011-04-06 06:59:05 UTC (rev 11880)
+++ trunk/openlayers/lib/OpenLayers/Renderer/Canvas.js	2011-04-06 15:35:24 UTC (rev 11881)
@@ -138,12 +138,15 @@
     drawFeature: function(feature, style) {
         var rendered;
         if (feature.geometry) {
-            style = style || feature.style;
-            style = this.applyDefaultSymbolizer(style);  
-
-            this.features[feature.id] = [feature, style];
-            rendered = true;
-            this.pendingRedraw = true;
+            style = this.applyDefaultSymbolizer(style || feature.style);
+            // don't render if display none or feature outside extent
+            rendered = (style.display !== "none") &&
+                feature.geometry.getBounds().intersectsBounds(this.extent);
+            if (rendered) {
+                // keep track of what we have rendered for redraw
+                this.features[feature.id] = [feature, style];
+                this.pendingRedraw = true;
+            }
         }
         if (this.pendingRedraw && !this.locked) {
             this.redraw();

Modified: trunk/openlayers/tests/Renderer/Canvas.html
===================================================================
--- trunk/openlayers/tests/Renderer/Canvas.html	2011-04-06 06:59:05 UTC (rev 11880)
+++ trunk/openlayers/tests/Renderer/Canvas.html	2011-04-06 15:35:24 UTC (rev 11881)
@@ -117,6 +117,76 @@
         t.eq(r.map, null, "map nullified");
     }
 
+    function test_drawFeature(t) {
+        if (!supported) {
+            t.plan(0); 
+            return; 
+        }
+        
+        t.plan(8);
+        var layer = new OpenLayers.Layer.Vector(null, {
+            isBaseLayer: true,
+            renderers: ["Canvas"]
+        });
+        
+        var map = new OpenLayers.Map({
+            div: "map",
+            controls: [],
+            layers: [layer],
+            center: new OpenLayers.LonLat(0, 0),
+            zoom: 0
+        });
+        
+        var renderer = layer.renderer;
+        var count = 0;
+        var redraw = layer.renderer.redraw;
+        renderer.redraw = function() {
+            ++count;
+            redraw.apply(this, arguments);
+        }
+        var exp;
+        
+        // a) draw a point feature
+        count = 0;
+        exp = renderer.drawFeature(
+            new OpenLayers.Feature.Vector(new OpenLayers.Geometry.Point(0, 0)), {}
+        );
+        t.eq(exp, true, "a) drawFeature returns true");
+        t.eq(count, 1, "a) redraw called once after drawing a point feature");
+        renderer.clear();
+        
+        // b) draw one feature with no geometry
+        count = 0;
+        exp = renderer.drawFeature(
+            new OpenLayers.Feature.Vector(), {}
+        );
+        t.eq(exp, undefined, "b) drawFeature returns undefined");
+        t.eq(count, 0, "b) redraw is not called when drawing a feature with no geometry");
+        renderer.clear();
+        
+        // c) draw a point feature with display "none"
+        count = 0;
+        exp = renderer.drawFeature(
+            new OpenLayers.Feature.Vector(new OpenLayers.Geometry.Point(1, 0)),
+            {display: "none"}
+        );
+        t.eq(exp, false, "c) drawFeature returns false");
+        t.eq(count, 0, "c) redraw is not called when drawing a feature with display 'none'");
+        renderer.clear();
+
+        // d) draw a point feature outside renderer extent
+        count = 0;
+        exp = renderer.drawFeature(
+            new OpenLayers.Feature.Vector(new OpenLayers.Geometry.Point(-1000, 0)), {}
+        );
+        t.eq(exp, false, "d) drawFeature returns false");
+        t.eq(count, 0, "d) redraw is not called when drawing a feature outside renderer extent");
+        renderer.clear();
+        
+        map.destroy();
+    }
+
+
     function test_pendingRedraw(t) {
         if (!supported) {
             t.plan(0);