[OpenLayers-Dev] bounds height
crschmidt at metacarta.com
Sat Dec 1 09:13:53 EST 2007
On Sat, Dec 01, 2007 at 02:53:14PM +0100, Eric Lemoine wrote:
> On Nov 30, 2007 11:07 PM, Tim Schaub <tschaub at openplans.org> wrote:
> > Hey-
> > Is anyone relying on bounds.getHeight returning (top - bottom) instead
> > of Math.abs(top - bottom)?
> > The name height implies a positive value to me (it's names like top and
> > bottom that are unfortunate).
> > I doubt that there is much interest either way, but I was wanting to at
> > least poll the crowd to see if there was any strong opposition to having
> > bounds.getHeight return the absolute difference.
> > I don't think anybody has ever asked for the same with getWidth - but
> > maybe that's because there aren't too many left is positive coordinate
> > systems.
> > Tim
> Tim, having getHeight return a positive number sounds reasonable to
> me. However, I didn't understand your comment on getWidth. Don't we
> want the same for getWidth?
I think Tim's point was "There's never been a situation where someone
has reversed left and right, but there are situations where people
reverse bottom and top." -- which is why we see it come up for
getHeight, but not for getWidth. (If we're going to change one, we
should change both, imho.)
More information about the Dev