[OpenLayers-Dev] [OpenLayers-Trac] [OpenLayers] #1059: Mark drawFeature(..) as stable

[Andreas Hocevar]

Hi,

On Nov 22, 2007 1:24 PM, Christopher Schmidt <crschmidt at metacarta.com> wrote:
> On Thu, Nov 22, 2007 at 10:31:12AM +0100, Andreas Hocevar wrote:
> > On Nov 21, 2007 9:31 PM, OpenLayers <trac at openlayers.org> wrote:
> > >  (In [5244]) Mark drawFeature as stable (Closes #1059)
> >
> > I would reconsider that, especially since no one has obviously taken
> > notice of my posting a few days ago
> > (http://www.nabble.com/Features,-Styling-and-Rendering-t4823880.html).
> However, I think that if we do go the route you have suggested: that is,
> passing a 'key' into drawFeature instead of a style object, we should
> *still* maintain the existing capability. Determining whether we were
> passed a key or an object is easy (typeof style == "string"), and I have
> no problems *extending* the existing API once we have it.

Ok, that sounds like a solution. This typeof check is hopefully
inexpensive, because it will be made every time we render a fetature.

> I disagree: we just have to be more cautious :) Extensions of the API
> are fine, and I think that this one is a cost we should be prepared to
> take on. If it becomes a problem, I'll help accomodate for it in your
> developments.

Fine, then I'll bury my concerns :-). Closed #1059 again.

Regards,
Andreas.