[OpenLayers-Dev] general questions regarding the process of patches for new/enhanced functionality

[Bart van den Eijnden (OSGIS)]

Hi Marc,

welcome to the community, you're almost there (opening a ticket with a 
patch is the right way), a few pointers:

-it is wise to set the state of your ticket to review, also if you want 
it to get attention, make sure the milestone is the next possible 
release (right now 2.9)
-a patch with a testcase is better than a patch without a testcase, so 
if you could look into how to write a testcase that would be great
-a patch should ideally work against trunk

Best regards,
Bart

Marc Jansen wrote:
> Hi devs,
>
> I recently opened two tickets ([1], [2]) for new / enhanced 
> functionality of OpenLayers components. Both of them have (more or less 
> trivial) patches attached to provide the actual functionality.
>
> I would love to have a short note/review about the code in question by 
> someone with deeper insights in the project.
>
> I am not quite sure if I did everything the "OpenLayers-Way". Is the 
> process of opening a ticket and submitting a patch the desired way? 
> Should I have started a discussion on this list prior to opening the 
> ticket? Please help me since I would love to participate in the project.
>
> BTW: I have not handed in a CLA up until now. Maybe we can fix this in 
> Sydney, as I guess many from the project will meet up there.
>
> Regards,
> Marc
>
> [1] http://trac.openlayers.org/ticket/2266
> [2] http://trac.openlayers.org/ticket/2288
> _______________________________________________
> Dev mailing list
> Dev at openlayers.org
> http://openlayers.org/mailman/listinfo/dev
>
>
>   


-- 
Bart van den Eijnden
OSGIS, Open Source GIS
bartvde at osgis.nl
http://www.osgis.nl