[OpenLayers-Dev] Re: OpenLayers without warnings using the Closure Compiler in VERBOSE mode

[Xavier Mamano (jorix)]

oops!, there's an erratum.

Is:

  OpenLayers.Util.applyDefaults(B.prototype, A.prototype); // Inherits from:
A 
is not:

  OpenLayers.Util.applyDefaults(B, A); // Inherits from: A 

Xavier Mamano


Xavier Mamano (jorix) wrote:
> 
> Hi developers, 
> ...
> The code would be:
> /** @constructor */ 
>   A = function(){...}; // constructor A 
>   A.prototype = {...}; // prototype definition 
> /** @constructor 
>      @extends A */ 
>   B = function(){...}; // constructor B 
>   B.prototype = {...}; // prototype definition 
>   OpenLayers.Util.applyDefaults(B, A); // Inherits from: A 
> This has worked well and adding 
> "initialize: function () {CLASS_NAME.apply (this, arguments);}" the code
> works
> in mixed mode (lite.cfg in pure javascript and the rest with Class) 
> 
> Small adjustments: 
> • Closure provides a warning when using parseInt without the second
> parameter 
>   and said: "if you really want to parse octal or hex based on the leader,
> then 
>   pass "undefined" as the base. " 
> • Functions that use "arguments" but do not declare the parameters 
>   (as OpenLayers.Util.getElement),
>   Clouse requires a definition of "@param" with name matching the name of 
>   the parameter in the function. 
> • Other minor details ... mostly matching types. 
> 
> So far I have not been able to eliminate all warnings, now there are 9
> (plus 24 
> warnings: not defined as Control, Popup, Geometry used in Map.js and
> BaseTypes/Bounds.js)
> but is a big difference when compared with the most of 1500 that are
> generated 
> with the original code using lite.cfg (at r11029)  
> 
> I believe that in a few years will seem strange to work in javascript
> without a 
> compiler as now seems strange to work without Firebug.
> 
> Regards, 
> 
> Xavier Mamano
> 

-- 
View this message in context: http://osgeo-org.1803224.n2.nabble.com/OpenLayers-without-warnings-using-the-Closure-Compiler-in-VERBOSE-mode-tp5916529p5917316.html
Sent from the OpenLayers Dev mailing list archive at Nabble.com.