[OpenLayers-Dev] click & pinch overhaul

Cédric MOULLET cedric.moullet at gmail.com
Mon Mar 7 13:49:24 EST 2011


Hi Tim,
Thanks for these improvements. I have tested on several plattforms (see
https://spreadsheets.google.com/ccc?key=0AjTbLQNm01pfdEtUc0FkVm9DYnBtMTNkcWpTemw3T0E&authkey=CJGm_vQF&hl=fr#gid=0
).
I face the same issues like Steven. In addition, I have observed the
following things:
- iTouch 3.1.3: Pinch Zoom Dragging -> it moves the browser instead of the
map and makes the function ineffective
- Android Nexus S: the double click seems to work a bit better, but has
still issues. No idea why (but this is a very empirical observation)
- Chrome 10 - IE8 - FF3.6: dragging and double click are working fine (with
mouse).
HTH,
Cédric

On Mon, Mar 7, 2011 at 5:58 PM, Steven M. Ottens <steven at minst.net> wrote:

>  Hi Tim,
>
>  Thanks for the update, comments inline.
>
>
> On 3/7/2011 4:56 PM, Tim Schaub wrote:
>
>> Hey-
>>
>> There are a number of issues with how the click and pinch handlers work
>> together.  After adding pinch zoom, we lost the multi-touch click to zoom
>> out.  In addition, the pinch handler was overly cautious about stopping
>> event propagation because the click handler wasn't particularly good at
>> distinguishing clicks from pinches.  I've overhauled the click handler to
>> better distinguish clicks from pinches and resolved a number of issues that
>> came up along the way.
>>
>
> There is no scroll-wheel support anymore, is this intentional. I know
> that's not a touch device, but still it would be nice so you could use the
> same client on all your platforms.
>
>
>> http://trac.osgeo.org/openlayers/ticket/3133
>>
>> Andreas had reviewed this patch in a previous state, but there were still
>> some unhandled errors getting through, so I continued to modify it.
>>
>> I'd appreciate it if people could test the changes on real devices (I've
>> only tested on emulators).  To best test the changes, it is important to
>> have an error console enabled.
>>
>
> I tested the url below with an iPad with iOS 4.2.1 and its Safari browser.
>
>
>  You should see double-click (zoom in), multi-touch click (zoom out), and
>> pinch (zoom/drag) working in this sandbox example (on multi-touch devices):
>>
>
> Pinch zoom works fast and without problems. Pinch-zoom-dragging (moving
> your two fingers over the device) is working as well correctly and doesn't
> produce the drag-error mentioned below. Multi-touch click works almost
> always, very rarely it gets mistaken for a pinch-gesture.
> Double-click fails about 20%-60% of the time, without error. I tested it
> with a colleague and we think the problem is that it is hard to tap twice on
> exactly the same spot. As such a large 'buffer' area for the second tap
> would be advisable.
>
>  http://dev.openlayers.org/sandbox/tschaub/click/examples/mobile.html
>>
>> You should also see no unhandled errors.  However, there are currently
>> unhandled errors when dragging on the trunk (after r11635).  I'll update the
>> sandbox when this is addressed.
>>
> I run in this error, while dragging. It didn't seem to impact performance
> or functionality. I take is the same as mentioned below:
>  JavaScript Error on Line 195 in Drag.js
> TypeError: Result of expression'evt' [null] is not an object
>
>  http://trac.osgeo.org/openlayers/ticket/2936#comment:17
>>
>
> I hope this helps a bit. In general I'm happy with the performance of the
> client on the iPad, apart from the double-tap issue it is a pleasure to use.
>
> Regards,
> Steven
>
>
> _______________________________________________
> Dev mailing list
> Dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/openlayers-dev
>



-- 
Political blog: http://cedricmoullet.blogspot.com/
Welcome to my world: http://www.cedricmoullet.com/
My Linked In profile: http://www.linkedin.com/in/cedricmoullet
Twitter: http://twitter.com/cedricmoullet
Home sweet home:
http://map.geo.admin.ch/?crosshair=bowl&zoom=11&X=185241.24219&Y=561288.90625&bgOpacity=0&selectedNode=node_ch.swisstopo.fixpunkte-lage1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/openlayers-dev/attachments/20110307/d76377f5/attachment.html


More information about the Dev mailing list