[OpenLayers-Dev] Please review this patch (Script protocol)
dominikmikiewicz at o2.pl
Tue Sep 20 08:53:42 EDT 2011
Thought I would add Panoramio to Javi's list. It also fits into the
Openlayers.Layer.Social layers idea. This is something we did recently. It
may not be bullet proof so if you find something that needs addressing I'd
appreciate some info too
From: openlayers-dev-bounces at lists.osgeo.org
[mailto:openlayers-dev-bounces at lists.osgeo.org] On Behalf Of Javier Carrasco
Sent: Tuesday, September 20, 2011 9:25 AM
To: Volker Mische; christopher.schmidt at nokia.com
Cc: openlayers-dev at lists.osgeo.org
Subject: RE: [OpenLayers-Dev] Please review this patch (Script protocol)
I have a test here
It uses Flickr, Twitter, Yelp, LastFM and POIProxy APIs
Please have a look at the source code.
The protocol Script2 is just Script protocol with the patch applied (and the
We want to contribute this code to OpenLayers, specially the
Openlayers.Layer.Social... layers. Do you think it can be useful for
In that case I would work more on the code and write some tests and more
De: Volker Mische [mailto:volker.mische at gmail.com] Enviado el: martes, 20 de
septiembre de 2011 4:33
Para: christopher.schmidt at nokia.com
CC: Javier Carrasco; openlayers-dev at lists.osgeo.org
Asunto: Re: [OpenLayers-Dev] Please review this patch (Script protocol)
I'll bump it up on my TODO list.
I would also love to see it tested against other JSONP APIs. APIs worth
testing that come to my mind are Twitter (what this patch is for), Flickr
and one of Googles. If anyone could test those it would be great, else I
will do it myself.
On 09/19/2011 07:20 PM, christopher.schmidt at nokia.com wrote:
> Have you tested this patch with the GeoCouch stuff you're using?
> If it works there, can you add a comment to that ticket? I think in
> general it looks fine, though it would be nice to have some tests of
> some sort to confirm that this is doing what we want.
> it looks like this patch *breaks* tests; I tossed together
> which has a fix for the tests as well.
> If you can test this, and add a comment to the ticket, I think it's
> sane to go ahead with committing at that point.
> -- Chris
> On Sep 7, 2011, at 7:18 AM, ext Volker Mische wrote:
>> On 09/07/2011 08:59 AM, Javier Carrasco wrote:
>>> The script protocol is not working with Twitter service because of
>>> brackets in the generated requests url.
>>> I just created a ticket and submitted a very small patch here
>>> Thank you for reviewing it
>> Hi Javi,
>> looks good to me. I haven't tested it, but only read the source.
>> It's sad that OpenLayers 2.11 is almost out already. I would love to
squeeze it in, but I can understand if it won't. 2.11 introduces the Script
protocol and it would be cool if it won't need to change for 2.12, but it
looks like it needs to.
>> Dev mailing list
>> Dev at lists.osgeo.org
Dev mailing list
Dev at lists.osgeo.org
More information about the Dev