[OpenLayers-Trac] Re: [OpenLayers] #2834: Panel control: Allow to
use "autoActivate" in the panel's controls.
OpenLayers
trac-20090302 at openlayers.org
Mon Sep 13 16:31:53 EDT 2010
#2834: Panel control: Allow to use "autoActivate" in the panel's controls.
---------------------------+------------------------------------------------
Reporter: jorix | Owner:
Type: feature | Status: new
Priority: minor | Milestone: 2.11 Release
Component: Control.Panel | Version: 2.10
Keywords: | State: Needs More Work
---------------------------+------------------------------------------------
Comment(by jorix):
Replying to [comment:2 ahocevar]:
> Patch makes changes unrelated to its purpose...
I guess refers to changes in the activate and deactivate.[[BR]]
Without these changes, "useAutoActivate" only works if "saveState = true".
The patch uses the array "activeState" to store the state when add
controls to the panel. Another implementation without using "saveState" is
possible, but the code is longer.
>...code to an example that is not related to panels.
You're right, the example must be removed.[[BR]]
It goes well have a modified example to show how a patch works. These
examples do not have significance outside the ticket.[[BR]]
I have no clear what is the best way to deliver these modified examples,
sometimes I put them as comment in the ticket, and another (as here) in
the same patch and explained that it is just to test the ticket (It is
more comfortable to try, but it is unclear, as here)[[BR]]
What is better?
--
Ticket URL: <http://trac.openlayers.org/ticket/2834#comment:3>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer
More information about the Trac
mailing list