[OpenLayers-Trac] Re: [OpenLayers] #2819: Format.XML could add xmlns attributes by default

OpenLayers trac-20090302 at openlayers.org
Fri Apr 1 09:13:01 EDT 2011


#2819: Format.XML could add xmlns attributes by default
------------------------+---------------------------------------------------
 Reporter:  bartvde     |       Owner:  erilem         
     Type:  feature     |      Status:  new            
 Priority:  minor       |   Milestone:  2.11 Release   
Component:  Format.XML  |     Version:  2.10 RC1       
 Keywords:              |       State:  Needs More Work
------------------------+---------------------------------------------------
Changes (by erilem):

  * state:  Review => Needs More Work


Comment:

 My review comments:

  * the patch doesn't apply to the current trunk
  * calling {{{write}}} with something else than an {{{ELEMENT_NODE}}} will
 cause an error when attempting to access the {{{attributes}}} or
 {{{setAttribute}}} property
  * in my opinion the patch deserves new tests in tests/Format/XML.html. In
 particular I'd like to see tests providing evidences that the "avoid
 duplicates" code is necessary

 I'm not an XML expert, so I'll defer the final word to our OGC/XML gurus.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/2819#comment:8>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list