[OpenLayers-Trac] Re: [OpenLayers] #3225: Missing return value in the Renderer.Canvas.drawFeature() method

[OpenLayers]

#3225: Missing return value in the Renderer.Canvas.drawFeature() method
------------------------------+---------------------------------------------
  Reporter:  vog              |       Owner:  crschmidt                    
      Type:  bug              |      Status:  reopened                     
  Priority:  minor            |   Milestone:  2.11 Release                 
 Component:  Renderer.Canvas  |     Version:  2.10                         
Resolution:                   |    Keywords:  performance, canvas, renderer
     State:  Review           |  
------------------------------+---------------------------------------------

Comment(by tschaub):

 Rather than add a property which may be used for other purposes, I think
 it makes sense to only keep track of what we need to know.  Since the
 renderer doesn't lock itself (something we should revisit), it gets
 screwed up when there is a pending redraw and the last drawn feature in a
 batch has no geometry (this is the case that failed with r11851).

 So, it makes more sense to me to keep track of whether there is a pending
 redraw.  Then, in {{{drawFeature}}}, if {{{rendered}}} is false but
 {{{pendingRedraw}}} is true, we call {{{redraw}}}.  This saves us from
 calling {{{redraw}}} whenever a feature with no geometry is added to the
 layer.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3225#comment:6>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer