[OpenLayers-Trac] Re: [OpenLayers] #3237: Issue with filter params in Protocol/HTTP.js

[OpenLayers]

#3237: Issue with filter params in Protocol/HTTP.js
----------------------------------+-----------------------------------------
 Reporter:  etdube                |       Owner:              
     Type:  bug                   |      Status:  new         
 Priority:  minor                 |   Milestone:  2.11 Release
Component:  Protocol.HTTP         |     Version:  SVN         
 Keywords:  filter http protocol  |       State:  Commit      
----------------------------------+-----------------------------------------
Changes (by erilem):

  * state:  Review => Commit


Comment:

 Replying to [comment:7 etdube]:
 > [...]
 > This also means the second call to read() in the test has a side effect
 of assigning this.options.param to the options object passed to read()
 (i.e. opt2), therefore opt2.params will contain leftover stuff (i.e. the
 {{{foo__eq}}} filter param) from the first call that shouldn't be there.

 The API docs explicitly state that the options object passed to read is
 modified by read and should not be reused. So I'd suggest that we only
 test that read doesn't write to {{{protocol.options.params}}}. See
 [attachment:http_filter_params_fix_with_test.2.patch]. I'll commit that if
 you agree.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3237#comment:8>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer