[OpenLayers-Trac] Re: [OpenLayers] #3431: set opacity on layer divs, not on tiles and markers

OpenLayers trac-20090302 at openlayers.org
Wed Aug 10 03:13:47 EDT 2011

#3431: set opacity on layer divs, not on tiles and markers
  Reporter:  ahocevar  |       Owner:  euzuro      
      Type:  feature   |      Status:  reopened    
  Priority:  minor     |   Milestone:  2.11 Release
 Component:  Layer     |     Version:  SVN         
Resolution:            |    Keywords:              
     State:  Commit    |  
Changes (by erilem):

  * state:  Review => Commit


 Replying to [comment:16 ahocevar]:
 > Eric, are you sure? This doesn't look like a big loss now, because the
 opacity handling code is still in Tile.js and its subclasses. But the
 patch for #3419 would get bloated again significantly by bringing opacity
 handling back to the tile level. I'm just thinking a hack that does
 exactly what's needed for a specific browser bug is better than
 unnecessary dom manipulation in all browsers. But if you say once more
 that you want me to revert, I'll go ahead and do it, and update the patch
 for #3419.

 Andreas, I'm failing to understand why we'd bloat the backbuffer code by
 handling opacity at the tile level. Before [12185] we had a loop to set
 the opacity on child elements, if we go back to tile-level opacity setting
 wouldn't we use the same exact code as before? (I'm probably missing
 something here.) If you still think tile-level opacity setting would bloat
 the tile/backbuffer code feel free to commit your patch. Thanks.

Ticket URL: <http://trac.openlayers.org/ticket/3431#comment:19>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer

More information about the Trac mailing list