[OpenLayers-Trac] Re: [OpenLayers] #3419: Tile simplifications and
partial rewrite
OpenLayers
trac-20090302 at openlayers.org
Thu Aug 11 08:20:03 EDT 2011
#3419: Tile simplifications and partial rewrite
----------------------+-----------------------------------------------------
Reporter: ahocevar | Owner: ahocevar
Type: feature | Status: new
Priority: minor | Milestone: 2.12 Release
Component: Tile | Version: 2.10
Keywords: | State: Review
----------------------+-----------------------------------------------------
Comment(by erilem):
See [attachment:openlayers-3419.5.patch] (and [attachment:4-to-5.diff] for
the diffs between the .4 and .5 patches). Tests pass in IE8, FF5, and
Chromium.
Some comments on the new patch:
Tile.js:
* removal of the {{{draw}}} and {{{beforedraw}}} events
* {{{shouldDraw}}} is now a local variable
Tile/Image.js
* renderTile now calls {{{updateBackBuffer}}}, which is provided by the
{{{ImageMixin}}}
* the {{{Image}}} exposes {{{createBackBuffer}}}, and this method is
responsible to determine whether the back buffer can be created or not
Tile/Image/IFrame.js
* the logic for caching/resetting the back buffer mode was flawed
* the {{{getBackBuffer}}} function is removed, we can rely on Image's
{{{createBackBuffer}}}
Tile/ImageMixin.js
* The {{{updateBackBuffer}}} function is easier to code
* New functions have been introduced, again to make things easier to read
and understand
tests/Tile/Image.html, tests/Tile/Image/IFrame.html,
tests/Tile/ImageMixin.html
* New tests have been added
--
Ticket URL: <http://trac.openlayers.org/ticket/3419#comment:28>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer
More information about the Trac
mailing list