[OpenLayers-Trac] Re: [OpenLayers] #3103: Tap property of Click
Handler, Control.Navigation center-on-tap
OpenLayers
trac-20090302 at openlayers.org
Fri Feb 25 03:44:16 EST 2011
#3103: Tap property of Click Handler, Control.Navigation center-on-tap
--------------------------------+-------------------------------------------
Reporter: crschmidt | Owner:
Type: feature | Status: new
Priority: major | Milestone: 2.11 Release
Component: Control.Navigation | Version: 2.10
Keywords: mobile | State: Review
--------------------------------+-------------------------------------------
Comment(by bartvde):
Hey Chris, a few comments but overall this looks good:
* APIProprety (typo, 2 occurrences in patch)
* handleClick in Navigation.js: should be this.map instead of map (2
occurrences)
* TouchNavigation.js: defaultClick: this.map instead of map
* should the comment on how to disable this behaviour not also make it
into TouchNavigation?
* after tapTolerance there is an extra white line
* firstMouseOver not documented as a property
* then unregister to save processing on further mousemoves -> should this
not say mouseovers?
One question I have is wrt to the default, should this behaviour not be
false by default in Navigation and true by default in TouchNavigation? I
am not sure if people would actually be using Navigation instead of
TouchNavigation if they want to target mobile development? But this is
more of a question than a concern overall.
--
Ticket URL: <http://trac.openlayers.org/ticket/3103#comment:5>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer
More information about the Trac
mailing list