From trac-20090302 at openlayers.org Sat Jan 1 14:02:46 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 1 14:02:48 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2947: allow custom jsfiles array In-Reply-To: <040.92c82ed242950faec24a92ecb1e1158c@openlayers.org> References: <040.92c82ed242950faec24a92ecb1e1158c@openlayers.org> Message-ID: <049.ad214e576a8cb3546ab1ae1feb7b5374@openlayers.org> #2947: allow custom jsfiles array ---------------------+------------------------------------------------------ Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by tschaub): I think what you're proposing with the "noautoload" parameter would be most trivially accomplished by loading the SingleFile.js instead of OpenLayers.js (see r10977). The only hassle with this is typing all the extra script tags. I think the tidiest way to avoid this hassle is to allow typing an array instead. Here are a few variations that accomplish the same: {{{ }}} or {{{ }}} or {{{ }}} or {{{ }}} I think we'd agree this last one is ugly to type. The first is simplest to implement. The others are somewhat forced. And the whole thing is really just for us internally (tests and examples) - I don't think we should try to get too clever. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 1 17:57:11 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 1 17:57:13 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js Message-ID: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: ---------------------+------------------------------------------------------ We have a number of circular dependencies in the library. The current toposort method isn't flexible enough to handle these. In most places where we have circular dependencies, the order that files are executed doesn't matter. A more tolerant toposort method could resolve dependencies even in circular cases - imposing an arbitrary order. Change r10979 is an example of a simplified (and more tolerant) toposort method. If we have a more tolerant toposort, then we can move dependency declaration into the library source files. Doing this would remove the need to force a specific order in a "first" section of a build configuration. The one place where we have a circular dependency that causes trouble is with Class -> Util -> BaseTypes -> Class. The Class function only needs OpenLayers.Util.extend. An arbitrary sort order will not guarantee that Util is loaded before Class. One solution is to move the extend method into the Class source file. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 1 18:35:59 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 1 18:36:01 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.c1037ec86323a5d2d80141830bf84be1@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Changes (by tschaub): * state: => Review Comment: With this change, we can start simplifying the build configuration files - putting dependency declarations in the source. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 2 11:59:51 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 2 11:59:52 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute In-Reply-To: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> References: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> Message-ID: <053.ff8cb2e1769e2cfe2f0ef46a1956880e@openlayers.org> #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute ---------------------------+------------------------------------------------ Reporter: marcjansen | Owner: ahocevar Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Renderer.SVG | Version: 2.10 Resolution: fixed | Keywords: State: Complete | ---------------------------+------------------------------------------------ Changes (by ahocevar): * status: reopened => closed * state: Review => Complete * resolution: => fixed Comment: Thanks marcjansen - the example is now committed with r10991. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 03:14:56 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 03:14:58 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.9d984657e05b7a67c8e4da674b1c1145@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by erilem): I understand that we need Class.js, and therefore Util.js, to be loaded before files that use {{{OpenLayers.Class}}}, but I'm failing to understand why we'd need Util.js to be loaded before Class.js. Sorry if I'm missing the obvious here. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 03:23:16 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 03:23:17 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2947: allow custom jsfiles array In-Reply-To: <040.92c82ed242950faec24a92ecb1e1158c@openlayers.org> References: <040.92c82ed242950faec24a92ecb1e1158c@openlayers.org> Message-ID: <049.4849666b8d6150e7dc2ad251c9143ebe@openlayers.org> #2947: allow custom jsfiles array ---------------------+------------------------------------------------------ Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by erilem): Thanks Tim. Please change the ticket state to Commit if you agree with [attachment:patch-2947-A2.diff]. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 07:53:53 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 07:53:55 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2875: toFloat hell In-Reply-To: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> References: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> Message-ID: <049.d291db97caece8fde24bd3c0e8294fff@openlayers.org> #2875: toFloat hell -----------------------+---------------------------------------------------- Reporter: erilem | Owner: Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: BaseTypes | Version: 2.10 Keywords: | State: Review -----------------------+---------------------------------------------------- Changes (by erilem): * state: => Review * milestone: 3.0 Release => 2.11 Release -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 07:54:04 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 07:54:06 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2875: toFloat hell In-Reply-To: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> References: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> Message-ID: <049.2ffe9555177c43515b0797d6a042030e@openlayers.org> #2875: toFloat hell --------------------+------------------------------------------------------- Reporter: erilem | Owner: Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Util | Version: 2.10 Keywords: | State: Review --------------------+------------------------------------------------------- Changes (by erilem): * component: BaseTypes => Util -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 08:16:31 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 08:16:33 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2993: box handler cancels click Message-ID: <041.7640d68759aa4aeec0e88f5a513e8546@openlayers.org> #2993: box handler cancels click -------------------------+-------------------------------------------------- Reporter: pgiraud | Owner: pgiraud Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Box | Version: 2.10 Keywords: | State: Review -------------------------+-------------------------------------------------- Since the [http://trac.osgeo.org/openlayers/changeset/10871 revision 10871], the box handler prevents the click events from being triggered. As said almost everywhere "The click event occurs when the pointing device button is clicked over an element. A click is defined as a mousedown and mouseup over the same screen location.". This means that "mousedown" and "mouseup" have to occur on the same element. In our case, when "mousedown" is triggered, the box handler creates a new div element which is appended under the mouse cursor. When "mouseup" is triggered, the event target is not the same. The "click" event is not triggered. Before the changeset, the box was positioned with a tiny offset. Now that positioning is better, the box div is exactly under the mouse. A straight way to solve the issue is to position the box under the cursor only once the latter is actually moved. Attached is a patch, and an example to manually test the issue. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 08:51:57 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 08:52:00 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2994: some test_Date_parse tests fail in Chrome 8 and 9 Message-ID: <040.ced73c019356292284f1da69b6dd0fd7@openlayers.org> #2994: some test_Date_parse tests fail in Chrome 8 and 9 ---------------------+------------------------------------------------------ Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: tests | Version: 2.10 Keywords: | State: ---------------------+------------------------------------------------------ Since r10630 (#2778 add ISO date parsing and toISOString for dates) some {{{test_Date_parse}}} tests fail in Chrome 8 and 9. A time-related KML test also fails: {{{ test_extractTracks fail 1 ok 11 ... fail correct time for fifth feature. eq: values differ: got 1272719115000, but expected 1272736815000 }}} -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 08:56:37 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 08:56:39 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2995: make drag handler work with touch events Message-ID: <040.3cda968b7a5671d003547788e481f4b2@openlayers.org> #2995: make drag handler work with touch events --------------------------+------------------------------------------------- Reporter: erilem | Owner: Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: --------------------------+------------------------------------------------- The drag handler is currently based on {{{mousedown}}}, {{{mousemove}}}, and {{{mouseup}}}. This ticket suggests adding touch-based dragging support ({{{touchstart}}}, {{{touchmove}}}, and {{{touchend}}}). -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 09:55:53 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 09:55:54 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2996: make click handler work with touch events Message-ID: <040.e94f1608ef0cfc5ab6ed5cce94d21601@openlayers.org> #2996: make click handler work with touch events ---------------------------+------------------------------------------------ Reporter: erilem | Owner: tschaub Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Click | Version: 2.10 Keywords: | State: ---------------------------+------------------------------------------------ In addition to {{{mousedown}}} and {{{mouseup}}} make the click handler work with {{{touchstart}}} and {{{touchend}}}. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 09:58:12 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 09:58:14 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2993: box handler cancels click In-Reply-To: <041.7640d68759aa4aeec0e88f5a513e8546@openlayers.org> References: <041.7640d68759aa4aeec0e88f5a513e8546@openlayers.org> Message-ID: <050.f63ed4621a814913e9116b84fdd56aee@openlayers.org> #2993: box handler cancels click -------------------------+-------------------------------------------------- Reporter: pgiraud | Owner: pgiraud Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Box | Version: 2.10 Keywords: | State: Commit -------------------------+-------------------------------------------------- Changes (by erilem): * state: Review => Commit Comment: Confirming that tests pass in Chrome 8 and FireFox 3. Good catch. Good patch. Please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 10:24:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 10:24:57 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2997: tests may crash because of delay problems Message-ID: <041.4f7fb602ff0a855bf8fbfc1ba5f104d9@openlayers.org> #2997: tests may crash because of delay problems ---------------------+------------------------------------------------------ Reporter: pgiraud | Owner: Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: tests | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ On some machines and on IE, the Control/Measure test crashes (it doesn't only fail) because of javascript errors due to inappropriate delays management. The following patch prevents the tests sequence to be stuck by avoiding javascript errors. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 10:50:13 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 10:50:14 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2993: box handler cancels click In-Reply-To: <041.7640d68759aa4aeec0e88f5a513e8546@openlayers.org> References: <041.7640d68759aa4aeec0e88f5a513e8546@openlayers.org> Message-ID: <050.de7d1871e962932f7d05c428f83ac940@openlayers.org> #2993: box handler cancels click --------------------------+------------------------------------------------- Reporter: pgiraud | Owner: pgiraud Type: bug | Status: closed Priority: major | Milestone: 2.11 Release Component: Handler.Box | Version: 2.10 Resolution: fixed | Keywords: State: Commit | --------------------------+------------------------------------------------- Changes (by pgiraud): * status: new => closed * resolution: => fixed Comment: Fixed in r10996. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 10:50:56 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 10:50:58 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.c6837b7aa24347f3e7c868fb8b20d99a@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by tschaub): It's a semantic issue. We don't need Util.js to be loaded before Class.js can execute, but Class.js depends on Util.js (OpenLayers.Util.require). Since we use @require comments to specify dependencies, it makes to put a @require comment in Class.js that pulls in Util.js. Since Util.js depends on several BaseTypes, and those BaseTypes use the Class function, we get a circular dependency. These circular dependencies are not a real problem. The problem is the current toposort method - which bombs out in the case of a circular dependency (and is needlessly complex). It is acceptable to resolve a circular dependency with an arbitrary order in cases where the dependency is not used when the library initially loads. The BaseTypes need the Class function to be defined at load time. We can't guarantee this with a circular dependency. The way to guarantee that Class is defined first is to make sure it doesn't depend on anything else that depends on it. So Class.js should depend only on SingleFile.js. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 10:51:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 10:51:57 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.b892aec7bb8b588aa5528e1feb69c6f4@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by tschaub): And I meant {{{OpenLayers.Util.extend}}} above (the only thing that the Class function depends on from Util.js). -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 10:53:45 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 10:53:48 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.fd1753ef0862ce784439d41f6f619ced@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Description changed by tschaub: Old description: > We have a number of circular dependencies in the library. The current > toposort method isn't flexible enough to handle these. In most places > where we have circular dependencies, the order that files are executed > doesn't matter. A more tolerant toposort method could resolve > dependencies even in circular cases - imposing an arbitrary order. > Change r10979 is an example of a simplified (and more tolerant) toposort > method. > > If we have a more tolerant toposort, then we can move dependency > declaration into the library source files. Doing this would remove the > need to force a specific order in a "first" section of a build > configuration. > > The one place where we have a circular dependency that causes trouble is > with Class -> Util -> BaseTypes -> Class. The Class function only needs > OpenLayers.Util.extend. An arbitrary sort order will not guarantee that > Util is loaded before Class. One solution is to move the extend method > into the Class source file. New description: We have a number of circular dependencies in the library. The current toposort method isn't flexible enough to handle these. In most places where we have circular dependencies, the order that files are executed doesn't matter. A more tolerant toposort method could resolve dependencies even in circular cases - imposing an arbitrary order. Change r10979 is an example of a simplified (and more tolerant) toposort method. If we have a more tolerant toposort, then we can move dependency declaration into the library source files. Doing this would remove the need to force a specific order in a "first" section of a build configuration. The one place where we have a circular dependency that causes trouble is with Class -> Util -> BaseTypes -> Class. The Class function only needs OpenLayers.Util.extend. An arbitrary sort order will not guarantee that Class is loaded before the BaseTypes. One solution is to move the extend method into the Class source file. -- -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 10:54:30 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 10:54:32 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.789f36e3d1fc6c5eacfa5ca1f4654719@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by tschaub): Ok, I see the description was off. I meant that we need to guarantee that Class.js is loaded before the BaseTypes. We don't get this guarantee with a circular dependency. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 11:48:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 11:48:29 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2875: toFloat hell In-Reply-To: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> References: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> Message-ID: <049.3e302f2dcfb17728301c6fbb9f93ecb0@openlayers.org> #2875: toFloat hell --------------------+------------------------------------------------------- Reporter: erilem | Owner: Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Util | Version: 2.10 Keywords: | State: Commit --------------------+------------------------------------------------------- Changes (by pgiraud): * state: Review => Commit Comment: I think you can now commit this patch. It looks good. I'd add a comment in the HTML of the manual example though, to explain what the goal of such an example. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 13:14:32 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 13:14:35 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2987: Bing layer's zoom level may be incorrect In-Reply-To: <042.8ccc325fea03506e87272069325c7461@openlayers.org> References: <042.8ccc325fea03506e87272069325c7461@openlayers.org> Message-ID: <051.38a3721c7137315ceddf7fb467b2d4cb@openlayers.org> #2987: Bing layer's zoom level may be incorrect ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Commit ----------------------+----------------------------------------------------- Changes (by tschaub): * state: Review => Commit Comment: Thanks for the continued work on this. Assuming tests pass, please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 13:19:18 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 13:19:19 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2987: Bing layer's zoom level may be incorrect In-Reply-To: <042.8ccc325fea03506e87272069325c7461@openlayers.org> References: <042.8ccc325fea03506e87272069325c7461@openlayers.org> Message-ID: <051.364a283d857dc96bde51ac34cde9d233@openlayers.org> #2987: Bing layer's zoom level may be incorrect -----------------------+---------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Resolution: fixed | Keywords: State: Complete | -----------------------+---------------------------------------------------- Changes (by ahocevar): * status: new => closed * state: Commit => Complete * resolution: => fixed Comment: r10997 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 3 17:36:21 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 3 17:36:23 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2995: make drag handler work with touch events In-Reply-To: <040.3cda968b7a5671d003547788e481f4b2@openlayers.org> References: <040.3cda968b7a5671d003547788e481f4b2@openlayers.org> Message-ID: <049.659bba4ab0c3ee403cc0cdcee38735b2@openlayers.org> #2995: make drag handler work with touch events --------------------------+------------------------------------------------- Reporter: erilem | Owner: Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: --------------------------+------------------------------------------------- Changes (by jorix): * cc: xavier.mamano@? (added) Comment: Very very interesting! But see bug #2936, with #2995 still fail five checks in test_Handler_Drag_endWhenDelayed, failure in b) and f) are easy to reproduce manually (document.onselectstart has only effect in IE). I think that all exit doors must cover with "cancelDrag" proposed in #2936 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 02:40:44 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 02:40:46 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2875: toFloat hell In-Reply-To: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> References: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> Message-ID: <049.50140d3be79c8ca6fba4d323e8a59849@openlayers.org> #2875: toFloat hell --------------------+------------------------------------------------------- Reporter: erilem | Owner: Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Util | Version: 2.10 Keywords: | State: Commit --------------------+------------------------------------------------------- Comment(by erilem): Thanks for the review pgiraud. I had no plan to commit the HTML file. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 02:44:52 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 02:44:54 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2875: toFloat hell In-Reply-To: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> References: <040.005e5f9c237a3f3ecb2d1bc4664afe4b@openlayers.org> Message-ID: <049.d376747f044362edc9f6abfa617adbb9@openlayers.org> #2875: toFloat hell ---------------------+------------------------------------------------------ Reporter: erilem | Owner: Type: bug | Status: closed Priority: major | Milestone: 2.11 Release Component: Util | Version: 2.10 Resolution: fixed | Keywords: State: Commit | ---------------------+------------------------------------------------------ Changes (by erilem): * status: new => closed * resolution: => fixed Comment: Closed in r10998. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 02:52:20 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 02:52:22 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2996: make click handler work with touch events In-Reply-To: <040.e94f1608ef0cfc5ab6ed5cce94d21601@openlayers.org> References: <040.e94f1608ef0cfc5ab6ed5cce94d21601@openlayers.org> Message-ID: <049.2a5e63f556987139b177e80c4276f61e@openlayers.org> #2996: make click handler work with touch events ---------------------------+------------------------------------------------ Reporter: erilem | Owner: tschaub Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Click | Version: 2.10 Keywords: | State: ---------------------------+------------------------------------------------ Comment(by erilem): See the [attachment:patch-2996-A0.diff] patch. With this patch the Click handler can generate {{{click}}} and {{{dblclick}}} events on touch and double touch. This patch depends on the patch attached to #2995, which adds {{{touch}}} events to the {{{Events.BROWSER_EVENTS}}} array. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 02:57:20 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 02:57:22 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.94b5d0d72b5a619696455c532278d7bd@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Commit ---------------------+------------------------------------------------------ Changes (by erilem): * state: Review => Commit Comment: Patch makes sense to me. Please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 03:19:29 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 03:19:31 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2995: make drag handler work with touch events In-Reply-To: <040.3cda968b7a5671d003547788e481f4b2@openlayers.org> References: <040.3cda968b7a5671d003547788e481f4b2@openlayers.org> Message-ID: <049.043fbffc57547024c7c960dfa2750472@openlayers.org> #2995: make drag handler work with touch events --------------------------+------------------------------------------------- Reporter: erilem | Owner: Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: --------------------------+------------------------------------------------- Comment(by erilem): Replying to [comment:1 jorix]: > Very very interesting! > > But see bug #2936, with #2995 still fail five checks in test_Handler_Drag_endWhenDelayed, failure in b) and f) are easy to reproduce manually (document.onselectstart has only effect in IE). > I think that all exit doors must cover with "cancelDrag" proposed in #2936 Thanks. I'll look at your #2936 patch. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 03:19:35 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 03:19:37 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. In-Reply-To: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> References: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> Message-ID: <048.b5bb71a00157eaa49346184b750a3fc7@openlayers.org> #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. --------------------------+------------------------------------------------- Reporter: jorix | Owner: erilem Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: Review --------------------------+------------------------------------------------- Changes (by erilem): * owner: jorix => erilem -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 06:22:47 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 06:22:50 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2998: delay (time consuming) grid tiles move Message-ID: <041.cd2d6db8d97404031cfc3feaf00e6601@openlayers.org> #2998: delay (time consuming) grid tiles move ------------------------+--------------------------------------------------- Reporter: pgiraud | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: Needs More Work ------------------------+--------------------------------------------------- After a bit of profiling, we easily noticed that a large amount of time is spent in the Tile.Image::positionImage method. This method is actually called each time a tile is moved to be positioned somewhere else in the grid, ie. each Layer.Grid::moveGriddedTiles is called. Some quick tests showed that delaying the tiles move until the map stops moving is really improving the user experience. With the attached patch, tests continue to pass on FF3 and Chrome 9. New unit tests and a new example may need to be written. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 06:27:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 06:27:29 2011 Subject: [OpenLayers-Trac] [OpenLayers] #2999: kinetic dragging support Message-ID: <040.57bde431b9bc4d20d0045e883f8fadd7@openlayers.org> #2999: kinetic dragging support -----------------------------+---------------------------------------------- Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.DragPan | Version: 2.10 Keywords: | State: -----------------------------+---------------------------------------------- We, at Camptocamp, did some experiments with "kinetic dragging". Our current "demo" is available at http://c2c-rd-geospatial.demo- camptocamp.com/lib/openlayers/examples/mobile.html. I'm opening this ticket to track our work, and eventually add "kinetic dragging" support to the trunk. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 06:45:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 06:45:11 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2998: delay (time consuming) grid tiles move In-Reply-To: <041.cd2d6db8d97404031cfc3feaf00e6601@openlayers.org> References: <041.cd2d6db8d97404031cfc3feaf00e6601@openlayers.org> Message-ID: <050.8b8afcbbe3aadbc8f8f6c99e9e2086e7@openlayers.org> #2998: delay (time consuming) grid tiles move ------------------------+--------------------------------------------------- Reporter: pgiraud | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: Needs More Work ------------------------+--------------------------------------------------- Comment(by ahocevar): This may be a good option until we finally find some time to rewrite the grid code so tiles no longer need to be positioned, because they use css sizing and positioning with percentages instead of pixels. This will also make it much easier to use arbitrary resolutions, regardless of availability on the server, and animated zooming. In order to not make this endeavor more complicated, I'd only ask to not introduce new APIProperties on tile- and grid-related classes ({{{tileLoadingDelay}}} in this case). Another comment on the patch: how does this play together with viewRequestID, which is used on the tiles and kept track of on the Map? -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 07:45:22 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 07:45:24 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2998: delay (time consuming) grid tiles move In-Reply-To: <041.cd2d6db8d97404031cfc3feaf00e6601@openlayers.org> References: <041.cd2d6db8d97404031cfc3feaf00e6601@openlayers.org> Message-ID: <050.82948c594f912e81527df3c8de27081c@openlayers.org> #2998: delay (time consuming) grid tiles move ------------------------+--------------------------------------------------- Reporter: pgiraud | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: Needs More Work ------------------------+--------------------------------------------------- Comment(by pgiraud): Replying to [comment:1 ahocevar]: > This may be a good option until we finally find some time to rewrite the grid code so tiles no longer need to be positioned, because they use css sizing and positioning with percentages instead of pixels. This will also make it much easier to use arbitrary resolutions, regardless of availability on the server, and animated zooming. I think this doesn't address the same problem since, with this enhancement, we will still call {{{image.src = 'url_to_image'}}} which appears to be expensive. > > In order to not make this endeavor more complicated, I'd only ask to not introduce new APIProperties on tile- and grid-related classes ({{{tileLoadingDelay}}} in this case). I don't really mind removing the {{{tileLoadingDelay}}} from API, though I still think that changing the way tiles are positioned is a completely different feature. > > Another comment on the patch: how does this play together with viewRequestID, which is used on the tiles and kept track of on the Map? This should have no impact. But it has to be confirmed. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 08:16:18 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 08:16:19 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2999: kinetic dragging support In-Reply-To: <040.57bde431b9bc4d20d0045e883f8fadd7@openlayers.org> References: <040.57bde431b9bc4d20d0045e883f8fadd7@openlayers.org> Message-ID: <049.fa2d06801aebb29b9451427a3ff6487f@openlayers.org> #2999: kinetic dragging support -----------------------------+---------------------------------------------- Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.DragPan | Version: 2.10 Keywords: | State: -----------------------------+---------------------------------------------- Comment(by erilem): [attachment:patch-2999-A0.diff] represents the current state of our work. The patch misses tests and API doc comments. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 08:32:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 08:32:11 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3000: mobile development Message-ID: <040.b94cb1b265ace7fa1f73ee6b9d395ed0@openlayers.org> #3000: mobile development ---------------------+------------------------------------------------------ Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: ---------------------+------------------------------------------------------ This is a meta ticket to track mobile support in !OpenLayers. (I'm really hoping it's going to be the 3000th ticket - easy to remember.) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 08:34:41 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 08:34:43 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3000: mobile development In-Reply-To: <040.b94cb1b265ace7fa1f73ee6b9d395ed0@openlayers.org> References: <040.b94cb1b265ace7fa1f73ee6b9d395ed0@openlayers.org> Message-ID: <049.dea2c2f791850c15c542fd6b84e63b40@openlayers.org> #3000: mobile development ---------------------+------------------------------------------------------ Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: ---------------------+------------------------------------------------------ Comment(by erilem): Tickets to track: * #2995 drag handler * #2996 click handler * #2998 delayed tile loaded * #2999 kinetic dragging -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 10:44:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 10:44:57 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3001: Geometry.LineString: Missing variable declaration Message-ID: <039.84de0f3c733ac610c91cc67365f9a65c@openlayers.org> #3001: Geometry.LineString: Missing variable declaration ---------------------------------+------------------------------------------ Reporter: jorix | Owner: Type: bug | Status: new Priority: trivial | Milestone: 2.11 Release Component: Geometry.LineString | Version: 2.10 Keywords: | State: ---------------------------------+------------------------------------------ I found this bug looking at the errors reported by the Closure Compiler. "distance" is not declared in the method "simplify " Patch attached. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 10:46:21 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 10:46:23 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3001: Geometry.LineString: Missing variable declaration In-Reply-To: <039.84de0f3c733ac610c91cc67365f9a65c@openlayers.org> References: <039.84de0f3c733ac610c91cc67365f9a65c@openlayers.org> Message-ID: <048.7766decbec9f78a857f0276c606b6e30@openlayers.org> #3001: Geometry.LineString: Missing variable declaration ---------------------------------+------------------------------------------ Reporter: jorix | Owner: Type: bug | Status: new Priority: trivial | Milestone: 2.11 Release Component: Geometry.LineString | Version: 2.10 Keywords: | State: Review ---------------------------------+------------------------------------------ Changes (by jorix): * state: => Review -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 12:31:05 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 12:31:07 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3002: support tile extent for grid layers Message-ID: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> #3002: support tile extent for grid layers ------------------------+--------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: ------------------------+--------------------------------------------------- Layers that extend Grid base their tile lattice on the layer's maxExtent property. In practice, the maxExtent of a layer corresponds to the data bounds or the map bounds imposed by the user. Neither of these is necessarily coupled to the tile extent of a tile caching service. The [http://wiki.osgeo.org/wiki/WMS_Tiling_Client_Recommendation WMS-C] recommendation and other standards have the server advertise a tile extent. It makes sense for OpenLayers to support a {{{tileExtent}}} property for gridded layers. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 12:32:23 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 12:32:24 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3002: support tile extent for grid layers In-Reply-To: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> References: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> Message-ID: <050.a1300115b54969d58d2fd5089d108edb@openlayers.org> #3002: support tile extent for grid layers ------------------------+--------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: ------------------------+--------------------------------------------------- Comment(by tschaub): Tests and example to follow. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 4 13:35:10 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 4 13:35:13 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3002: support tile extent for grid layers In-Reply-To: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> References: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> Message-ID: <050.42995b32590f62493a66b1bfbe34ba69@openlayers.org> #3002: support tile extent for grid layers ------------------------+--------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: Review ------------------------+--------------------------------------------------- Changes (by tschaub): * state: => Review Comment: Now with example and tests. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 02:44:49 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 02:44:51 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3003: IE throws an error when closing the Browser Window Message-ID: <038.8d87a233eb776fa2607c9f564a1de498@openlayers.org> #3003: IE throws an error when closing the Browser Window ----------------------------------+----------------------------------------- Reporter: jepe | Owner: Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Handler.Box | Version: 2.10 Keywords: IE error dragHandler | State: Awaiting User Feedback ----------------------------------+----------------------------------------- The Openlayers Applikation works fine until I close the Browser Window in IE Version 8. When Closing the Browser Window, I get the error "''this.DragHandler is null or not a object''" Line 183 of /Handler/Box.js This error ''occurs only in IE''. Since I use Openlayers in combination with geoext 1.0, geoext UX and my own code, I have no idea where the error comes from. I tried my application with Openlayers 2.9 and geoext 0.7. With this API-Versions, the error didn't occur. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 03:00:11 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 03:00:13 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3001: Geometry.LineString: Missing variable declaration In-Reply-To: <039.84de0f3c733ac610c91cc67365f9a65c@openlayers.org> References: <039.84de0f3c733ac610c91cc67365f9a65c@openlayers.org> Message-ID: <048.eac2439abc0c6cd269edcdbd6dc7d743@openlayers.org> #3001: Geometry.LineString: Missing variable declaration ----------------------------------+----------------------------------------- Reporter: jorix | Owner: Type: bug | Status: closed Priority: trivial | Milestone: 2.11 Release Component: Geometry.LineString | Version: 2.10 Resolution: fixed | Keywords: State: Review | ----------------------------------+----------------------------------------- Changes (by erilem): * status: new => closed * resolution: => fixed Comment: Closed with r11000. Thanks jorix. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 03:53:47 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 03:53:50 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3003: IE throws an error when closing the Browser Window In-Reply-To: <038.8d87a233eb776fa2607c9f564a1de498@openlayers.org> References: <038.8d87a233eb776fa2607c9f564a1de498@openlayers.org> Message-ID: <047.1b927364c1289673288ccc9744446351@openlayers.org> #3003: IE throws an error when closing the Browser Window ----------------------------------+----------------------------------------- Reporter: jepe | Owner: Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Handler.Box | Version: 2.10 Keywords: IE error dragHandler | State: Review ----------------------------------+----------------------------------------- Changes (by ahocevar): * state: Awaiting User Feedback => Review Comment: This is a regression introduced by r10422. The Handler::destroy method calls Handler.Box::deactivate, which accessed the dragHandler, which is destroyed already. So the fix is to change the destroy method to call destroy on the superclass first, and then remove the dragHandler. See attached patch. Tests for Handler.Box are still missing, but all other tests still pass. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 05:26:43 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 05:26:44 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3003: IE throws an error when closing the Browser Window In-Reply-To: <038.8d87a233eb776fa2607c9f564a1de498@openlayers.org> References: <038.8d87a233eb776fa2607c9f564a1de498@openlayers.org> Message-ID: <047.f7bbeb989ea471983afde234d6cf23d4@openlayers.org> #3003: IE throws an error when closing the Browser Window --------------------------+------------------------------------------------- Reporter: jepe | Owner: Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Handler.Box | Version: 2.10 Resolution: fixed | Keywords: IE error dragHandler State: Review | --------------------------+------------------------------------------------- Changes (by jepe): * status: new => closed * resolution: => fixed Comment: works fine thank you -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 05:44:12 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 05:44:14 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3003: IE throws an error when closing the Browser Window In-Reply-To: <038.8d87a233eb776fa2607c9f564a1de498@openlayers.org> References: <038.8d87a233eb776fa2607c9f564a1de498@openlayers.org> Message-ID: <047.9cfff0eaabf8d8b75e2dd3c975234fed@openlayers.org> #3003: IE throws an error when closing the Browser Window --------------------------+------------------------------------------------- Reporter: jepe | Owner: Type: bug | Status: reopened Priority: minor | Milestone: 2.11 Release Component: Handler.Box | Version: 2.10 Resolution: | Keywords: IE error dragHandler State: Review | --------------------------+------------------------------------------------- Changes (by ahocevar): * status: closed => reopened * resolution: fixed => Comment: Please don't change the ticket state to fixed - this is to be done by a developer after committing the fix. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 08:58:36 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 08:58:38 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2984: Popup appears automatically when using Google Maps API v3 In-Reply-To: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> References: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> Message-ID: <052.fa220b98412bcf1e4bf475acdaa2854e@openlayers.org> #2984: Popup appears automatically when using Google Maps API v3 ------------------------------+--------------------------------------------- Reporter: vladimirc | Owner: euzuro Type: bug | Status: reopened Priority: major | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Resolution: | Keywords: google api v3, popup State: Review | ------------------------------+--------------------------------------------- Changes (by ahocevar): * status: closed => reopened * resolution: fixed => * state: => Review * component: Popup => Layer.Google.v3 Comment: I did some investigation on this, and apparently r10974 is a workaround, not a fix. Fact is that this popup is not something that Google displays. It is that our logic for moving attribution and logo to the container does not work any more, because the popup was added as hidden element as last child of the google map div, and we made it visible by messing with style.display. The attached patch moves this hidden element (if available, i.e. if using a new v3 api that has it) to the container without modifying it. The copyright is also no longer switched between hidden and visible, because we move it to an invisible position (-9999px) anyway. Another positive side effect of this patch is that the PoweredBy logo is clickable again - this was also broken because of this new hidden popup. Because Google now also sets the position of the copyright and logo using element styles, we need to use {{{!important}}} in our css. So this patch also fixes the css, and modifies google.css to use the correct original positions for v3. Tests still pass. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 09:05:43 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 09:05:45 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2984: Popup appears automatically when using Google Maps API v3 In-Reply-To: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> References: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> Message-ID: <052.0236ae3b78a4a8aef97fc94d1d7acd72@openlayers.org> #2984: Popup appears automatically when using Google Maps API v3 ------------------------------+--------------------------------------------- Reporter: vladimirc | Owner: euzuro Type: bug | Status: reopened Priority: major | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Resolution: | Keywords: google api v3, popup State: Review | ------------------------------+--------------------------------------------- Comment(by ahocevar): Please disregard the comment about no longer switching the copyright between hidden and visible - I decided to continue doing so. Better safe than sorry, and eliminates the chance of a regression. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 10:22:51 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 10:22:53 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 Message-ID: <040.0201161fbf56f086734bc477bf8af2ba@openlayers.org> #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 ------------------------------------------------------+--------------------- Reporter: gernot | Owner: ahocevar Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Renderer.VML | Version: 2.10 Keywords: sld, internet explorer, externalGraphics | State: ------------------------------------------------------+--------------------- Rendering (point-)vector data with SLD does not work under InternetExplorer 8. This can bee seen in this OpenLayers Example: http://openlayers.org/dev/examples/sld.html With Firefox, there is one small red marker in the south, with IE8 there is none. As far as i can understand, this is a problem of the OpenLayers.Renderer.VML renderer, it does simply not use the 'externalGraphics' attribute. It almost works, if the 'rotation' element of the PointSymbolizer is set (for example to 360), because the graphicRotate method actually does add the image. In this case, we get a null-access in line 306 (the 'fill' is null here). Please find attached a patch that fixes this problem for the current trunc. After fixing the null-access and using 'rotation' in the sld file, the marker is correctly shown. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 11:43:15 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 11:43:17 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 In-Reply-To: <040.0201161fbf56f086734bc477bf8af2ba@openlayers.org> References: <040.0201161fbf56f086734bc477bf8af2ba@openlayers.org> Message-ID: <049.956e5066799a2123c9cf91924ac2d376@openlayers.org> #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 ------------------------------------------------------+--------------------- Reporter: gernot | Owner: ahocevar Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Renderer.VML | Version: 2.10 Keywords: sld, internet explorer, externalGraphics | State: ------------------------------------------------------+--------------------- Comment(by ahocevar): Thanks for the patch gernot. It is not quite valid, but it helped me to find a real fix (see patch). -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 11:45:31 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 11:45:33 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 In-Reply-To: <040.0201161fbf56f086734bc477bf8af2ba@openlayers.org> References: <040.0201161fbf56f086734bc477bf8af2ba@openlayers.org> Message-ID: <049.f6a17a6436480ce5ffa8df0eb46a3cef@openlayers.org> #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 ---------------------------+------------------------------------------------ Reporter: gernot | Owner: ahocevar Type: bug | Status: closed Priority: major | Milestone: 2.11 Release Component: Renderer.VML | Version: 2.10 Resolution: fixed | Keywords: sld, internet explorer, externalGraphics State: Complete | ---------------------------+------------------------------------------------ Changes (by ahocevar): * status: new => closed * state: => Complete * resolution: => fixed Comment: r11001 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 12:01:00 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 12:01:03 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 In-Reply-To: <040.0201161fbf56f086734bc477bf8af2ba@openlayers.org> References: <040.0201161fbf56f086734bc477bf8af2ba@openlayers.org> Message-ID: <049.4d833550fb5ec7ec0951aeafd3158403@openlayers.org> #3004: ExternalGraphics does not work for SLD with InternetExplorer 8 ---------------------------+------------------------------------------------ Reporter: gernot | Owner: ahocevar Type: bug | Status: closed Priority: major | Milestone: 2.11 Release Component: Renderer.VML | Version: 2.10 Resolution: fixed | Keywords: sld, internet explorer, externalGraphics State: Complete | ---------------------------+------------------------------------------------ Comment(by gernot): Sure, the patch only helped me for my immediate problem; i was actually glad that i worked it out at all ;-) Thanks for the quick fix! -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 12:03:23 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 12:03:26 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3002: support tile extent for grid layers In-Reply-To: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> References: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> Message-ID: <050.b3980e653ef10b22a84453f2adb463fd@openlayers.org> #3002: support tile extent for grid layers ------------------------+--------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: Commit ------------------------+--------------------------------------------------- Changes (by ahocevar): * state: Review => Commit Comment: A clean solution with very few lines of code, saving users a lot of application specific code. Great work. Assuming that tests pass, please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 12:18:43 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 12:18:45 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2967: infinite recursion getting bounds of polygon with empty outer ring In-Reply-To: <041.fea9aaebee611aac31e99f553fbad152@openlayers.org> References: <041.fea9aaebee611aac31e99f553fbad152@openlayers.org> Message-ID: <050.1fa35b9685683b0bdbe0b60fa2af667e@openlayers.org> #2967: infinite recursion getting bounds of polygon with empty outer ring ---------------------------------+------------------------------------------ Reporter: tschaub | Owner: Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Geometry.Collection | Version: 2.10 Keywords: | State: Commit ---------------------------------+------------------------------------------ Comment(by tschaub): Closed w/ r10953. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 12:19:19 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 12:19:20 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2967: infinite recursion getting bounds of polygon with empty outer ring In-Reply-To: <041.fea9aaebee611aac31e99f553fbad152@openlayers.org> References: <041.fea9aaebee611aac31e99f553fbad152@openlayers.org> Message-ID: <050.5f8c9a163777cc7115cd492561b467d0@openlayers.org> #2967: infinite recursion getting bounds of polygon with empty outer ring ----------------------------------+----------------------------------------- Reporter: tschaub | Owner: Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Geometry.Collection | Version: 2.10 Resolution: fixed | Keywords: State: | ----------------------------------+----------------------------------------- Changes (by tschaub): * status: new => closed * state: Commit => * resolution: => fixed -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 12:22:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 12:22:28 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3002: support tile extent for grid layers In-Reply-To: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> References: <041.4a77abe4b317af38594a6544cf2399aa@openlayers.org> Message-ID: <050.03d2fd3b410b47bf99619c9e8428fb76@openlayers.org> #3002: support tile extent for grid layers -------------------------+-------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Resolution: fixed | Keywords: State: | -------------------------+-------------------------------------------------- Changes (by tschaub): * status: new => closed * state: Commit => * resolution: => fixed Comment: In w/ r11002 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 12:50:49 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 12:50:51 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.630150b8b7927ea06f3d45c3fb8e60f8@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Resolution: fixed | Keywords: State: | ----------------------+----------------------------------------------------- Changes (by tschaub): * status: new => closed * state: Commit => * resolution: => fixed Comment: Thanks for the review. In w/ r11003. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 13:42:35 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 13:42:37 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3005: zoomBox never disappear if mouse is released over the overviewMap Message-ID: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> #3005: zoomBox never disappear if mouse is released over the overviewMap ---------------------------------+------------------------------------------ Reporter: gael | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: Component: Control.OverviewMap | Version: SVN Keywords: | State: ---------------------------------+------------------------------------------ Hi, I'm using a map with both overviewMap control and zoomBox Control to navigate on the map. When using the zoomBox control, if you release the mouse on the overviewMap, the zoom is not made and you are still drawing a box. It appears that the Box "endBox" callback is never called and the drag Handler controlling the box never stopped. Finally, if you click somewhere else on the map, your box remains and the zoom behaves as you just double-clicked on that point. Could someone help me find a workaround ? Thanks. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 14:28:03 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 14:28:05 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3006: include SRS id in BBOX parameter Message-ID: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> #3006: include SRS id in BBOX parameter ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol.HTTP | Version: 2.10 Keywords: | State: ---------------------------+------------------------------------------------ Though specs like the [http://www.opensearch.org/Specifications/OpenSearch/Extensions/Geo/1.0/Draft_1#The_.22box.22_parameter Geo Extension to OpenSearch] don't deal with SRS other than EPSG:4326 in bbox requests, other specs like WFS 1.1 allow a bbox with the SRS id as the fifth item. It would be trivial to support this in the HTTP protocol. I'm uncertain if there are services that would choke on a five item bbox. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 14:38:15 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 14:38:16 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3006: include SRS id in BBOX parameter In-Reply-To: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> References: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> Message-ID: <050.9f1bdcacdf215dd68359404b5eb7cbcc@openlayers.org> #3006: include SRS id in BBOX parameter ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol.HTTP | Version: 2.10 Keywords: | State: Review ---------------------------+------------------------------------------------ Changes (by tschaub): * state: => Review Comment: Tests pass. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 16:16:14 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 16:16:17 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3006: include SRS id in BBOX parameter In-Reply-To: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> References: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> Message-ID: <050.46707d63985e32afb7486e81237a6eef@openlayers.org> #3006: include SRS id in BBOX parameter ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol.HTTP | Version: 2.10 Keywords: | State: Review ---------------------------+------------------------------------------------ Comment(by tschaub): Updated patch to introduce {{{srsInBBOX}}} property. Default is false. If true, srs id is included in bbox. Tests still pass. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 19:05:15 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 19:05:17 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3007: add minResolution and maxResolution options per target Message-ID: <041.2ac4f3ec747cf03521d0f39f02c0ccf3@openlayers.org> #3007: add minResolution and maxResolution options per target ------------------------------+--------------------------------------------- Reporter: tschaub | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.Snapping | Version: 2.10 Keywords: | State: ------------------------------+--------------------------------------------- -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 5 19:51:29 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 5 19:51:31 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3007: add minResolution and maxResolution options per target In-Reply-To: <041.2ac4f3ec747cf03521d0f39f02c0ccf3@openlayers.org> References: <041.2ac4f3ec747cf03521d0f39f02c0ccf3@openlayers.org> Message-ID: <050.f377e0679f644089fcf9df180284d532@openlayers.org> #3007: add minResolution and maxResolution options per target ------------------------------+--------------------------------------------- Reporter: tschaub | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.Snapping | Version: 2.10 Keywords: | State: Review ------------------------------+--------------------------------------------- Changes (by tschaub): * state: => Review Comment: Tests pass. Examples still work. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 02:11:59 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 02:12:06 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3007: add minResolution and maxResolution options per target In-Reply-To: <041.2ac4f3ec747cf03521d0f39f02c0ccf3@openlayers.org> References: <041.2ac4f3ec747cf03521d0f39f02c0ccf3@openlayers.org> Message-ID: <050.69d83494277c4d6bbb3a29266bb23caf@openlayers.org> #3007: add minResolution and maxResolution options per target ------------------------------+--------------------------------------------- Reporter: tschaub | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.Snapping | Version: 2.10 Keywords: | State: Commit ------------------------------+--------------------------------------------- Changes (by erilem): * state: Review => Commit Comment: Looks good to me. Thanks. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 02:13:47 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 02:13:51 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3006: include SRS id in BBOX parameter In-Reply-To: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> References: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> Message-ID: <050.639c057bd979710e2174a1219fadae35@openlayers.org> #3006: include SRS id in BBOX parameter ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol.HTTP | Version: 2.10 Keywords: | State: Commit ---------------------------+------------------------------------------------ Changes (by erilem): * state: Review => Commit Comment: Thanks Tim. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 03:57:25 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 03:57:28 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" In-Reply-To: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> References: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> Message-ID: <051.b346c836f32ea642431f71ae0f32cd70@openlayers.org> #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" ----------------------+----------------------------------------------------- Reporter: hsivonen | Owner: Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ----------------------+----------------------------------------------------- Comment(by hsivonen): Did this bug make it onto a reviewer's todo list? -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 07:20:08 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 07:20:09 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3008: Build: Integrate Closure Compiler on OpenLayers Message-ID: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> #3008: Build: Integrate Closure Compiler on OpenLayers ---------------------+------------------------------------------------------ Reporter: jorix | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: ---------------------+------------------------------------------------------ This patch allows the use of compiler integrated into OpenLayers. Features: * Use the configuration files as {{{build.py}}}, e.g. {{{compile.py lite.cfg}}} * Enable debugging of the source using compiled code (the compiler adds OL license and generate the map. The resulting code can be used directly in Firebug 1.5 + Closure Inspector) * Allows the compiler to read the Natural Docs comments like jsDoc. This allows check type information about JavaScript variables to provide enhanced optimization and warnings. e.g. {{{compile.py -m jsDoc library.cfg}}} * By default the undefined variables are not allowed, cause compilation errors. (with {{{compile.py --checks medium}}} (default) and {{{compile.py --checks maximum}}}) * Allow the use of compiler flags ({{{--externs}}} and {{{--compilation_level}}} directly and the rest as "{{{--compiler_flags}}}" (in the same manner as in {{{closurebuilder.py}}} from Closure Library) Most of the patch are new files, there are only two changes on existing files: * {{{lib/OpenLayers/Events.js}}}: Comments for the compiler to ignore an error. * {{{tools/mergejs.js}}}: * Enable two types of calls: return code (to jsmin) and return the list of source file names (to compile) * Enable use files above {{{../lib}}} in paragraphs {{{[first]}}} and {{{[last]}}} of the configuration files e.g. {{{../examples/example.js}}} (this feature is dispensable, I've used it for testing with {{{complile.py ?l ADVANCED_OPTIMIZATIONS lite.cfg}}}, '''51k and that works'''! but it requires adjustments in source code) NOTE: All material is original and is written by me except: * {{{build/closure-compiler/closure- compiler/contrib/externs/google_maps_api_v2.js}}} * {{{tools/closure-library/closure/bin/build/jscompiler.py}}} * and the compiler, of course! '''WARNING''': The compiler is the only material that '''is not in the patch'''. "{{{compiler.jar}}}" must be downloaded from: http://code.google.com/p/closure-compiler/downloads/detail?name=compiler- latest.zip&can=2&q= to the folder: "{{{tools/closure-compiler/bin/}}}" This is a large patch, with many details. '''Try it'''. I can give any necessary explanations. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 09:28:29 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 09:28:31 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2972: Closure Compiler for OpenLayers 2.x In-Reply-To: <039.6aa8465761593cbed9cf6c16abbb844f@openlayers.org> References: <039.6aa8465761593cbed9cf6c16abbb844f@openlayers.org> Message-ID: <048.a795c377873faed9a5ea6fa6c083b5f0@openlayers.org> #2972: Closure Compiler for OpenLayers 2.x ------------------------+--------------------------------------------------- Reporter: jorix | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Resolution: duplicate | Keywords: State: | ------------------------+--------------------------------------------------- Changes (by jorix): * status: new => closed * state: Needs Discussion => * resolution: => duplicate Comment: See #3008 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 13:06:18 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 13:06:20 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3005: zoomBox never disappear if mouse is released over the overviewMap In-Reply-To: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> References: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> Message-ID: <047.e0f4abfb0213e5ad86f31e37f626b914@openlayers.org> #3005: zoomBox never disappear if mouse is released over the overviewMap ---------------------------------+------------------------------------------ Reporter: gael | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: Component: Control.OverviewMap | Version: SVN Keywords: | State: ---------------------------------+------------------------------------------ Comment(by gael): Fortunately,I succeded in finding a solution for that problem, as it seams to be working on my side. The issues comes from a strange inversion of ''fallThrough'' parameters in '''overviewMap.js''' file. {{{ 487 // create the overview map 488 var options = OpenLayers.Util.extend( 489 {controls: [], maxResolution: 'auto', 490 fallThrough: false}, this.mapOptions); . . . 528 this.rectEvents = new OpenLayers.Events(this, this.extentRectangle, 529 null, true); }}} became {{{ 487 // create the overview map 488 var options = OpenLayers.Util.extend( 489 {controls: [], maxResolution: 'auto', 490 fallThrough: true}, this.mapOptions); . . . 528 this.rectEvents = new OpenLayers.Events(this, this.extentRectangle, 529 null, false); }}} and the zoomBox control is back to a normal behaviour. Ohh crap stupid thing ... -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 14:10:14 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 14:10:16 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3009: ModifyFeature control does not trigger the beforefeaturemodified event in standalone mode Message-ID: <042.26a55097c1508e72d2f4ac7405e5a5ce@openlayers.org> #3009: ModifyFeature control does not trigger the beforefeaturemodified event in standalone mode -----------------------------------+---------------------------------------- Reporter: ahocevar | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Keywords: | State: Review -----------------------------------+---------------------------------------- The attached patch makes the ModifyFeature control trigger the beforefeaturemodified event also in standalone mode. It also improves APIdocs and makes selectFeature an APIMethod to match the documentation of the standalone property. Patch with tests, tests pass in Safari5. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 15:19:00 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 15:19:02 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3008: Build: Integrate Closure Compiler on OpenLayers In-Reply-To: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> References: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> Message-ID: <048.51c95bb234442416fcec96a45c452a74@openlayers.org> #3008: Build: Integrate Closure Compiler on OpenLayers ---------------------+------------------------------------------------------ Reporter: jorix | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Changes (by jorix): * state: => Review Comment: Thanks for any comments, questions, suggestions or review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 16:39:58 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 16:40:00 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3006: include SRS id in BBOX parameter In-Reply-To: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> References: <041.b475de8f3a36c83b9bb9b57209dc2e6d@openlayers.org> Message-ID: <050.4186b8cf1f09fdf271cf7ae48f659ef1@openlayers.org> #3006: include SRS id in BBOX parameter ----------------------------+----------------------------------------------- Reporter: tschaub | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Protocol.HTTP | Version: 2.10 Resolution: fixed | Keywords: State: | ----------------------------+----------------------------------------------- Changes (by tschaub): * status: new => closed * state: Commit => * resolution: => fixed Comment: Thanks for the review. In w/ r11015. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 16:42:00 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 16:42:01 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3007: add minResolution and maxResolution options per target In-Reply-To: <041.2ac4f3ec747cf03521d0f39f02c0ccf3@openlayers.org> References: <041.2ac4f3ec747cf03521d0f39f02c0ccf3@openlayers.org> Message-ID: <050.a4b12bb04d2dff36bc1631112b15c18b@openlayers.org> #3007: add minResolution and maxResolution options per target -------------------------------+-------------------------------------------- Reporter: tschaub | Owner: tschaub Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Control.Snapping | Version: 2.10 Resolution: fixed | Keywords: State: | -------------------------------+-------------------------------------------- Changes (by tschaub): * status: new => closed * state: Commit => * resolution: => fixed Comment: Thanks for the review. In w/ r11016. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 6 19:14:14 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 6 19:14:16 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3005: zoomBox never disappear if mouse is released over the overviewMap In-Reply-To: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> References: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> Message-ID: <047.32117dfdc125aaf9148e9dcdd5fb6b0c@openlayers.org> #3005: zoomBox never disappear if mouse is released over the overviewMap ---------------------------------+------------------------------------------ Reporter: gael | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: Component: Control.OverviewMap | Version: SVN Keywords: | State: ---------------------------------+------------------------------------------ Comment(by jorix): Replying to [comment:1 gael]: > Fortunately,I succeded in finding ... This is not a solution. The aplicanci?n of these changes can start a DragPan or ZoomBox of the main map in the OverviewMap The problem also is DragPan, if you release the mouse on the OverviewMap drag remains active. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 7 04:16:57 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 7 04:16:59 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3005: zoomBox never disappear if mouse is released over the overviewMap In-Reply-To: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> References: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> Message-ID: <047.30b62c5915db6d1d89e31ff0d3c80c0f@openlayers.org> #3005: zoomBox never disappear if mouse is released over the overviewMap ---------------------------------+------------------------------------------ Reporter: gael | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: Component: Control.OverviewMap | Version: SVN Keywords: | State: ---------------------------------+------------------------------------------ Comment(by gael): Replying to [comment:2 jorix]: > This is not a solution. ... This also solves the remain-active DragPan problem. (never noticed this one^^) The fact that you can start a dragPan or a zoomBox in the overviewMap is not so problematic, as the drag of the map extent in the overview is still working properly. I think my users will accommodate. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 7 09:54:22 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 7 09:54:23 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3005: zoomBox never disappear if mouse is released over the overviewMap In-Reply-To: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> References: <038.576850c34cf569f7a84a75dcef5fa050@openlayers.org> Message-ID: <047.dd47d58f1e3471ce204f18f5d4ffdc05@openlayers.org> #3005: zoomBox never disappear if mouse is released over the overviewMap ---------------------------------+------------------------------------------ Reporter: gael | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: Component: Control.OverviewMap | Version: SVN Keywords: | State: ---------------------------------+------------------------------------------ Comment(by jorix): Replying to [comment:3 gael]: > ... I think my users will accommodate. Yes the feeling is not so confusing, but I think the behavior is still wrong with DragPan and ZoomBox. I do not know what is the opinion of OpenLayers. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 7 12:10:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 7 12:10:29 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3008: Build: Integrate Closure Compiler on OpenLayers In-Reply-To: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> References: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> Message-ID: <048.c8cd256bd961ec47239e3407ff8f80c7@openlayers.org> #3008: Build: Integrate Closure Compiler on OpenLayers ---------------------+------------------------------------------------------ Reporter: jorix | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by jorix): Clarification about "'''externs'''" Closure Compiler '''does not include externs in the output JavaScript'''. In the case of "compile.py" are necessary to avoid errors of undefined variables, e.g. variables defined by commercial maps which gives access OpenLayers. See more: http://code.google.com/intl/ca/closure/compiler/docs /api-tutorial3.html#externs -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 7 13:49:24 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 7 13:49:26 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute In-Reply-To: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> References: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> Message-ID: <053.aa722f63f950646732dfc9f163acc126@openlayers.org> #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute ---------------------------+------------------------------------------------ Reporter: marcjansen | Owner: ahocevar Type: bug | Status: reopened Priority: minor | Milestone: 2.11 Release Component: Renderer.SVG | Version: 2.10 Resolution: | Keywords: State: Complete | ---------------------------+------------------------------------------------ Changes (by ahocevar): * status: closed => reopened * resolution: fixed => Comment: The advice I gave in [comment:2] was a bad one. The code for {{{nodeName != "svg"}}} is still needed. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 7 13:50:45 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 7 13:50:47 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute In-Reply-To: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> References: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> Message-ID: <053.85bdc7063a963f2557e8b72993806345@openlayers.org> #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute ---------------------------+------------------------------------------------ Reporter: marcjansen | Owner: ahocevar Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Renderer.SVG | Version: 2.10 Resolution: fixed | Keywords: State: Complete | ---------------------------+------------------------------------------------ Changes (by ahocevar): * status: reopened => closed * resolution: => fixed Comment: fixed with r11018 - thanks cmoullet for spotting this issue. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 7 17:23:11 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 7 17:23:13 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute In-Reply-To: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> References: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> Message-ID: <053.ef41898d6810bdfa58cefa175f3476df@openlayers.org> #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute ---------------------------+------------------------------------------------ Reporter: marcjansen | Owner: ahocevar Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Renderer.SVG | Version: 2.10 Resolution: fixed | Keywords: State: Complete | ---------------------------+------------------------------------------------ Comment(by tschaub): I put the v3.2 bit back in the examples in r11019. Please clarify if this was indeed supposed to be removed. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 8 13:24:24 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 8 13:24:26 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2989: Documentation: some distractions and omissions In-Reply-To: <039.a38983218afcf19abbced4ce007c43ae@openlayers.org> References: <039.a38983218afcf19abbced4ce007c43ae@openlayers.org> Message-ID: <048.10acccc31970cffdd506d5ade8a487aa@openlayers.org> #2989: Documentation: some distractions and omissions ---------------------------+------------------------------------------------ Reporter: jorix | Owner: Type: bug | Status: new Priority: trivial | Milestone: 2.11 Release Component: documentation | Version: 2.10 Keywords: | State: Review ---------------------------+------------------------------------------------ Comment(by jorix): I added another patch with more distractions detected by the Closure Compiler (see #3008), most of them can be seen by calling the compiler in {{{build/}}} with: {{{compile.py --mode=jsDoc full.cfg}}} Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 9 12:34:22 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 9 12:34:24 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3008: Build: Integrate Closure Compiler on OpenLayers In-Reply-To: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> References: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> Message-ID: <048.d084f0cec46fd0d47e5a009c0534aa5b@openlayers.org> #3008: Build: Integrate Closure Compiler on OpenLayers ---------------------+------------------------------------------------------ Reporter: jorix | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by jorix): Attached [attachment:cc-ol-compiler-3008.2.patch new patch]. Contains only minor changes in "compile.py": improvements in initial checks. NOTE: {{{tools/closure-library/closure/bin/build/jscompiler.py}}} requires version Python-2.4 or higher. Thanks for any feedback or review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 9 17:40:05 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 9 17:40:08 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute In-Reply-To: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> References: <044.1e7f76615de38b23dbc70aa3cdc1cc11@openlayers.org> Message-ID: <053.c07cdb7eb7d96f30b0c47df337ad609b@openlayers.org> #2985: Ctrl-Click or Shift-Click on a SVG-feature with named graphic opens new window because of / and the href-attribute ---------------------------+------------------------------------------------ Reporter: marcjansen | Owner: ahocevar Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Renderer.SVG | Version: 2.10 Resolution: fixed | Keywords: State: Complete | ---------------------------+------------------------------------------------ Comment(by ahocevar): Thanks tschaub for your sharp eye. In fact there were even more changes committed with r11018 that were part of #2984. I reverted the remaining ones with r11021. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 10 09:45:08 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 10 09:45:10 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2956: script protocol for reading features cross-origin In-Reply-To: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> References: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> Message-ID: <050.115ddf3132edec8d05d2324a3e2f3338@openlayers.org> #2956: script protocol for reading features cross-origin ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: fredj Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol | Version: 2.10 Keywords: | State: ----------------------+----------------------------------------------------- Comment(by pgiraud): Hi Tim, I went further with your great work. First of all, I fixed 2 typos (See [http://trac.osgeo.org/openlayers/changeset/11022 11022]). Then I put the OL.Protocol.HTTP:filterToParams method into a FilterSerializer mixin so that it can be shared between HTTP and Script protocols (See [http://trac.osgeo.org/openlayers/changeset/11023 11023])[[BR]] This may be an advantage in two cases :[[BR]] - this helps users if they want to create their own custom filter serializer,[[BR]] - this helps building a lighter library if we only want the Script protocol, since it removes dependency on the HTTP one.[[BR]] I also hope you're OK with me committing directly to your sandbox. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 10 13:12:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 10 13:12:56 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.5120ed6d077b084fbda453c81bd96d8a@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Resolution: fixed | Keywords: State: | ----------------------+----------------------------------------------------- Comment(by jorix): Replying to [comment:8 tschaub]: > ... In w/ r11003. See also the remaining loops (in current r11025): {{{ Lang.js -> BaseTypes.js -> Lang.js BaseTypes/Element.js -> Util.js -> BaseTypes/Element.js }}} -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 10 13:26:58 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 10 13:26:59 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.65d8a0a65d61c4b26817eeb2bfb503f4@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Resolution: fixed | Keywords: State: | ----------------------+----------------------------------------------------- Comment(by jorix): On the other hand "util.js" uses !OpenLayers.Util.extend, and can not be loaded without "BaseTypes/Class.js" but is not declared as a @requires in "util.js". -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 10 15:36:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 10 15:36:11 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2992: move OpenLayers.Util.extend to Class.js In-Reply-To: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> References: <041.6508b64439378bb4b88c3e53c1cf7636@openlayers.org> Message-ID: <050.6d992d4151685b685325fcefa99ecd96@openlayers.org> #2992: move OpenLayers.Util.extend to Class.js ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Resolution: fixed | Keywords: State: | ----------------------+----------------------------------------------------- Changes (by jorix): * cc: xavier.mamano@? (added) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 10 20:07:14 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 10 20:07:16 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2754: WMS tiles not loading when map region crossing international date line(IDL) In-Reply-To: <041.54fe1b153c709438c3a9666f1d3a3458@openlayers.org> References: <041.54fe1b153c709438c3a9666f1d3a3458@openlayers.org> Message-ID: <050.92f7ee654bf64cfc6f4e7432ac42d096@openlayers.org> #2754: WMS tiles not loading when map region crossing international date line(IDL) ----------------------+----------------------------------------------------- Reporter: Senthil | Owner: euzuro Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: Layer | Version: 2.9 Keywords: | State: ----------------------+----------------------------------------------------- Changes (by senthil): * state: Review => -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 10 20:09:33 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 10 20:09:35 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2754: WMS tiles not loading when map region crossing international date line(IDL) In-Reply-To: <041.54fe1b153c709438c3a9666f1d3a3458@openlayers.org> References: <041.54fe1b153c709438c3a9666f1d3a3458@openlayers.org> Message-ID: <050.de8e47b3d397a76ab796748665a221ce@openlayers.org> #2754: WMS tiles not loading when map region crossing international date line(IDL) ----------------------+----------------------------------------------------- Reporter: Senthil | Owner: euzuro Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: Layer | Version: 2.9 Keywords: | State: Review ----------------------+----------------------------------------------------- Changes (by senthil): * state: => Review -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 12 05:11:35 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 12 05:11:37 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. In-Reply-To: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> References: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> Message-ID: <048.cca61051729e9adcab51d9efe21bcc96@openlayers.org> #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. --------------------------+------------------------------------------------- Reporter: jorix | Owner: erilem Type: bug | Status: new Priority: blocker | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: Review --------------------------+------------------------------------------------- Changes (by erilem): * priority: minor => blocker Comment: I just came across the issue. This is a big issue! -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 12 08:28:38 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 12 08:28:40 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2956: script protocol for reading features cross-origin In-Reply-To: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> References: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> Message-ID: <050.d92178454620aecf1b514e13b7a0c7f7@openlayers.org> #2956: script protocol for reading features cross-origin ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: fredj Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol | Version: 2.10 Keywords: | State: Review ----------------------+----------------------------------------------------- Changes (by pgiraud): * state: => Review Comment: Patch attached. Please review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 12 23:47:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 12 23:47:29 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3010: WFS transactions should work for features with null geometry Message-ID: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> #3010: WFS transactions should work for features with null geometry -------------------------+-------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Keywords: | State: -------------------------+-------------------------------------------------- Ticket #2033 dealt with features that have no geometry field in the schema. It is also acceptable to have a geometry field and issue transactions with null geometry. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 12 23:48:46 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 12 23:48:48 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3010: WFS transactions should work for features with null geometry In-Reply-To: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> References: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> Message-ID: <050.d3ba125fb83fd15660a43d0f1e0a28b2@openlayers.org> #3010: WFS transactions should work for features with null geometry -------------------------+-------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Keywords: | State: Review -------------------------+-------------------------------------------------- Changes (by tschaub): * state: => Review Comment: Tests pass. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 13 06:21:02 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 13 06:21:05 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3010: WFS transactions should work for features with null geometry In-Reply-To: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> References: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> Message-ID: <050.79ae361ba5abaaebb4730aea5051966b@openlayers.org> #3010: WFS transactions should work for features with null geometry -------------------------+-------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Keywords: | State: Commit -------------------------+-------------------------------------------------- Changes (by ahocevar): * state: Review => Commit Comment: Thanks for the verbose tests. Great work. Please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 13 13:55:37 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 13 13:55:39 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3011: Support tileOrigin for all Grid layers. Message-ID: <041.9d30f0c18d60fa9126806a2b35da40e5@openlayers.org> #3011: Support tileOrigin for all Grid layers. ------------------------+--------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: ------------------------+--------------------------------------------------- In r11002, support was added for a {{{tileExtent}}} property. This was a quick fix to make gridded layers work with cached tile sets with a lattice that doesn't align with the layer's {{{maxExtent}}} property. However, the "bottom left" assumption is still baked in (the lattice is aligned with the bottom left of the tileExtent or maxExtent). This still doesn't work for all tile caches. The proper way to support tile caches with our gridded layers is to support a {{{tileOrigin}}} property. It also makes sense to pull out the "bottom left" assumption into a property that other layers can override. To avoid overlapping property proliferation, and because the behavior with {{{tileExtent}}} is not really adequate (we also still request tiles outside the {{{tileExtent}}}), I'd like to remove that property and only add {{{tileOrigin}}} to the API. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 13 14:38:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 13 14:38:10 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3010: WFS transactions should work for features with null geometry In-Reply-To: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> References: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> Message-ID: <050.22216c91f3b8b8a8255cc6528b120fed@openlayers.org> #3010: WFS transactions should work for features with null geometry --------------------------+------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Resolution: fixed | Keywords: State: | --------------------------+------------------------------------------------- Changes (by tschaub): * status: new => closed * state: Commit => * resolution: => fixed Comment: Thanks for the review. Closed w/ r11031. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 13 16:24:34 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 13 16:24:36 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3010: WFS transactions should work for features with null geometry In-Reply-To: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> References: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> Message-ID: <050.c31c4b6609c364753c8b88384b0ca414@openlayers.org> #3010: WFS transactions should work for features with null geometry --------------------------+------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: reopened Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Resolution: | Keywords: State: | --------------------------+------------------------------------------------- Changes (by tschaub): * status: closed => reopened * resolution: fixed => Comment: Ok, so it turns out that while GeoServer accepts {{{}}} as a null for Geometry, the correct way to do an update with a property value of null is to omit the {{{}}} element altogether. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 13 16:27:57 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 13 16:27:58 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3010: WFS transactions should work for features with null geometry In-Reply-To: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> References: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> Message-ID: <050.a537703af0900531c13a538b3fb82110@openlayers.org> #3010: WFS transactions should work for features with null geometry --------------------------+------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: reopened Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Resolution: | Keywords: State: Review | --------------------------+------------------------------------------------- Changes (by tschaub): * state: => Review Comment: We already had the correct behavior in the {{{}}} writer. Where this writer encounters null values, it writes a {{{}}} but not a {{{wfs:Value}}} element. The exception with geometry was because we were waiting to set the format's {{{srsName}}} property until the geometry was written. By setting {{{srsName}}} earlier, we can pass the geometry along to the {{{}}} writer and this does the right thing if the geometry is null. Tests passing. Thanks for review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 13 19:07:30 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 13 19:07:31 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3012: write FID filter in logical filter Message-ID: <041.eb7942a5b644cfca81b7de705135ecdb@openlayers.org> #3012: write FID filter in logical filter ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.Filter | Version: 2.10 Keywords: | State: ---------------------------+------------------------------------------------ Though the Filter Encoding spec doesn't allow it, we could be liberal and write a FID filter in a logical filter without complaining. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 06:39:12 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 06:39:13 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3012: write FID filter in logical filter In-Reply-To: <041.eb7942a5b644cfca81b7de705135ecdb@openlayers.org> References: <041.eb7942a5b644cfca81b7de705135ecdb@openlayers.org> Message-ID: <050.2f861f9a3b9dc40569fe17b1ac0351ae@openlayers.org> #3012: write FID filter in logical filter ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.Filter | Version: 2.10 Keywords: | State: ---------------------------+------------------------------------------------ Comment(by ahocevar): I also attached a patch I had created some time ago, but didn't create a ticket back then because it goes beyond the spec. But I agree that we want to have this feature. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 07:14:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 07:14:11 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3013: Add "mapVersion" parameter to Bing layer Message-ID: <042.cc2d41e3d39e8445c922774afc311992@openlayers.org> #3013: Add "mapVersion" parameter to Bing layer ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Review ----------------------+----------------------------------------------------- From the dev list: {{{ Hello OpenLayers Developers! It's my first time submitting a patch to OpenLayers, so my apologies in advance if I'm going about it in the wrong way... I recently needed to control which imagery set was used on my Bing map, using the new REST-ful Bing tile access API and the related OpenLayers layer type. I didn't see a way to pass in the proper parameters to the "get metadata" call Bing uses, and so I modified OpenLayers appropriately and generated the attached patch against trunk. In short, if you set the new param to "v1", you can use the same tileset Bing is using on their website now (which they say will become the default if you don't specify a tile version sometime in the future). Hoping somebody can review this and commit it to trunk for me? Thanks--feedback welcomed, of course. -Jeff -- Jeff Maki Project Lead OpenPlans }}} -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 08:24:39 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 08:24:40 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3013: Add "mapVersion" parameter to Bing layer In-Reply-To: <042.cc2d41e3d39e8445c922774afc311992@openlayers.org> References: <042.cc2d41e3d39e8445c922774afc311992@openlayers.org> Message-ID: <051.409cc7fe52db47231e7ea48e57c308a5@openlayers.org> #3013: Add "mapVersion" parameter to Bing layer ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Commit ----------------------+----------------------------------------------------- Changes (by ahocevar): * state: Review => Commit Comment: Thanks Jeff for the contribution. I think we can take this one step further and make custom Get Imagery Metadata request parameters possible. I added tests and an example usage. Tests pass. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 08:29:20 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 08:29:21 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3013: Add "mapVersion" parameter to Bing layer In-Reply-To: <042.cc2d41e3d39e8445c922774afc311992@openlayers.org> References: <042.cc2d41e3d39e8445c922774afc311992@openlayers.org> Message-ID: <051.33419ae8cda188c7c4d5a1ebec2b4abd@openlayers.org> #3013: Add "mapVersion" parameter to Bing layer -----------------------+---------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Resolution: fixed | Keywords: State: Complete | -----------------------+---------------------------------------------------- Changes (by ahocevar): * status: new => closed * state: Commit => Complete * resolution: => fixed Comment: in w/ r11032 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 09:04:52 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 09:04:55 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3010: WFS transactions should work for features with null geometry In-Reply-To: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> References: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> Message-ID: <050.d9aa19ed082d4240cd5b98e44c6ebad0@openlayers.org> #3010: WFS transactions should work for features with null geometry --------------------------+------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: reopened Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Resolution: | Keywords: State: Commit | --------------------------+------------------------------------------------- Changes (by ahocevar): * state: Review => Commit Comment: Looks like a simple fix, but I can imagine it took some quite some time to find this very elegant solution! Thanks for the hard work on this. Assuming that tests pass, please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 09:42:01 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 09:42:03 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3011: Support tileOrigin for all Grid layers. In-Reply-To: <041.9d30f0c18d60fa9126806a2b35da40e5@openlayers.org> References: <041.9d30f0c18d60fa9126806a2b35da40e5@openlayers.org> Message-ID: <050.39ca410a20130f109377c8327bd5c7cc@openlayers.org> #3011: Support tileOrigin for all Grid layers. ------------------------+--------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: ------------------------+--------------------------------------------------- Comment(by ahocevar): I am in favor of this change. In case you meant to set this ticket's state to "Review", I'd set it "Commit" now. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 10:47:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 10:47:10 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3011: Support tileOrigin for all Grid layers. In-Reply-To: <041.9d30f0c18d60fa9126806a2b35da40e5@openlayers.org> References: <041.9d30f0c18d60fa9126806a2b35da40e5@openlayers.org> Message-ID: <050.a1b5ea8253d538859a44c68eceda6f4a@openlayers.org> #3011: Support tileOrigin for all Grid layers. ------------------------+--------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: Commit ------------------------+--------------------------------------------------- Changes (by tschaub): * state: => Commit Comment: Great, thanks. I did mean to set it to Review status. I wanted to get feedback about how it worked in a few environments first. Got that feedback, and I think it is working as expected. Thanks for the review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 10:54:29 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 10:54:32 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2193: Allow line breaks/newline in SVG vector labels In-Reply-To: <040.28f3527145f54afe9395c2880048c8a3@openlayers.org> References: <040.28f3527145f54afe9395c2880048c8a3@openlayers.org> Message-ID: <049.a1729faae563ee491ec4deb0e85b7063@openlayers.org> #2193: Allow line breaks/newline in SVG vector labels --------------------------------------------+------------------------------- Reporter: Lucent | Owner: ahocevar Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Renderer.SVG | Version: 2.8 Keywords: newline, linebreak, line break | State: --------------------------------------------+------------------------------- Comment(by PadovaBoy): Hi, i suggest this snipplet (it works well for me) drawText = function(featureId, style, location) { var resolution = this.getResolution(); var x = (location.x / resolution + this.left); var y = (location.y / resolution - this.top); var label = this.nodeFactory(featureId + this.LABEL_ID_SUFFIX, "text"); label.setAttributeNS(null, "x", x); label.setAttributeNS(null, "y", -y); if (style.fontColor) { label.setAttributeNS(null, "fill", style.fontColor); } if (style.fontOpacity) { label.setAttributeNS(null, "opacity", style.fontOpacity); } if (style.fontFamily) { label.setAttributeNS(null, "font- family", style.fontFamily); } if (style.fontSize) { label.setAttributeNS(null, "font- size", style.fontSize); } if (style.fontWeight) { label.setAttributeNS(null, "font- weight", style.fontWeight); } var align = style.labelAlign || "cm"; label.setAttributeNS(null, "text-anchor", OpenLayers.Renderer.SVG.LABEL_ALIGN[align[0]] || "middle"); var rows = []; if (style.label.indexOf('\n')) { rows = style.label.split('\n'); } else { rows.push(style.label); } var fontSize = parseFloat(style.fontSize.replace('px','')); for (var i = 0; i < rows.length; i++) { var tspan = this.nodeFactory(featureId + this.LABEL_ID_SUFFIX + "_tspan_"+i, "tspan"); if (style.labelSelect === true) { label.setAttributeNS(null, "pointer-events", "visible"); label._featureId = featureId; tspan._featureId = featureId; tspan._geometry = location; tspan._geometryClass = location.CLASS_NAME; } else { label.setAttributeNS(null, "pointer-events", "none"); } if (this.isGecko) { label.setAttributeNS(null, "dominant-baseline", OpenLayers.Renderer.SVG.LABEL_ALIGN[align[1]] || "central"); } else { tspan.setAttributeNS(null, "baseline-shift", OpenLayers.Renderer.SVG.LABEL_VSHIFT[align[1]] || "-35%"); } tspan.textContent = rows[i]; tspan.setAttribute("x",x); tspan.setAttribute("y", -(y - (fontSize*i))); if (!label.parentNode) { label.appendChild(tspan); } } this.textRoot.appendChild(label); }; -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 10:57:11 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 10:57:14 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3011: Support tileOrigin for all Grid layers. In-Reply-To: <041.9d30f0c18d60fa9126806a2b35da40e5@openlayers.org> References: <041.9d30f0c18d60fa9126806a2b35da40e5@openlayers.org> Message-ID: <050.945117c7579cbbbaddb217c713136330@openlayers.org> #3011: Support tileOrigin for all Grid layers. -------------------------+-------------------------------------------------- Reporter: tschaub | Owner: elemoine Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Resolution: fixed | Keywords: State: | -------------------------+-------------------------------------------------- Changes (by tschaub): * status: new => closed * state: Commit => * resolution: => fixed Comment: Closed with r11033. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 14 11:13:38 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 14 11:13:40 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3010: WFS transactions should work for features with null geometry In-Reply-To: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> References: <041.52670288512260a84af11ec38cb5e3fc@openlayers.org> Message-ID: <050.2b3925e285e86599308ff4a2b876d4f9@openlayers.org> #3010: WFS transactions should work for features with null geometry --------------------------+------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Format.WFST | Version: 2.10 Resolution: fixed | Keywords: State: | --------------------------+------------------------------------------------- Changes (by tschaub): * status: reopened => closed * state: Commit => * resolution: => fixed Comment: Thanks for the review. Closed w/ r11034. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 15 05:35:53 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 15 05:35:55 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2046: cannot combine draggable layer and selectable layer on one map In-Reply-To: <042.21e4a7c3b97a1d59e71a8a2b16573d2b@openlayers.org> References: <042.21e4a7c3b97a1d59e71a8a2b16573d2b@openlayers.org> Message-ID: <051.0a5c4b8c5889b3f4df03b788127d0645@openlayers.org> #2046: cannot combine draggable layer and selectable layer on one map -----------------------------------------------------------------+---------- Reporter: yourcelf | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.SelectFeature | Version: 2.7 Keywords: drag dragfeature selectfeature draggable selectable | State: -----------------------------------------------------------------+---------- Comment(by bartvde): The problem here is that events cannot be handled on multiple vector layers. In order to support multiple vector layers, the SelectFeature Control uses a RootContainer, but since we are now dealing with both a SelectFeature and a DragFeature control this is not really an option. The real solution would be to integrate tschaub's FeatureAgent into OpenLayers, however this would be a significant effort of multiple days work at least. So as a workaround I came up with a temporary patch so that this use case can be supported in an application. I have tested the approach in FF3, Safari 5 and IE8. The workaround is a bit hacky at the moment, especially the part in Handler/Feature for which I need to find some more time to look into it, maybe then I can come up with a better solution. For now attaching the patch. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 15 13:08:33 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 15 13:08:34 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2629: OpenLayers.Event: new transversal method addListener. In-Reply-To: <039.b85970ae0efb1af3abc0a2dcd3282e35@openlayers.org> References: <039.b85970ae0efb1af3abc0a2dcd3282e35@openlayers.org> Message-ID: <048.4ba6bc442e27acaebf43d2bf5e081813@openlayers.org> #2629: OpenLayers.Event: new transversal method addListener. ----------------------+----------------------------------------------------- Reporter: jorix | Owner: jorix Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Events | Version: SVN Resolution: wontfix | Keywords: State: | ----------------------+----------------------------------------------------- Changes (by jorix): * status: new => closed * state: Needs Discussion => * resolution: => wontfix Comment: Is a proposal of the past, I close it. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 15 13:32:48 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 15 13:32:50 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2834: Panel control: Allow to use "autoActivate" in the panel's controls. In-Reply-To: <039.f8a42743b545141aac4bf24dc4a5b8e5@openlayers.org> References: <039.f8a42743b545141aac4bf24dc4a5b8e5@openlayers.org> Message-ID: <048.d7352a5a80945080b848d7927678baa0@openlayers.org> #2834: Panel control: Allow to use "autoActivate" in the panel's controls. ----------------------------+----------------------------------------------- Reporter: jorix | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Control.Panel | Version: 2.10 Resolution: wontfix | Keywords: State: | ----------------------------+----------------------------------------------- Changes (by jorix): * status: new => closed * state: Needs More Work => * resolution: => wontfix Comment: This ticket is stopped. It is a minor feature, nobody will miss this. The ticket was one of the steps to declare the panel in a single instruction (I only posted this step). I will close. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 15 13:35:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 15 13:35:57 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2641: Control.Measure: Simultaneously measuring perimeter and area. In-Reply-To: <039.a6db3234a079def1d6b1098427eb718b@openlayers.org> References: <039.a6db3234a079def1d6b1098427eb718b@openlayers.org> Message-ID: <048.d693a36cb0feca5b2ac114ae3d287660@openlayers.org> #2641: Control.Measure: Simultaneously measuring perimeter and area. ------------------------------+--------------------------------------------- Reporter: jorix | Owner: jorix Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Control.Measure | Version: SVN Resolution: wontfix | Keywords: State: | ------------------------------+--------------------------------------------- Changes (by jorix): * status: new => closed * state: Review => * resolution: => wontfix Comment: Is a proposal of the past, I close it. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 15 13:49:16 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 15 13:49:19 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2823: ScaleLine control: Implement methods activate/deactivate. In-Reply-To: <039.73a70ed6c9046e388202ad10ac305909@openlayers.org> References: <039.73a70ed6c9046e388202ad10ac305909@openlayers.org> Message-ID: <048.180c38b09b3f82b77f4826c4f4c92ad2@openlayers.org> #2823: ScaleLine control: Implement methods activate/deactivate. --------------------------------+------------------------------------------- Reporter: jorix | Owner: tschaub Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Control.ScaleLine | Version: 2.10 RC2 Resolution: wontfix | Keywords: State: | --------------------------------+------------------------------------------- Changes (by jorix): * status: new => closed * state: Review => * resolution: => wontfix Comment: This ticket was one of the steps in the proposal relating to the controls: "only shown if it is active". I could not post it as a proposal, !OpenLayers closed part of the tickets as invalid. I close also this. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 16 17:44:26 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 16 17:44:28 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3014: Give fromArray and fromString a reverseAxisOrder option Message-ID: <042.3cb72002456b9a00e4052b1036f2b01c@openlayers.org> #3014: Give fromArray and fromString a reverseAxisOrder option ------------------------------+--------------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: BaseTypes.Bounds | Version: 2.10 Keywords: | State: ------------------------------+--------------------------------------------- We already have it for toArray. We should also add it for fromArray, because e.g. the GetCapabilities response's bbox also has a different meaning depending on the axis order. See http://getsatisfaction.com/opengeo/topics/incompatible_mapserver_wms_service I suggest to also make it a boolean argument for now. In case we need to support even bounding boxes different than bottomleft-topright, we can make it a mixed argument later. Patch attached, tests still missing. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 03:29:30 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 03:29:32 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3014: Give fromArray and fromString a reverseAxisOrder option In-Reply-To: <042.3cb72002456b9a00e4052b1036f2b01c@openlayers.org> References: <042.3cb72002456b9a00e4052b1036f2b01c@openlayers.org> Message-ID: <051.b840f53b96efb9d550186cd6053c2bd6@openlayers.org> #3014: Give fromArray and fromString a reverseAxisOrder option ------------------------------+--------------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: BaseTypes.Bounds | Version: 2.10 Keywords: | State: Review ------------------------------+--------------------------------------------- Changes (by ahocevar): * state: => Review Comment: Tests pass in Safari5. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 03:44:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 03:44:12 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server Message-ID: <046.5abecce5583324df7fcf712074313534@openlayers.org> #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server --------------------------+------------------------------------------------- Reporter: fvanderbiest | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Request | Version: SVN Keywords: | State: Needs Discussion --------------------------+------------------------------------------------- I can provide a patch to OpenLayers.Request if people find it useful. I'm currently shipping the workaround as an applicative function, taking advantage of the fact that OpenLayers.ProxyHost can be a function. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 03:44:51 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 03:44:53 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3014: Give fromArray and fromString a reverseAxisOrder option In-Reply-To: <042.3cb72002456b9a00e4052b1036f2b01c@openlayers.org> References: <042.3cb72002456b9a00e4052b1036f2b01c@openlayers.org> Message-ID: <051.005f2551fd18209c7b466feaca6e4f13@openlayers.org> #3014: Give fromArray and fromString a reverseAxisOrder option ------------------------------+--------------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: BaseTypes.Bounds | Version: 2.10 Keywords: | State: Commit ------------------------------+--------------------------------------------- Changes (by erilem): * state: Review => Commit Comment: Looking good. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 04:18:59 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 04:19:02 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3014: Give fromArray and fromString a reverseAxisOrder option In-Reply-To: <042.3cb72002456b9a00e4052b1036f2b01c@openlayers.org> References: <042.3cb72002456b9a00e4052b1036f2b01c@openlayers.org> Message-ID: <051.22f371ddf35c8c6a8d779e525be00b5d@openlayers.org> #3014: Give fromArray and fromString a reverseAxisOrder option -------------------------------+-------------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: BaseTypes.Bounds | Version: 2.10 Resolution: fixed | Keywords: State: Complete | -------------------------------+-------------------------------------------- Changes (by ahocevar): * status: new => closed * state: Commit => Complete * resolution: => fixed Comment: in w/ r11035. Thanks erilem for the review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 04:24:42 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 04:24:43 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server In-Reply-To: <046.5abecce5583324df7fcf712074313534@openlayers.org> References: <046.5abecce5583324df7fcf712074313534@openlayers.org> Message-ID: <055.fd92619cbc310bfa50da692b083e70d2@openlayers.org> #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server --------------------------+------------------------------------------------- Reporter: fvanderbiest | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Request | Version: SVN Keywords: | State: Needs Discussion --------------------------+------------------------------------------------- Comment(by ahocevar): I ran into the same issue today, so a patch would definitely be appreciated. And yes, you can count on me for the review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 05:35:35 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 05:35:37 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" In-Reply-To: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> References: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> Message-ID: <051.8c009637baea05ce5cd6ee46eb13d8f0@openlayers.org> #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" ----------------------+----------------------------------------------------- Reporter: hsivonen | Owner: Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ----------------------+----------------------------------------------------- Comment(by aabt): Works for me. I'd be happy to see this patch reviewed & commited? :) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 05:45:10 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 05:45:13 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server In-Reply-To: <046.5abecce5583324df7fcf712074313534@openlayers.org> References: <046.5abecce5583324df7fcf712074313534@openlayers.org> Message-ID: <055.4cc71310aaee2f0c47e5ab02bfff2eaa@openlayers.org> #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server --------------------------+------------------------------------------------- Reporter: fvanderbiest | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Request | Version: SVN Keywords: | State: Review --------------------------+------------------------------------------------- Changes (by fvanderbiest): * state: Needs Discussion => Review Comment: Here's the patch. Tests pass with FF3.5, Chromium 9 & IE8. Thanks for the review Andreas. As a side effect, I hope this will help reduce the number of emails on the mailing list regarding same origin policy ;-) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 09:29:30 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 09:29:32 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" In-Reply-To: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> References: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> Message-ID: <051.62dcc7b0f898041377a5aaabdcd6f343@openlayers.org> #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" ----------------------+----------------------------------------------------- Reporter: hsivonen | Owner: Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Commit ----------------------+----------------------------------------------------- Changes (by pgiraud): * state: Review => Commit Comment: This patch lookks good to me too. I think we can commit it now. Tested on FF3.6, FF4, Chrome 9, and IE8. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 09:39:57 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 09:39:59 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" In-Reply-To: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> References: <042.88bce0a9a6b1513d994519d3614356c6@openlayers.org> Message-ID: <051.b3f131cc5cde3aeeb2a76416a31d5546@openlayers.org> #2933: OpenLayers runs HTML5-incompatible script loading code if the UA string doesn't contain "Safari" or "MSIE" -----------------------+---------------------------------------------------- Reporter: hsivonen | Owner: Type: bug | Status: closed Priority: critical | Milestone: 2.11 Release Component: general | Version: 2.10 Resolution: fixed | Keywords: State: Commit | -----------------------+---------------------------------------------------- Changes (by erilem): * status: new => closed * resolution: => fixed Comment: Fixed with [11036] (and [11037]). -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 19:09:31 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 19:09:34 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server In-Reply-To: <046.5abecce5583324df7fcf712074313534@openlayers.org> References: <046.5abecce5583324df7fcf712074313534@openlayers.org> Message-ID: <055.9aad20ef70ca92f10f6514239da34647@openlayers.org> #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server --------------------------+------------------------------------------------- Reporter: fvanderbiest | Owner: tschaub Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Request | Version: SVN Keywords: | State: Review --------------------------+------------------------------------------------- Comment(by ahocevar): Thanks @fvanderbiest for the patch. This is a great improvement. I am attaching a new patch with two minor changes: * do not use Util::getUrlObject, which is quite expensive, but use a regular expression instead * add an argument to the i18n warning -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 17 19:14:19 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 17 19:14:22 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server In-Reply-To: <046.5abecce5583324df7fcf712074313534@openlayers.org> References: <046.5abecce5583324df7fcf712074313534@openlayers.org> Message-ID: <055.150ec166ffa0549cc7d270789a60479a@openlayers.org> #3015: OpenLayers uses OpenLayers.ProxyHost when requesting on the same server ---------------------------+------------------------------------------------ Reporter: fvanderbiest | Owner: tschaub Type: bug | Status: closed Priority: minor | Milestone: 2.11 Release Component: Request | Version: SVN Resolution: fixed | Keywords: State: Complete | ---------------------------+------------------------------------------------ Changes (by ahocevar): * status: new => closed * state: Review => Complete * resolution: => fixed Comment: in w/ r11038 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 18 09:34:57 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 18 09:34:59 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3016: ModifyFeature - "del" key press outside feature should delete it Message-ID: <039.b52a3d8354d25c331f91c387f6756536@openlayers.org> #3016: ModifyFeature - "del" key press outside feature should delete it -----------------------------------+---------------------------------------- Reporter: adube | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Keywords: del, delete, key | State: -----------------------------------+---------------------------------------- '''New functionality''' Being able to delete the currently selected feature with the ModifyFeature control on "del" key press when the mouse is not over a vertice. '''Current behavior''' While a feature is selected, when the "del" key is pressed when hovering a vertice, it deletes it. When done while hovering anything else, it does nothing. '''Proposed change''' While a feature is selected, pressing the "del" key while not hovering a vertice should delete the whole feature. It would triggers new "beforefeaturedeleted" and "featuredeleted" events when doing so in order for users to be able to display custom confirmation messages before doing so (done on "beforefeaturedeleted" event). The default behavior would be to delete the feature if no event is registered. If the feature has a fid, it would be put to "Delete" state, else it would simply be removed and destroyed from the layer. '''Changes to API, side effects...''' No backward incompatibility changes to the API, but that new feature clearly changes the behavior of the control. If we don't want to break the original behavior, we could have a flag option to enable/disable that new feature that would be 'false' by default. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 18 09:37:55 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 18 09:37:57 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3016: ModifyFeature - "del" key press outside vertice should delete the feature (was: ModifyFeature - "del" key press outside feature should delete it) In-Reply-To: <039.b52a3d8354d25c331f91c387f6756536@openlayers.org> References: <039.b52a3d8354d25c331f91c387f6756536@openlayers.org> Message-ID: <048.c85f93d1a4d7974c32b3fa9e856d85bd@openlayers.org> #3016: ModifyFeature - "del" key press outside vertice should delete the feature -----------------------------------+---------------------------------------- Reporter: adube | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Keywords: del, delete, key | State: -----------------------------------+---------------------------------------- -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 18 12:54:00 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 18 12:54:02 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3017: add vertexremoved event Message-ID: <042.16eb744ad9315a33b8a42211aca0957b@openlayers.org> #3017: add vertexremoved event -----------------------------------+---------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Keywords: | State: -----------------------------------+---------------------------------------- Deleting vertices currently only triggers the featuremodified event. If applications want to know when a vertex was removed, it would be convenient to have a vertexremoved event. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 18 12:55:18 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 18 12:55:20 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3017: add vertexremoved event In-Reply-To: <042.16eb744ad9315a33b8a42211aca0957b@openlayers.org> References: <042.16eb744ad9315a33b8a42211aca0957b@openlayers.org> Message-ID: <051.f95365851715b8cb115dc9a9ec64df1b@openlayers.org> #3017: add vertexremoved event -----------------------------------+---------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Keywords: | State: Review -----------------------------------+---------------------------------------- Changes (by ahocevar): * state: => Review Comment: Patch with tests. The vertexremoved event has the same properties in its argument as the vertexmodified event. Tests pass in Safari5. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 18 13:46:56 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 18 13:46:58 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3017: add vertexremoved event In-Reply-To: <042.16eb744ad9315a33b8a42211aca0957b@openlayers.org> References: <042.16eb744ad9315a33b8a42211aca0957b@openlayers.org> Message-ID: <051.54d1e0b7ff7cfc366f5bec31df0a1604@openlayers.org> #3017: add vertexremoved event -----------------------------------+---------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Keywords: | State: Commit -----------------------------------+---------------------------------------- Changes (by bartvde): * state: Review => Commit Comment: Looks good to me Andreas, Control.ModifyFeature and Layer.Vector tests also pass in FF 3.6 and IE8. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 19 06:59:10 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 19 06:59:12 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2984: Popup appears automatically when using Google Maps API v3 In-Reply-To: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> References: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> Message-ID: <052.4368381e46fa59e5f3666213b8ae9e00@openlayers.org> #2984: Popup appears automatically when using Google Maps API v3 ------------------------------+--------------------------------------------- Reporter: vladimirc | Owner: euzuro Type: bug | Status: reopened Priority: major | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Resolution: | Keywords: google api v3, popup State: Commit | ------------------------------+--------------------------------------------- Changes (by bartvde): * state: Review => Commit Comment: Your patch looks good to me Andreas, please commit. Google V3 Layer tests also pass on IE8 and Firefox 3.6. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 19 07:02:04 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 19 07:02:05 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2984: Popup appears automatically when using Google Maps API v3 In-Reply-To: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> References: <043.757a697eaf83990d9bdbd95c64b62aff@openlayers.org> Message-ID: <052.c513334e5e26ac96db58569f54227217@openlayers.org> #2984: Popup appears automatically when using Google Maps API v3 ------------------------------+--------------------------------------------- Reporter: vladimirc | Owner: euzuro Type: bug | Status: closed Priority: major | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Resolution: fixed | Keywords: google api v3, popup State: Complete | ------------------------------+--------------------------------------------- Changes (by ahocevar): * status: reopened => closed * state: Commit => Complete * resolution: => fixed Comment: Thanks @bartvde for the review. In w/ r11042. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 19 09:05:10 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 19 09:05:12 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3018: Webkit clients request WMS twice Message-ID: <037.645260cee4791de74bd58d4ba0c4baf2@openlayers.org> #3018: Webkit clients request WMS twice ---------------------+------------------------------------------------------ Reporter: olt | Owner: Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: ---------------------+------------------------------------------------------ The WMS single tile example for 2.10 or trunk does not work properly in Webkit clients. OpenLayers issues each requests twice when moving or zooming. http://openlayers.org/dev/examples/notile.html and http://dev.openlayers.org/releases/OpenLayers-2.10/examples/notile.html The 2.9 example works fine. Tested in Safari 5.0.3 and Chrome 8.0.552.231 on Mac OS X 10.6.6. It does work with Firefox 3.6.13. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 19 11:10:45 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 19 11:10:47 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2983: layer should have "added" event In-Reply-To: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> References: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> Message-ID: <050.7296c771f03a9f05e1494b12fbd2f447@openlayers.org> #2983: layer should have "added" event ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Changes (by mpriour): * cc: mpriour (added) * state: => Review Comment: Added a patch which creates and fires these events. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 19 11:45:10 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 19 11:45:11 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3017: add vertexremoved event In-Reply-To: <042.16eb744ad9315a33b8a42211aca0957b@openlayers.org> References: <042.16eb744ad9315a33b8a42211aca0957b@openlayers.org> Message-ID: <051.70b28d8032e2c348c1213b6836cffbe2@openlayers.org> #3017: add vertexremoved event ------------------------------------+--------------------------------------- Reporter: ahocevar | Owner: tschaub Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Resolution: fixed | Keywords: State: Complete | ------------------------------------+--------------------------------------- Changes (by ahocevar): * status: new => closed * state: Commit => Complete * resolution: => fixed Comment: in w/ r11043 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 06:51:06 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 06:51:08 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2983: layer should have "added" event In-Reply-To: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> References: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> Message-ID: <050.45f4a791229dd949e87e57e3944e201b@openlayers.org> #2983: layer should have "added" event ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: | State: Needs More Work ---------------------+------------------------------------------------------ Changes (by ahocevar): * state: Review => Needs More Work Comment: Thanks a lot for the patch @mpriour. This is almost good go commit, I'd just prefer if the added event was triggered before calling the layer's afterAdd method. And it would be great if you could add a simple unit test which just shows that the new events are actually triggered. Another goodie would be to remove the added event from Layer.Bing, but I can also do that if you don't get to it. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 07:55:13 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 07:55:14 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3019: WMS GetFeatureInfo is now using float values for X and Y Message-ID: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> #3019: WMS GetFeatureInfo is now using float values for X and Y ---------------------------------------+------------------------------------ Reporter: bartvde | Owner: Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: Control.WMSGetFeatureInfo | Version: SVN Keywords: | State: ---------------------------------------+------------------------------------ This breaks GeoServer e.g. since X and Y need to be integers. It can easily be checked with the getfeatureinfo-control.html example in trunk. http://demo.opengeo.org/geoserver/wms?SERVICE=WMS&VERSION=1.1.1&REQUEST=GetFeatureInfo&LAYERS=topp%3Atasmania_water_bodies&QUERY_LAYERS=topp%3Atasmania_water_bodies&STYLES=&BBOX=140.5315%2C-44.423%2C151.7815%2C-38.798&FEATURE_COUNT=10&HEIGHT=256&WIDTH=512&FORMAT=image%2Fgif&INFO_FORMAT=text%2Fhtml&SRS=EPSG%3A4326&X=284.6999969482422&Y=139.26666259765625 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:05:51 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:05:53 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3019: WMS GetFeatureInfo is now using float values for X and Y In-Reply-To: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> References: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> Message-ID: <050.8c96ba0c11a45799b669f22787be36fd@openlayers.org> #3019: WMS GetFeatureInfo is now using float values for X and Y ---------------------------------------+------------------------------------ Reporter: bartvde | Owner: Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: Control.WMSGetFeatureInfo | Version: SVN Keywords: | State: Review ---------------------------------------+------------------------------------ Changes (by bartvde): * state: => Review Comment: Control WMSGetFeatureInfo tests pass in FF 3.6, thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:08:06 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:08:08 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3020: option to disable animate zooming Message-ID: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> #3020: option to disable animate zooming -----------------------------+---------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Keywords: | State: Review -----------------------------+---------------------------------------------- The GMaps v3 API does not support it, but we can do it by making the layer temporarily invisible. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:14:09 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:14:11 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3020: option to disable animate zooming In-Reply-To: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> References: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> Message-ID: <051.93c8f0b7452f030f9eb46492854c80cc@openlayers.org> #3020: option to disable animate zooming -----------------------------+---------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Keywords: | State: Review -----------------------------+---------------------------------------------- Comment(by bartvde): Andreas, looks good, would it not make more sense in the example when switching base layers to apply the current setting to the base layer selected? I find it a bit strange that when I change the baselayer that my "application" option for Animated zoom changes. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:15:33 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:15:34 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3019: WMS GetFeatureInfo is now using float values for X and Y In-Reply-To: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> References: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> Message-ID: <050.8a1d274002295cbfe2186c909326f1e6@openlayers.org> #3019: WMS GetFeatureInfo is now using float values for X and Y ---------------------------------------+------------------------------------ Reporter: bartvde | Owner: Type: bug | Status: new Priority: critical | Milestone: 2.11 Release Component: Control.WMSGetFeatureInfo | Version: SVN Keywords: | State: Commit ---------------------------------------+------------------------------------ Changes (by ahocevar): * state: Review => Commit Comment: Looks good. Please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:18:14 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:18:15 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3020: option to disable animate zooming In-Reply-To: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> References: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> Message-ID: <051.79b07f3cf5350081bcab3d4fbd4ec5da@openlayers.org> #3020: option to disable animate zooming -----------------------------+---------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Keywords: | State: Review -----------------------------+---------------------------------------------- Comment(by bartvde): Another thing that comes to my mind, would it not make more sense to use transitionEffect as the option name? With a default of resize? That way it is closer to what OL currently uses. Setting it to null would remove the transitionEffect. What do you think? -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:20:49 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:20:52 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3019: WMS GetFeatureInfo is now using float values for X and Y In-Reply-To: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> References: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> Message-ID: <050.fc867a1c8b63d8fda4ba68d3edd3145d@openlayers.org> #3019: WMS GetFeatureInfo is now using float values for X and Y ----------------------------------------+----------------------------------- Reporter: bartvde | Owner: Type: bug | Status: closed Priority: critical | Milestone: 2.11 Release Component: Control.WMSGetFeatureInfo | Version: SVN Resolution: fixed | Keywords: State: Commit | ----------------------------------------+----------------------------------- Changes (by bartvde): * status: new => closed * resolution: => fixed Comment: in with r11046 thanks ahocevar for the review -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:21:15 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:21:17 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3019: WMS GetFeatureInfo is now using float values for X and Y In-Reply-To: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> References: <041.cf19b591ef4fcfb1500b0dd58fc3e9dd@openlayers.org> Message-ID: <050.6dd705c6ff3137a2c7a3a40c8fad41cc@openlayers.org> #3019: WMS GetFeatureInfo is now using float values for X and Y ----------------------------------------+----------------------------------- Reporter: bartvde | Owner: Type: bug | Status: closed Priority: critical | Milestone: 2.11 Release Component: Control.WMSGetFeatureInfo | Version: SVN Resolution: fixed | Keywords: State: Complete | ----------------------------------------+----------------------------------- Changes (by bartvde): * state: Commit => Complete -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:27:24 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:27:26 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3020: option to disable animate zooming In-Reply-To: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> References: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> Message-ID: <051.d5586f640fa4f1b2bb76548f1de883af@openlayers.org> #3020: option to disable animate zooming -----------------------------+---------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Keywords: | State: Review -----------------------------+---------------------------------------------- Comment(by ahocevar): I only changed the example, because the same option is also called animationEnabled in Layer.VirtualEarth. And transitionEffect, in my opinion, is something that OpenLayers does, not an external API. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:29:40 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:29:42 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3020: option to disable animate zooming In-Reply-To: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> References: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> Message-ID: <051.957817b424253e46182936c100b54416@openlayers.org> #3020: option to disable animate zooming -----------------------------+---------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Keywords: | State: Commit -----------------------------+---------------------------------------------- Changes (by bartvde): * state: Review => Commit Comment: Thanks for the feedback, I agree, please commit. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 08:31:53 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 08:31:55 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3020: option to disable animate zooming In-Reply-To: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> References: <042.4f51dd0e81cfc0aaa48a41ba810cbc69@openlayers.org> Message-ID: <051.9529f4b205c9e6d2590d4807576bd1b1@openlayers.org> #3020: option to disable animate zooming -----------------------------+---------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Google.v3 | Version: 2.10 Keywords: | State: Commit -----------------------------+---------------------------------------------- Comment(by ahocevar): Thanks @bartvde for the comments and review. In w/ r11047 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 09:07:16 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 09:07:18 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3021: Add POST (XML data) parameters support to SOS Capabilities Message-ID: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> #3021: Add POST (XML data) parameters support to SOS Capabilities --------------------------------------------------------+------------------- Reporter: sonxurxo | Owner: bartvde Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.OWSCommon | Version: 2.10 Keywords: SOS, GetCapabilities, XML parameters, POST | State: Review --------------------------------------------------------+------------------- Currently OL only supports sending SOS GetCapabilites parameters in KVP mode, in the query string. In practice, some servers only accept parameters in XML by POST. We'll need to add a write function to Format/SOSCapabilities.js that delegates in the also needed write function in Format/SOSCapabilities/v1_0_0.js, and add some writers in Format/OWSCommon/v1.js. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 09:12:01 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 09:12:03 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3021: Add POST (XML data) parameters support to SOS Capabilities In-Reply-To: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> References: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> Message-ID: <051.44b2eb33404f1a790868a9631daa91d5@openlayers.org> #3021: Add POST (XML data) parameters support to SOS Capabilities --------------------------------------------------------+------------------- Reporter: sonxurxo | Owner: bartvde Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.OWSCommon | Version: 2.10 Keywords: SOS, GetCapabilities, XML parameters, POST | State: Review --------------------------------------------------------+------------------- Comment(by sonxurxo): I forgot to say, tests passed in Firefox 3.6.8 and Google Chrome 5.0.375.127. There is an example html, examples/sosPOST.html (clone of examples/sos.html) that shows how this works. IMPORTANT: Please check the '''write''' function added to Format/SOSCapabilities.js. I wanted to delegate in the specified version (now only Format/SOSCapabilities/v1_0_0.js) function, I'm not sure if this is the right way to do that. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 10:18:40 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 10:18:41 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.fc49dcc07ef7734c34f5746e528b2b48@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: ---------------------+------------------------------------------------------ Comment(by dwinslow): I've attached a patch which provides parsing/encoding for a subset of CQL syntax. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 11:27:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 11:27:56 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.803affb4f8a39fdd3b7cf56ce256f595@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: ---------------------+------------------------------------------------------ Comment(by erilem): Replying to [comment:1 dwinslow]: > I've attached a patch which provides parsing/encoding for a subset of CQL syntax. Missing files in the patch (I hope). -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 11:31:28 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 11:31:30 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.2e8f99bc089268d1144fa337a4199a84@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: ---------------------+------------------------------------------------------ Comment(by dwinslow): Replying to [comment:2 erilem]: > Replying to [comment:1 dwinslow]: > > I've attached a patch which provides parsing/encoding for a subset of CQL syntax. > > Missing files in the patch (I hope). Oops, sorry about that. Attaching a better patch shortly. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 20 12:32:17 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 20 12:32:19 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3022: GeoJSON format output produces invalid CRS Message-ID: <042.689a377aca41cc25b50abe05e3bc87b4@openlayers.org> #3022: GeoJSON format output produces invalid CRS ----------------------------+----------------------------------------------- Reporter: hoxworth | Owner: hoxworth@? Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.GeoJSON | Version: SVN Keywords: geojson | State: ----------------------------+----------------------------------------------- '''Description''': The GeoJSON format writer creates a coordinate reference system object that does not conform to the GeoJSON [http://geojson.org/geojson-spec.html#coordinate-reference-system-objects spec]. '''Reproduction''': Call 'OpenLayers.Format.GeoJSON().write(feature)' on any feature. '''Location''': [source:/trunk/openlayers/lib/OpenLayers/Format/GeoJSON.js#L494 Source] '''Expected''': A GeoJSON object should be created with a 'crs' property that conforms to the GeoJSON [http://geojson.org/geojson-spec.html #coordinate-reference-system-objects spec]. An example follows: {{{ "crs": { "type" : "name", "properties" : { "name" : "urn:ogc:def:crs:OGC:1.3:CRS84" } } }}} '''Actual Experience''': A GeoJSON object is created with a 'crs' property of the following format: {{{ "crs" : { "type" : "OGC", "properties" : { "urn" : "urn:ogc:def:crs:OGC:1.3:CRS84" } } }}} '''Impact''': Minimal. This bug affects all browsers/runtimes, but only impacts users who depend on GeoJSON output for connection with external systems. '''Solution''': Patch is attached. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 03:42:49 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 03:42:51 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3023: Wrong information in library.cfg Message-ID: <038.805c6dfbc272925916ddf01f23e154ae@openlayers.org> #3023: Wrong information in library.cfg ---------------------------+------------------------------------------------ Reporter: rodo | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: examples | Version: 2.10 Keywords: build library | State: ---------------------------+------------------------------------------------ in source:trunk/openlayers/build/library.cfg it is indicated that this file is used by default by source:trunk/openlayers/build/build.py, this is wrong. It's the full.cfg file that is used if no one is indicated on the command line -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 08:25:41 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 08:25:43 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2995: make drag handler work with touch events In-Reply-To: <040.3cda968b7a5671d003547788e481f4b2@openlayers.org> References: <040.3cda968b7a5671d003547788e481f4b2@openlayers.org> Message-ID: <049.41fcbe5a3540a8604d51e77bb6a9534f@openlayers.org> #2995: make drag handler work with touch events --------------------------+------------------------------------------------- Reporter: erilem | Owner: Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: --------------------------+------------------------------------------------- Changes (by sbrunner): * cc: courriel@? (added) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 08:25:46 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 08:25:48 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2996: make click handler work with touch events In-Reply-To: <040.e94f1608ef0cfc5ab6ed5cce94d21601@openlayers.org> References: <040.e94f1608ef0cfc5ab6ed5cce94d21601@openlayers.org> Message-ID: <049.ace4ff9bf66b0115c7aad9aee97cac50@openlayers.org> #2996: make click handler work with touch events ---------------------------+------------------------------------------------ Reporter: erilem | Owner: tschaub Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: Handler.Click | Version: 2.10 Keywords: | State: ---------------------------+------------------------------------------------ Changes (by sbrunner): * cc: courriel@? (added) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 08:25:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 08:25:56 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2998: delay (time consuming) grid tiles move In-Reply-To: <041.cd2d6db8d97404031cfc3feaf00e6601@openlayers.org> References: <041.cd2d6db8d97404031cfc3feaf00e6601@openlayers.org> Message-ID: <050.b373bb4530cb49624d8d14254a6472a8@openlayers.org> #2998: delay (time consuming) grid tiles move ------------------------+--------------------------------------------------- Reporter: pgiraud | Owner: elemoine Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer.Grid | Version: 2.10 Keywords: | State: Needs More Work ------------------------+--------------------------------------------------- Changes (by sbrunner): * cc: courriel@? (added) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 08:25:57 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 08:25:59 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2999: kinetic dragging support In-Reply-To: <040.57bde431b9bc4d20d0045e883f8fadd7@openlayers.org> References: <040.57bde431b9bc4d20d0045e883f8fadd7@openlayers.org> Message-ID: <049.b53732ad2c7fbe0c08447f62bac7e77f@openlayers.org> #2999: kinetic dragging support -----------------------------+---------------------------------------------- Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.DragPan | Version: 2.10 Keywords: | State: -----------------------------+---------------------------------------------- Changes (by sbrunner): * cc: courriel@? (added) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 08:26:37 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 08:26:38 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. In-Reply-To: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> References: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> Message-ID: <048.12984c207b19e3b4ad6c8de5275d95c8@openlayers.org> #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. --------------------------+------------------------------------------------- Reporter: jorix | Owner: erilem Type: bug | Status: new Priority: blocker | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: Review --------------------------+------------------------------------------------- Changes (by sbrunner): * cc: courriel@? (added) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 08:26:49 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 08:26:51 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3000: mobile development In-Reply-To: <040.b94cb1b265ace7fa1f73ee6b9d395ed0@openlayers.org> References: <040.b94cb1b265ace7fa1f73ee6b9d395ed0@openlayers.org> Message-ID: <049.83b5f514f99998cbedce1bb3114e8139@openlayers.org> #3000: mobile development ---------------------+------------------------------------------------------ Reporter: erilem | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: ---------------------+------------------------------------------------------ Changes (by sbrunner): * cc: courriel@? (added) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 09:24:48 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 09:24:51 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3008: Build: Integrate Closure Compiler on OpenLayers In-Reply-To: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> References: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> Message-ID: <048.372c457d4da9a2f5aa21066bf4790969@openlayers.org> #3008: Build: Integrate Closure Compiler on OpenLayers ---------------------+------------------------------------------------------ Reporter: jorix | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by avlee): This is a good way to check documents in codes. But for library, it's hard to build using closure compiler with "ADVANCED_OPTIMIZATIONS" flag, may be we can try to build with "ADVANCED_OPTIMIZATIONS" flag with some extern files that auto generated depend on the "APIMethod" and "APIProperty" tag. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 10:28:43 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 10:28:45 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3008: Build: Integrate Closure Compiler on OpenLayers In-Reply-To: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> References: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> Message-ID: <048.a4f2745431a57c3f289b4712200e3654@openlayers.org> #3008: Build: Integrate Closure Compiler on OpenLayers ---------------------+------------------------------------------------------ Reporter: jorix | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by jorix): Replying to [comment:4 avlee]: > This is a good way to check documents in codes. But for library, it's hard to build using closure compiler with "ADVANCED_OPTIMIZATIONS" flag... This ticket is '''designed to use SIMPLE_OPTIMIZATIONS''' (but it allows testing to advanced optimizations, to work with it not serve the externs, it needs many changes to the code, see: [http://code.google.com/intl/ca/closure/compiler/docs/api- tutorial3.html#no Do Not Use Externs Instead of Exports!], but this is not the place to talk about it) SIMPLE_OPTIMIZATIONS is directly applicable in 2.11, is safe and has good compression ratio of 20%. "'''Solve massive warnings highlights what should be revised'''": This has been my main line of work done with Closure Compiler for !OpenLayers. This ticket (by default) hides massive warnings, and force some errors like undefined variables. This gives useful information when it checks the source code, see #2960, #2971, #2976, #3001 and #2989. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 21 12:20:26 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 21 12:20:28 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3008: Build: Integrate Closure Compiler on OpenLayers In-Reply-To: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> References: <039.31a0f826c4d898a9203e97958f606cc2@openlayers.org> Message-ID: <048.da3c9dcec4c617d58150959a2e22daae@openlayers.org> #3008: Build: Integrate Closure Compiler on OpenLayers ---------------------+------------------------------------------------------ Reporter: jorix | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by jorix): Replying to [comment:5 jorix]: Oops! > ...(but it allows testing to advanced optimizations, to work with it not serve the externs,... ...(but it allows testing advanced optimizations, externs are not the right tool to work with advanced optimization,... > ...good compression ratio of 20%. ...good compression ratio 20% more than jsmin. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 22 06:42:26 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 22 06:42:28 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2983: layer should have "added" event In-Reply-To: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> References: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> Message-ID: <050.e5f13dc5174b097c6e27564cb9a0e087@openlayers.org> #2983: layer should have "added" event ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: | State: Needs More Work ---------------------+------------------------------------------------------ Comment(by ahocevar): @mpriour: nevermind - I'm working on the patch now, so it should be ready to commit in a few minutes. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 22 07:03:57 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 22 07:03:59 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2983: layer should have "added" event In-Reply-To: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> References: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> Message-ID: <050.dfa700b8793f05a475511f15227cba56@openlayers.org> #2983: layer should have "added" event ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: | State: Commit ---------------------+------------------------------------------------------ Changes (by ahocevar): * state: Needs More Work => Commit Comment: Thanks again @mpriour for the patch. Tests added by me, all relevant tests pass. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 22 07:05:00 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 22 07:05:01 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2983: layer should have "added" event In-Reply-To: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> References: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> Message-ID: <050.a82a8b440036c6a4b151b21e46b92238@openlayers.org> #2983: layer should have "added" event ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: | State: Commit ---------------------+------------------------------------------------------ Comment(by ahocevar): in w/ r11052 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 22 07:05:23 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 22 07:05:25 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2983: layer should have "added" and "removed" event (was: layer should have "added" event) In-Reply-To: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> References: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> Message-ID: <050.ebaff088353972212414c7ebb7579204@openlayers.org> #2983: layer should have "added" and "removed" event -----------------------+---------------------------------------------------- Reporter: tschaub | Owner: euzuro Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Resolution: fixed | Keywords: State: Complete | -----------------------+---------------------------------------------------- Changes (by ahocevar): * status: new => closed * state: Commit => Complete * resolution: => fixed -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 22 22:28:31 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 22 22:28:34 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2983: layer should have "added" and "removed" event In-Reply-To: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> References: <041.d7a2d79381e10ae57c46e1efc17b95e8@openlayers.org> Message-ID: <050.365ab6125e9688e11e61310be1626523@openlayers.org> #2983: layer should have "added" and "removed" event -----------------------+---------------------------------------------------- Reporter: tschaub | Owner: euzuro Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Resolution: fixed | Keywords: State: Complete | -----------------------+---------------------------------------------------- Comment(by mpriour): Looks great thanks @ahocevar. I'm checking out the related patch in GeoExt[1] 1. [http://trac.geoext.org/ticket/396] -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 09:36:00 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 09:36:02 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. In-Reply-To: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> References: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> Message-ID: <048.8527452c24362885f7efd7330b3d4092@openlayers.org> #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. --------------------------+------------------------------------------------- Reporter: jorix | Owner: erilem Type: bug | Status: new Priority: blocker | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: Review --------------------------+------------------------------------------------- Comment(by erilem): The issue can be easily reproduced on http://www.openlayers.org/dev/examples/fullScreen.html: move the map w/o immediately releasing the mouse after moving, you'll see "jumps" on mouseup. And actually the jump somehow makes sense, as it positions the map under the mouse at the same place where the mousedown occurred. We get this jump effect when {{{interval}}} is non-zero, i.e. when we purposefully miss mousemove events. [attachment:patch-2936-A0.diff] fixes the "jump on mouseup" issue. With the patch the jump occurs earlier, when the "delayed drag" timeout expires. So the patch does improve things in my opinion - better user experience. Tests continue to pass. @jorix, my patch is just a subset of yours. Small patches with restricted focuses are much easier to review. Tell me if you think some of your tests could be added to my patch. Thanks for reporting the issue and the patch. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 09:38:58 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 09:38:59 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3023: Wrong information in library.cfg In-Reply-To: <038.805c6dfbc272925916ddf01f23e154ae@openlayers.org> References: <038.805c6dfbc272925916ddf01f23e154ae@openlayers.org> Message-ID: <047.a80b111feb8c737c52c94a55748b013f@openlayers.org> #3023: Wrong information in library.cfg -----------------------+---------------------------------------------------- Reporter: rodo | Owner: Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: examples | Version: 2.10 Resolution: fixed | Keywords: build library State: | -----------------------+---------------------------------------------------- Changes (by erilem): * status: new => closed * resolution: => fixed Comment: closed with r11053. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 12:25:01 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 12:25:03 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. In-Reply-To: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> References: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> Message-ID: <048.bf335eaee8ab381e5af9ece3be21e160@openlayers.org> #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. --------------------------+------------------------------------------------- Reporter: jorix | Owner: erilem Type: bug | Status: new Priority: blocker | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: Review --------------------------+------------------------------------------------- Comment(by jorix): Replying to [comment:5 erilem]: > [attachment:patch-2936-A0.diff] fixes the "jump on mouseup" issue. With the patch the jump occurs earlier, when the "delayed drag" timeout expires. So the patch does improve things in my opinion - better user experience. Perfect! I watched the patch: {{{this.lastMoveEvt = evt;}}} at the beginning of the method is very effective. (I put inside, so my code is more complicated :-() Question: Can be omitted to assign {{{this.delayedEvt = null;}}} at the end of drag? > Small patches with restricted focuses are much easier to review. Yes, I know. I did not see the two bugs could be independent. I worried about leaving active {{{setTimeout}}} so I looked at the completions of the drag. > Tell me if you think some of your tests could be added to my patch. Thanks for reporting the issue and the patch. The tests are designed to testing thoroughly proper completion of drag. In a new ticket? [[BR]] Only a very small affect the behavior of your patch, but to add them should dismantle the structure of the tests. I prefer not to touch the structure of the tests. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 15:24:39 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 15:24:41 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2938: [patch] Comparason type like with null (property not present) In-Reply-To: <042.15bbeb11c6cfe5812adc42778701dad4@openlayers.org> References: <042.15bbeb11c6cfe5812adc42778701dad4@openlayers.org> Message-ID: <051.0b5f9bcda0c68e525d32b6607c3e9500@openlayers.org> #2938: [patch] Comparason type like with null (property not present) -------------------------------+-------------------------------------------- Reporter: sbrunner | Owner: ahocevar Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Filter.Comparison | Version: 2.10 Keywords: patch | State: -------------------------------+-------------------------------------------- Comment(by erilem): St?phane, what do think about [attachment:Comparison.patch]? -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 15:31:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 15:31:56 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3022: GeoJSON format output produces invalid CRS In-Reply-To: <042.689a377aca41cc25b50abe05e3bc87b4@openlayers.org> References: <042.689a377aca41cc25b50abe05e3bc87b4@openlayers.org> Message-ID: <051.1c9276ec9ac304b21c5d69a066821aaa@openlayers.org> #3022: GeoJSON format output produces invalid CRS ----------------------------+----------------------------------------------- Reporter: hoxworth | Owner: hoxworth@? Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.GeoJSON | Version: SVN Keywords: geojson | State: Commit ----------------------------+----------------------------------------------- Changes (by erilem): * state: => Commit Comment: It looks good to me. hoxworth, do we have a CLA from you? -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 16:58:02 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 16:58:04 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. In-Reply-To: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> References: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> Message-ID: <048.1b7746fea48da60b147de5c60fbe92fc@openlayers.org> #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. --------------------------+------------------------------------------------- Reporter: jorix | Owner: erilem Type: bug | Status: new Priority: blocker | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: Review --------------------------+------------------------------------------------- Comment(by erilem): [attachment:patch-2936-A1.diff] comes with tests, and addresses the case where a new mousedown occurs before the timer triggers. @jorix, * I don't see any problem with not setting {{{lastMoveEvt}}} to {{{null}}} after drag. Could you please provide a test case if you see one? * With this patch leaving an active timer shouldn't cause any issue, because of the {{{if(this.dragging)}}} guard. Again, please provide a test case if you see an issue. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 17:40:14 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 17:40:16 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3024: New restrictedMinZoom property, like restricedExtent Message-ID: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> #3024: New restrictedMinZoom property, like restricedExtent ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Map | Version: 2.10 Keywords: | State: Review ----------------------+----------------------------------------------------- The existing minZoomLevel property on Layer.FixedZoomLevels is a nice way to limit the used resolutions of layers provided by third-party apis, but it changes the numbering of zoom levels. The suggested restricedMinZoom property works similar to restricedExtent - it retains the zoom level numbering, but restricts the layer from being used at low zoom levels. This is especially useful when a map is configured with {{{allOverlays: true}}}. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 17:41:23 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 17:41:25 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3024: New restrictedMinZoom property, like restrictedExtent (was: New restrictedMinZoom property, like restricedExtent) In-Reply-To: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> References: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> Message-ID: <051.5bab0fe1114af1754f90e1ec038f3c7b@openlayers.org> #3024: New restrictedMinZoom property, like restrictedExtent ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Map | Version: SVN Keywords: | State: Review ----------------------+----------------------------------------------------- Changes (by ahocevar): * version: 2.10 => SVN Comment: Patch with tests. Tests pass in Safari5. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 17:41:39 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 17:41:42 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3024: New restrictedMinZoom property, like restrictedExtent In-Reply-To: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> References: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> Message-ID: <051.1b84618218eeecd9fe1f26b9c2c0d32a@openlayers.org> #3024: New restrictedMinZoom property, like restrictedExtent ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Review ----------------------+----------------------------------------------------- Changes (by ahocevar): * owner: => euzuro * component: Map => Layer -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 17:46:46 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 17:46:48 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3025: Use restrictedMinZoom in Layer.Bing Message-ID: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> #3025: Use restrictedMinZoom in Layer.Bing ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: SVN Keywords: | State: ----------------------+----------------------------------------------------- In Layer.XYZ, we have serverResolutions and zoomOffset to only expose a subset of server resolutions to the OpenLayers client. For Layer.Bing, we need the opposite: the server resolutions don't contain all the resolutions that we have in OpenLayers, but we want to keep the zoom level numbering scheme to have the same zoom levels we have for third-party api layers. This ticket suggests using the new restricedMinZoom property (introduced with #3024) to accomplish this. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 17:53:21 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 17:53:23 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3025: Use restrictedMinZoom in Layer.Bing In-Reply-To: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> References: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> Message-ID: <051.5d52e04212ff9b634a00b0c28569654f@openlayers.org> #3025: Use restrictedMinZoom in Layer.Bing ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: SVN Keywords: | State: Review ----------------------+----------------------------------------------------- Changes (by ahocevar): * state: => Review Comment: Note that this patch also allows us to get rid of the hack we used to change the resolution in case initLayer needed to reconfigure the layer with a different maxResolution - we don't change the maxResolution any more: {{{ // adjust zoom level to match the previous resolution - this triggers a // moveTo on all layers. resolution && this.map.zoomTo(this.getZoomForResolution(resolution)); }}} With this patch applied, tests still pass in Safari5. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 17:53:34 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 17:53:36 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3025: Use restrictedMinZoom in Layer.Bing In-Reply-To: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> References: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> Message-ID: <051.800380ca54a0768efa0cb1a72360bec5@openlayers.org> #3025: Use restrictedMinZoom in Layer.Bing ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Review ----------------------+----------------------------------------------------- Changes (by ahocevar): * owner: => euzuro * component: general => Layer -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 23 17:54:50 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 23 17:54:52 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3025: Use restrictedMinZoom in Layer.Bing In-Reply-To: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> References: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> Message-ID: <051.52675677df40c6a9deb9f55d6895ed3a@openlayers.org> #3025: Use restrictedMinZoom in Layer.Bing ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Review ----------------------+----------------------------------------------------- Comment(by ahocevar): To review this patch, make sure that the patch attached to #3024 is applied first. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 05:00:47 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 05:00:49 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities Message-ID: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities ------------------------------------+--------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Keywords: WMS-C | State: ------------------------------------+--------------------------------------- If a WMS contains extra informations as proposed here (a.k.a. WMS-C): http://wiki.osgeo.org/wiki/WMS_Tile_Caching, we can take advantage of them by parsing the addition information. This has been done in GeoServer/GWC. The structure used is described as: {{{ }}} An example is: {{{ EPSG:900913 156543.03390625 78271.516953125 39135.7584765625 19567.87923828125 9783.939619140625 4891.9698095703125 2445.9849047851562 1222.9924523925781 611.4962261962891 305.74811309814453 152.87405654907226 76.43702827453613 38.218514137268066 19.109257068634033 9.554628534317017 4.777314267158508 2.388657133579254 1.194328566789627 0.5971642833948135 0.29858214169740677 0.14929107084870338 0.07464553542435169 0.037322767712175846 0.018661383856087923 0.009330691928043961 0.004665345964021981 256 256 image/png medford:hydro }}} -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 05:01:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 05:01:28 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.7eeee896d86fc8800b1c81652862f058@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities ------------------------------------+--------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Keywords: WMS-C | State: ------------------------------------+--------------------------------------- Description changed by bartvde: Old description: > If a WMS contains extra informations as proposed here (a.k.a. WMS-C): > http://wiki.osgeo.org/wiki/WMS_Tile_Caching, we can take advantage of > them by parsing the addition information. > > This has been done in GeoServer/GWC. > > The structure used is described as: > > {{{ > > Layers*, Styles*) > > > > > > > }}} > > An example is: > {{{ > > > EPSG:900913 > miny="5165920.118906248" maxx="-1.361924394984375E7" > maxy="5244191.635859374"/> > 156543.03390625 78271.516953125 39135.7584765625 > 19567.87923828125 9783.939619140625 4891.9698095703125 2445.9849047851562 > 1222.9924523925781 611.4962261962891 305.74811309814453 > 152.87405654907226 76.43702827453613 38.218514137268066 > 19.109257068634033 9.554628534317017 4.777314267158508 2.388657133579254 > 1.194328566789627 0.5971642833948135 0.29858214169740677 > 0.14929107084870338 0.07464553542435169 0.037322767712175846 > 0.018661383856087923 0.009330691928043961 0.004665345964021981 > > 256 > 256 > image/png > medford:hydro > > > }}} New description: If a WMS contains extra information as proposed here (a.k.a. WMS-C): http://wiki.osgeo.org/wiki/WMS_Tile_Caching, we can take advantage of them by parsing the additional information. This has been done in GeoServer/GWC. The structure used is described as: {{{ }}} An example is: {{{ EPSG:900913 156543.03390625 78271.516953125 39135.7584765625 19567.87923828125 9783.939619140625 4891.9698095703125 2445.9849047851562 1222.9924523925781 611.4962261962891 305.74811309814453 152.87405654907226 76.43702827453613 38.218514137268066 19.109257068634033 9.554628534317017 4.777314267158508 2.388657133579254 1.194328566789627 0.5971642833948135 0.29858214169740677 0.14929107084870338 0.07464553542435169 0.037322767712175846 0.018661383856087923 0.009330691928043961 0.004665345964021981 256 256 image/png medford:hydro }}} -- -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 05:03:55 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 05:03:57 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.916d7c7118a105d6e68eab05f74c75b0@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities ------------------------------------+--------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Keywords: WMS-C | State: ------------------------------------+--------------------------------------- Comment(by bartvde): Btw, currently this has only been done for WMS 1.1.1, in the future WMS 1.3 might be added. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 05:50:18 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 05:50:21 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3027: WMTSCapabilities.createLayer: use style identifier Message-ID: <039.d24d34eb8028baec03c95e17fe492e52@openlayers.org> #3027: WMTSCapabilities.createLayer: use style identifier -------------------------------------+-------------------------------------- Reporter: fredj | Owner: Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMTSCapabilities | Version: SVN Keywords: | State: -------------------------------------+-------------------------------------- The {{{WMTSCapabilities.createLayer}}} function correctly selects the default layer style but must initialize the WMTS layer with the style identifier, not the whole object. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 05:53:22 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 05:53:24 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3027: WMTSCapabilities.createLayer: use style identifier In-Reply-To: <039.d24d34eb8028baec03c95e17fe492e52@openlayers.org> References: <039.d24d34eb8028baec03c95e17fe492e52@openlayers.org> Message-ID: <048.99f09cc7fd6719ff6a58a857b8b42105@openlayers.org> #3027: WMTSCapabilities.createLayer: use style identifier -------------------------------------+-------------------------------------- Reporter: fredj | Owner: Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMTSCapabilities | Version: SVN Keywords: | State: Review -------------------------------------+-------------------------------------- Changes (by fredj): * state: => Review Comment: Tests pass in chrome 9. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 06:22:34 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 06:22:36 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.2fd9e229e7623c8bb1677a594d3c4f23@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities ------------------------------------+--------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Keywords: WMS-C | State: Review ------------------------------------+--------------------------------------- Changes (by bartvde): * state: => Review Comment: The new tests pass in Safari 5, FF 3.6 and IE8, thanks for any review. Also, if you think this should be an option in the constructor of WMSCapabilities instead (e.g. tiled=true or wmsc=true), let me know. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 07:08:56 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 07:08:58 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.527152c6cbdfdd182e1af42b7ae68c13@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities ------------------------------------+--------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Keywords: WMS-C | State: Commit ------------------------------------+--------------------------------------- Changes (by ahocevar): * state: Review => Commit Comment: Looks great @bartvde. I think we can introduce a more generic way to support custom profiles for our XML formats. In my patch, you would create the format instance with the {{{profile: "WMSC"}}} option of Format.WMSCapabilities. Please commit my patch if you agree. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 07:15:34 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 07:15:36 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.cfcde8709f69f2befc19df20589e21f4@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities ------------------------------------+--------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Keywords: WMS-C | State: Commit ------------------------------------+--------------------------------------- Comment(by bartvde): Good suggestion ahocevar, I will commit your version of the patch. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 07:17:30 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 07:17:32 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.84559a167aa5cb917c982027c7a64cc0@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities ------------------------------------+--------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Keywords: WMS-C | State: Commit ------------------------------------+--------------------------------------- Comment(by bartvde): This way we can also easily create an INSPIRE profile. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 07:21:52 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 07:21:54 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.756c6cdb54df93fbd9574757a70623d7@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities -------------------------------------+-------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Resolution: fixed | Keywords: WMS-C State: Complete | -------------------------------------+-------------------------------------- Changes (by bartvde): * status: new => closed * state: Commit => Complete * resolution: => fixed Comment: In w/ r11056 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 07:28:01 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 07:28:03 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3025: Use restrictedMinZoom in Layer.Bing In-Reply-To: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> References: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> Message-ID: <051.ddfe428bd03181663a52bc546232c9be@openlayers.org> #3025: Use restrictedMinZoom in Layer.Bing ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Review ----------------------+----------------------------------------------------- Comment(by flavour): Thanks ahocevar - these 2 patches fixed the weird behaviour I was seeing with Bing interoperating with OSM/Google layers...haven't seen any new oddnesses...all smooth now :) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 07:44:18 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 07:44:20 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3026: Add OpenLayers.Format.WMSCCapabilities In-Reply-To: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> References: <041.61c7ca0f1abdc1b1c0f2501e05b83799@openlayers.org> Message-ID: <050.f4830e7e59e0fc1dde86e23297218f0b@openlayers.org> #3026: Add OpenLayers.Format.WMSCCapabilities -------------------------------------+-------------------------------------- Reporter: bartvde | Owner: tschaub Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Format.WMSCapabilities | Version: 2.10 Resolution: fixed | Keywords: WMS-C State: Complete | -------------------------------------+-------------------------------------- Comment(by bartvde): Commit forgotten files in r11057 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 07:57:02 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 07:57:06 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. In-Reply-To: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> References: <039.86072caa1a16b79af6e985ded0da92da@openlayers.org> Message-ID: <048.5a94e3c964f14229fa9f6c6e309a9a3f@openlayers.org> #2936: Handler.Drag: Does not move until the cursor, and does not finish properly. --------------------------+------------------------------------------------- Reporter: jorix | Owner: erilem Type: bug | Status: new Priority: blocker | Milestone: 2.11 Release Component: Handler.Drag | Version: 2.10 Keywords: | State: Review --------------------------+------------------------------------------------- Comment(by jorix): Replying to [comment:7 erilem]: > [attachment:patch-2936-A1.diff] comes with tests, and addresses the case where a new mousedown occurs before the timer triggers. > > @jorix ... I tried the new patch and tests I see everything well (and with {{{if(this.dragging)}}} avoids my only small concern, a possible delayed move after mousedown). Okay! With this patch, users will feel more comfortable with drag! :-) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 11:48:39 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 11:48:41 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3022: GeoJSON format output produces invalid CRS In-Reply-To: <042.689a377aca41cc25b50abe05e3bc87b4@openlayers.org> References: <042.689a377aca41cc25b50abe05e3bc87b4@openlayers.org> Message-ID: <051.6497b7167f367cc4cc4884ca82e1ca30@openlayers.org> #3022: GeoJSON format output produces invalid CRS ----------------------------+----------------------------------------------- Reporter: hoxworth | Owner: hoxworth@? Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.GeoJSON | Version: SVN Keywords: geojson | State: Commit ----------------------------+----------------------------------------------- Comment(by hoxworth): No - is there a standard form I can fill out somewhere for that? -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 14:14:56 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 14:14:59 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2938: [patch] Comparason type like with null (property not present) In-Reply-To: <042.15bbeb11c6cfe5812adc42778701dad4@openlayers.org> References: <042.15bbeb11c6cfe5812adc42778701dad4@openlayers.org> Message-ID: <051.e91e73a6614f2f2ac37f9014219d21e7@openlayers.org> #2938: [patch] Comparason type like with null (property not present) -------------------------------+-------------------------------------------- Reporter: sbrunner | Owner: ahocevar Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Filter.Comparison | Version: 2.10 Keywords: patch | State: -------------------------------+-------------------------------------------- Comment(by sbrunner): Hello an thanks Eric for your respond, I test the attached cases to see the deferent behavior : original: null == undefined (booth) return true => not so good '.+' ~ null (booth) return true => not so good '.+' ~ undefined (booth) return true => bad with my patch: null == undefined (booth) return true => not so good with your patch: '.+' ~ null (booth) return true => not so good Than booth version solve the main problem but booth of theme has can be better in one case. For me booth of them where good enough. CU St?phane -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 15:03:08 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 15:03:10 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3024: New restrictedMinZoom property, like restrictedExtent In-Reply-To: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> References: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> Message-ID: <051.293b79d7aa2d547479ccfae0cde2469d@openlayers.org> #3024: New restrictedMinZoom property, like restrictedExtent ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Commit ----------------------+----------------------------------------------------- Changes (by bartvde): * state: Review => Commit Comment: ahocevar: this looks good to go, I only found one error in a testcase: {{{ //custom minZoomLevel on baseLayer map.baseLayer.minZoomLevel = 1; }}} should be restrictedMinZoom instead of minZoomLevel or not? Respective tests also pass on FF 3.6 and IE8 btw. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 15:17:47 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 15:17:52 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3025: Use restrictedMinZoom in Layer.Bing In-Reply-To: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> References: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> Message-ID: <051.2174b3a1a195cb99b45eb99cae1b42eb@openlayers.org> #3025: Use restrictedMinZoom in Layer.Bing ----------------------+----------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Keywords: | State: Commit ----------------------+----------------------------------------------------- Changes (by bartvde): * state: Review => Commit Comment: This looks much cleaner now. When I run Layer.Bing tests in Firefox and IE I am getting the following error, btw this is not caused by this patch it was already there: {{{ this.metadata.resourceSets[0] is undefined http://localhost/ol_trunk/lib/OpenLayers/Layer/Bing.js Line 120 }}} However the Bing tests still pass. The patch looks good, please commit if you can fix the above issue. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 16:41:02 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 16:41:04 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3022: GeoJSON format output produces invalid CRS In-Reply-To: <042.689a377aca41cc25b50abe05e3bc87b4@openlayers.org> References: <042.689a377aca41cc25b50abe05e3bc87b4@openlayers.org> Message-ID: <051.0551c560f9437e43b13ea9b61ff7c584@openlayers.org> #3022: GeoJSON format output produces invalid CRS ----------------------------+----------------------------------------------- Reporter: hoxworth | Owner: hoxworth@? Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.GeoJSON | Version: SVN Keywords: geojson | State: Commit ----------------------------+----------------------------------------------- Comment(by erilem): Replying to [comment:2 hoxworth]: > No - is there a standard form I can fill out somewhere for that? See http://trac.osgeo.org/openlayers/wiki/HowToContribute. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 16:44:21 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 16:44:23 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3024: New restrictedMinZoom property, like restrictedExtent In-Reply-To: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> References: <042.a9b78b18a8d3067f2d3e1089705ad4f9@openlayers.org> Message-ID: <051.6b3feb8b74d2ecc3943f10f98677add0@openlayers.org> #3024: New restrictedMinZoom property, like restrictedExtent -----------------------+---------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Resolution: fixed | Keywords: State: Complete | -----------------------+---------------------------------------------------- Changes (by ahocevar): * status: new => closed * state: Commit => Complete * resolution: => fixed Comment: Thanks for the review @bartvde. This was a typo indeed. Committing fixed version. In w/ r11058 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 24 16:46:38 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 24 16:46:39 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3025: Use restrictedMinZoom in Layer.Bing In-Reply-To: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> References: <042.6c8c5f75d85d85a10d8a278d05676079@openlayers.org> Message-ID: <051.f9185efb453a13abfafe0b7e7d1eff97@openlayers.org> #3025: Use restrictedMinZoom in Layer.Bing -----------------------+---------------------------------------------------- Reporter: ahocevar | Owner: euzuro Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Layer | Version: SVN Resolution: fixed | Keywords: State: Complete | -----------------------+---------------------------------------------------- Changes (by ahocevar): * status: new => closed * state: Commit => Complete * resolution: => fixed Comment: I fixed the test issue by using longer timeouts - seems the Bing metadata service takes longer to respond sometimes. In w/ r11059 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 25 08:48:18 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 25 08:48:19 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3021: Add POST (XML data) parameters support to SOS Capabilities In-Reply-To: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> References: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> Message-ID: <051.fc1f9e43de3daf1d165239e0a38c46d3@openlayers.org> #3021: Add POST (XML data) parameters support to SOS Capabilities --------------------------------------------------------+------------------- Reporter: sonxurxo | Owner: bartvde Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.OWSCommon | Version: 2.10 Keywords: SOS, GetCapabilities, XML parameters, POST | State: Review --------------------------------------------------------+------------------- Comment(by sonxurxo): I replaced the for..in by for loops in the patch because it failed when Array prototype is extended with methods, because the loop went all over both items and methods. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 25 08:50:45 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 25 08:50:47 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3021: Add POST (XML data) parameters support to SOS Capabilities In-Reply-To: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> References: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> Message-ID: <051.bd606e0762e2421a27b48e1a0f105ca3@openlayers.org> #3021: Add POST (XML data) parameters support to SOS Capabilities --------------------------------------------------------+------------------- Reporter: sonxurxo | Owner: bartvde Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.OWSCommon | Version: 2.10 Keywords: SOS, GetCapabilities, XML parameters, POST | State: Review --------------------------------------------------------+------------------- Comment(by bartvde): @sonxurxo Don't interpret my silence as disinterest, I need to find some time hopefully in the near future to look into this. It's quite busy here at the moment :-( -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 25 10:03:06 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 25 10:03:08 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3021: Add POST (XML data) parameters support to SOS Capabilities In-Reply-To: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> References: <042.ffcd8072c6461fc0fd46a5a93c644ec4@openlayers.org> Message-ID: <051.81ae56af89a9f29ff7acab5adefbf7c4@openlayers.org> #3021: Add POST (XML data) parameters support to SOS Capabilities --------------------------------------------------------+------------------- Reporter: sonxurxo | Owner: bartvde Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Format.OWSCommon | Version: 2.10 Keywords: SOS, GetCapabilities, XML parameters, POST | State: Review --------------------------------------------------------+------------------- Comment(by sonxurxo): Replying to [comment:3 bartvde]: > @sonxurxo Don't interpret my silence as disinterest, I need to find some time hopefully in the near future to look into this. It's quite busy here at the moment :-( @bartvde don't bother at all :), I'm working on related stuff so whenever I find issues I'll keep this ticket updated -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 25 10:45:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 25 10:45:29 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3028: Refresh Strategy removes all features from a layer if the connection drops Message-ID: <042.eb308b7c9745c1c4fcdf6645a03d4f47@openlayers.org> #3028: Refresh Strategy removes all features from a layer if the connection drops ---------------------------------+------------------------------------------ Reporter: gatormba | Owner: fredj Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Strategy | Version: 2.10 Keywords: refresh, connection | State: ---------------------------------+------------------------------------------ When using refresh strategies for a layer, if the connection goes down briefly then all features are removed from that layer until the next successful refresh. Could there be a code change to the refresh strategy to allow "stale" layers if the user wants them? And maybe a way to indicate that the current layer is stale? e.g. If the Wi-Fi drops just before a scheduled refresh, then the layer stays as is until the next successful refresh. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 25 12:22:29 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 25 12:22:31 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3029: Incorrect scale due to OpenLayers.DOTS_PER_INCH Message-ID: <043.138765fe3eb6fa5e540c162863bb4a45@openlayers.org> #3029: Incorrect scale due to OpenLayers.DOTS_PER_INCH ------------------------+--------------------------------------------------- Reporter: dmartella | Owner: Type: bug | Status: new Priority: major | Milestone: 2.11 Release Component: Util | Version: 2.10 Keywords: Scale, DPI | State: ------------------------+--------------------------------------------------- Sometimes Map.getScale() returns incorrect scale values because OpenLayers.DOTS_PER_INCH is a constant set to 72. I propose a fix for programmatically calculate dpi value as described here: http://stackoverflow.com/questions/476815/can-you-access-sceen-displays- dpi-settings-in-a-javascript-function/838755#838755 -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 25 13:11:32 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 25 13:11:34 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3030: ArcGIS (AGS) Tile Cache Layer Contribution Message-ID: <045.48c503812f46dc5851d1308c285b47a8@openlayers.org> #3030: ArcGIS (AGS) Tile Cache Layer Contribution -------------------------+-------------------------------------------------- Reporter: dmiddlecamp | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: | State: Review -------------------------+-------------------------------------------------- Hi Everybody! This is a contribution of a new Layer for OpenLayers that is compatible with newer ESRI ArcGIS Server setups that use cached tile sets. (e.g. arcgis.com, arcgis online). This layer fixes the problem of the tiles 'jumping around' during zooming ( as seen in previous versions http://trac.osgeo.org/openlayers/browser/sandbox/tschaub/arcgiscache/lib/OpenLayers/Layer/ArcGISCache.js) , by correctly calculating the extent based on tile information. This layer can also configure itself using server provided ESRI specific json. This layer is an improvement on wrapping the ESRI js api, since all the work is done in native OpenLayers code, and it provides the added benefit of accessing tiles directly. This layer should represent a working fix to at least one existing ticket http://trac.osgeo.org/openlayers/ticket/1967 Our company Azavea has an existing code contribution agreement, so I'm submitting under that. I've also provided some unit tests, and three typical examples of using and configuring the layer. I've tried to review and clean this code as much as possible, but please let me know if anything needs to be changed or tweaked. I'm very excited about contributing this layer back, and I hope it can help users who would like to use AGS tile sets. At the very least I hope it helps people to understand more recent ArcGIS tile sets. Thanks! David M. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Tue Jan 25 13:16:27 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Tue Jan 25 13:16:30 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3030: ArcGIS (AGS) Tile Cache Layer Contribution In-Reply-To: <045.48c503812f46dc5851d1308c285b47a8@openlayers.org> References: <045.48c503812f46dc5851d1308c285b47a8@openlayers.org> Message-ID: <054.bea82952e6bd8fd8e39132888d12afaa@openlayers.org> #3030: ArcGIS (AGS) Tile Cache Layer Contribution ------------------------------+--------------------------------------------- Reporter: dmiddlecamp | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: ags, esri, layer | State: Review ------------------------------+--------------------------------------------- Changes (by dmiddlecamp): * cc: dmiddlecamp@? (added) * keywords: => ags, esri, layer -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Wed Jan 26 10:12:11 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Wed Jan 26 10:12:13 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3030: ArcGIS (AGS) Tile Cache Layer Contribution In-Reply-To: <045.48c503812f46dc5851d1308c285b47a8@openlayers.org> References: <045.48c503812f46dc5851d1308c285b47a8@openlayers.org> Message-ID: <054.b1925069ec6f76f297e3bace77799f49@openlayers.org> #3030: ArcGIS (AGS) Tile Cache Layer Contribution --------------------------------------+------------------------------------- Reporter: dmiddlecamp | Owner: euzuro Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Layer | Version: 2.10 Keywords: ags, esri, layer, review | State: Review --------------------------------------+------------------------------------- Changes (by dmiddlecamp): * keywords: ags, esri, layer => ags, esri, layer, review -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 27 08:48:34 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 27 08:48:37 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3031: WMS are not correctly aligned to Google, VE, Yahoo Message-ID: <040.bf6780ed0f8afe792be3dc27d2dc3f57@openlayers.org> #3031: WMS are not correctly aligned to Google, VE, Yahoo -------------------------------+-------------------------------------------- Reporter: gasato | Owner: Type: bug | Status: new Priority: minor | Milestone: 2.11 Release Component: general | Version: 2.10 Keywords: VE, GOOGLE, YAHOO | State: -------------------------------+-------------------------------------------- OS: Windows XP 64 Web Browser: Flock, Mozilla, IE Projection EPSG:4326 I cannot correctly overlay different WMS layers from different sources with Google, Ve or Yahoo. Overlay among WMS layers is correct. Overlay among Google, VE and Yahoo is also correct. But among WMS and the others is no correct, there are a shift of Google, VE and Yahoo to the south. I checked the WMS georeferentiation with the OpenLayers graticule and then I've found layers are in correct position. It seems that other layer objects are not well georeferenced in OpenLayers. Thanks for your attention GA -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 27 14:41:32 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 27 14:41:34 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2956: script protocol for reading features cross-origin In-Reply-To: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> References: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> Message-ID: <050.249b668e2baeede304ee09aa6c6f44e5@openlayers.org> #2956: script protocol for reading features cross-origin ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: fredj Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol | Version: 2.10 Keywords: | State: Review ----------------------+----------------------------------------------------- Comment(by tschaub): Thanks for adding tests to this. I'll say I'm not that fond of the {{{FilterSerializer}}}. I do like that this patch takes all that specific filter serialization out of the HTTP protocol, but I don't think it necessarily makes it any more configurable. It would be nice if the app dev could provide their own filterToParams method. With this change, if {{{OpenLayers.Protocol.FilterSerializer}}} is loaded, it will clobber any custom {{{filterToParams}}} method. {{{OpenLayers.Protocol.FilterSerializer}}} is a pretty generic name for a very specific convention for serializing filters. Is this convention unique to MapFish, or did it comes from elsewhere? At a minimum, the script protocol should call initialize on the super after extending itself with the {{{filterToParams}}} (and {{{regex2value}}}) method from the mixin. I think I'd like it even better if that custom {{{filterToParams}}} method were assigned a more suitable name (e.g. a single {{{OpenLayers.Protocol.mapFishFilterSerializer}}} method would do the trick and you could configure your custom protocols to use it for {{{filterToParams}}}). In case it is not obvious what I mean by the specific {{{filterToParams}}} method, I can also imagine methods that would serialize as [http://www.opengeospatial.org/standards/cat CQL] or [http://www.opengeospatial.org/standards/cat ECQL] or following the [http://code.google.com/apis/gdata/docs/2.0/reference.html#FieldConditions GDATA guide for field conditions] (though I think their [http://code.google.com/apis/analytics/docs/gdata/gdataReferenceDataFeed.html#filterSyntax filter syntax for Analytics Feeds] would be more relevant) or [http://developer.yahoo.com/yql/guide/filters.html any] of [http://code.google.com/appengine/docs/python/datastore/gqlreference.html the others] who have riffed on WHERE clauses from SQL. In short, why the custom query syntax baked into OpenLayers? (PS - Hope this doesn't sound overly harsh. I think it will be great to get this Script protocol in. The specific {{{filterToParams}}} bit has just puzzled me for a while.) -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 27 15:11:34 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 27 15:11:45 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3032: pull specific filterToParams method out of HTTP protocol Message-ID: <041.781328e6d27b263c0afb38cefb815e06@openlayers.org> #3032: pull specific filterToParams method out of HTTP protocol ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol.HTTP | Version: 2.10 Keywords: | State: ---------------------------+------------------------------------------------ The filterToParams method on the HTTP protocol is specific to MapFish (as far as I know). We should make it obvious that it can be configured with an alternate method. In addition, the same method should be available to other protocols (e.g #2956). -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 27 15:53:54 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 27 15:53:55 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2956: script protocol for reading features cross-origin In-Reply-To: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> References: <041.f54e2ac1067aac8607e622b228a8bc54@openlayers.org> Message-ID: <050.9b43eead4dbb8a15195901350499c176@openlayers.org> #2956: script protocol for reading features cross-origin ----------------------+----------------------------------------------------- Reporter: tschaub | Owner: fredj Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol | Version: 2.10 Keywords: | State: Review ----------------------+----------------------------------------------------- Comment(by tschaub): I've pulled out the specific {{{filterToParams}}} bit and think we should address that separately (#3032). The patch now contains the original code and example with the addition of pgiraud's tests. Example works and tests pass in IE 6, FF 3, and Chrome 9. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Thu Jan 27 15:55:20 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Thu Jan 27 15:55:22 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3032: pull specific filterToParams method out of HTTP protocol In-Reply-To: <041.781328e6d27b263c0afb38cefb815e06@openlayers.org> References: <041.781328e6d27b263c0afb38cefb815e06@openlayers.org> Message-ID: <050.8782aa17351a83f5192efc9fb158e283@openlayers.org> #3032: pull specific filterToParams method out of HTTP protocol ---------------------------+------------------------------------------------ Reporter: tschaub | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Protocol.HTTP | Version: 2.10 Keywords: | State: Review ---------------------------+------------------------------------------------ Changes (by tschaub): * state: => Review Comment: Tests pass. With this, the original behavior of the HTTP protocol is preserved. It also allows custom builds to exclude the {{{MapFishFilterSerializer}}} and app devs to provide their own {{{filterToParams}}} method. Thanks for any review. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 28 12:31:29 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 28 12:31:31 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.b47df9020d37b5588537a202af707ae9@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: assigned Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: Review ---------------------+------------------------------------------------------ Changes (by tschaub): * status: new => assigned * state: => Review Comment: Reviewing now. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 28 17:29:10 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 28 17:29:11 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.846e001b47d19aace5299511fdfc88bf@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: assigned Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by tschaub): This will make a really great addition. In reviewing, I've caught a few things and added tests. There is still one failing test. Here's what I've done so far: * removed trailing commas to get it to load in IE * added semicolons where appropriate (improves things with our limited compressor) * updated example to allow users to change CQL and see results * added CQL.js format to OpenLayers.js loader * added docs * made it so comparison filters are written with quoted strings only (numbers were quoted as well) * added write support for WITHIN, INTERSECTS, CONTAINS * replaced use of bracket notation with {{{charAt}}} for strings (the former doesn't work in IE and was causing infinite recursion) * made infinite recursion less likely in the balanced parentheses matcher for geometries * made it possible to use spatial filters in a logical filter - this required adding SPATIAL before PROPERTY to the list of follows for LOGICAL (tests pass, but this needs confirmation as the right thing to do) * made it so spatial filters store geometries instead of features -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 28 17:34:11 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 28 17:34:13 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.8b2cdd759c4af81b40a3a3d5a8edeeb1@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: assigned Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by tschaub): In adding write tests, I've gotten it so everything passes except for the writing the filter that results from "A = '1' AND (B = '2' OR C = '3')". Seems to me like we could go for the easy solution and wrap all subfilters or keep track of precedence within logical operators. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 28 18:08:45 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 28 18:08:46 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.9a706608fc72cbae3cce52dcedd6a1fd@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: assigned Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: Review ---------------------+------------------------------------------------------ Comment(by tschaub): Ok, latest patch avoids the logical operator precedence issue by wrapping all subfilters of a logical filter in parens when writing. Tests cover this. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Fri Jan 28 18:12:59 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Fri Jan 28 18:13:01 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.d2bd498b37cd34f8e62a8bc4cc7f57e9@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters ---------------------+------------------------------------------------------ Reporter: tschaub | Owner: tschaub Type: feature | Status: assigned Priority: minor | Milestone: 2.11 Release Component: Format | Version: 2.8 Keywords: | State: Commit ---------------------+------------------------------------------------------ Changes (by tschaub): * state: Review => Commit Comment: Ok, with tests passing and examples working in IE 6, FF 3, and Chrome 9, I think this is good to go. This dramatically simplifies filter creation and I hope it gets heavy use. It will also make a nice alternative {{{filterToParams}}} method for the HTTP protocol (see #3032). Thanks dwins for the great contribution. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sat Jan 29 03:39:10 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sat Jan 29 03:39:12 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3033: Navigation Controls Customization Message-ID: <042.502279768723eae98ac2bdd1b0da2b16@openlayers.org> #3033: Navigation Controls Customization --------------------------------+------------------------------------------- Reporter: sbkhalsa | Owner: Type: feature | Status: new Priority: major | Milestone: 2.11 Release Component: general | Version: 2.7 Keywords: Pan Zoom Customize | State: Awaiting User Feedback --------------------------------+------------------------------------------- I need to customize Pan Zoom controls provided by Open Layer and place a horizontal bar like provided in the bing maps ( http://www.bing.com/maps/) . I would like to know to what extent customization can be done and how. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Sun Jan 30 16:27:28 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Sun Jan 30 16:27:31 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #2522: Format.CQL for seralizing and deserializing filters In-Reply-To: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> References: <041.e72682ed67562c04aa2b311ef924b8ac@openlayers.org> Message-ID: <050.fc15c75f6ff9e177aee7851822e93031@openlayers.org> #2522: Format.CQL for seralizing and deserializing filters -------------------------+-------------------------------------------------- Reporter: tschaub | Owner: tschaub Type: feature | Status: closed Priority: minor | Milestone: 2.11 Release Component: Format.CQL | Version: 2.8 Resolution: fixed | Keywords: State: | -------------------------+-------------------------------------------------- Changes (by tschaub): * status: assigned => closed * resolution: => fixed * state: Commit => * component: Format => Format.CQL Comment: In w/ r11065. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 31 11:21:29 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 31 11:21:32 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3016: ModifyFeature - "del" key press outside vertice should delete the feature In-Reply-To: <039.b52a3d8354d25c331f91c387f6756536@openlayers.org> References: <039.b52a3d8354d25c331f91c387f6756536@openlayers.org> Message-ID: <048.e5744f9dcede70b296b7818905468cda@openlayers.org> #3016: ModifyFeature - "del" key press outside vertice should delete the feature -----------------------------------+---------------------------------------- Reporter: adube | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.ModifyFeature | Version: 2.10 Keywords: del, delete, key | State: Review -----------------------------------+---------------------------------------- Changes (by adube): * state: => Review Comment: The above patch allow the deletion of the currently selected feature on "del" or "d" key pressed. * If the feature has no "fid", it's simply unselected and destroyed. * If not, it's put to "DELETE" state and a "featuremodified" event is triggered. The user must then listen to the event and commit the changes himself. If the event returned "true", then the feature is also destroyed from the layer. I modified an old live sample to show this new feature. It's running with OpenLayers trunk r11065 + the above patch applied. http://dev4g.mapgears.com/gmap-fs/ -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 31 14:55:55 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 31 14:55:58 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3034: DragControl - featureover and featureout events Message-ID: <039.a15ba948cca21815ca630742aff145ee@openlayers.org> #3034: DragControl - featureover and featureout events ---------------------------------+------------------------------------------ Reporter: adube | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.DragFeature | Version: SVN Keywords: | State: ---------------------------------+------------------------------------------ '''Need''' It would be nice to have events triggered when the DragFeature control detects mouse-over and mouse-out on a feature. '''Solution''' Have new "featureover" and "featureout" events triggered in the overFeature and outFeature methods of the control. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 31 14:57:56 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 31 14:57:58 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3034: DragControl - featureover and featureout events In-Reply-To: <039.a15ba948cca21815ca630742aff145ee@openlayers.org> References: <039.a15ba948cca21815ca630742aff145ee@openlayers.org> Message-ID: <048.5e07e506878865bc7c8f9bfdbbec4157@openlayers.org> #3034: DragControl - featureover and featureout events ---------------------------------+------------------------------------------ Reporter: adube | Owner: tschaub Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control.DragFeature | Version: SVN Keywords: | State: Review ---------------------------------+------------------------------------------ Changes (by adube): * state: => Review -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 31 15:46:31 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 31 15:46:34 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3035: Inconsistency in return value for Renderer.setExtent() Message-ID: <044.f8a297eeb812a94f895d155925a5bbb2@openlayers.org> #3035: Inconsistency in return value for Renderer.setExtent() ------------------------+--------------------------------------------------- Reporter: paparazzia | Owner: Type: bug | Status: new Priority: trivial | Milestone: 2.11 Release Component: general | Version: SVN Keywords: | State: ------------------------+--------------------------------------------------- The Layer.Vector.moveTo() method makes use of a return value from the Renderer.setExtent() method. (line 483 in current trunk) {{{ coordSysUnchanged = this.renderer.setExtent(extent, zoomChanged); }}} This is OK for SVG and VML renderers. However, in the abstract class, setExtent() doesn't return anything. Not sure if this can cause bugs, but this seems weird when reading the code. Patch is obvious, but I don't know what should be the default return value for setExtent(). -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 31 16:03:56 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 31 16:03:58 2011 Subject: [OpenLayers-Trac] [OpenLayers] #3036: Generic (Abstract) Control to build switchable panel Message-ID: <044.d8509e382731586369b38148586f165f@openlayers.org> #3036: Generic (Abstract) Control to build switchable panel ------------------------+--------------------------------------------------- Reporter: paparazzia | Owner: Type: feature | Status: new Priority: minor | Milestone: 2.11 Release Component: Control | Version: 2.10 Keywords: switch | State: ------------------------+--------------------------------------------------- Current controls using switchable panels include : * LayerSwitcher * OverviewMap There is no Abstract class to easily build new switchable controls. Would it be interesting to have such class, that could be subclassed by users to builds specific controls ? Very quick draft is appended, let me know if that would be of interest. -- Ticket URL: OpenLayers A free AJAX map viewer From trac-20090302 at openlayers.org Mon Jan 31 16:05:30 2011 From: trac-20090302 at openlayers.org (OpenLayers) Date: Mon Jan 31 16:05:32 2011 Subject: [OpenLayers-Trac] Re: [OpenLayers] #3035: Inconsistency in return value for Renderer.setExtent() In-Reply-To: <044.f8a297eeb812a94f895d155925a5bbb2@openlayers.org> References: <044.f8a297eeb812a94f895d155925a5bbb2@openlayers.org> Message-ID: <053.dd40a33446ee7d99bf55ec1b8c595123@openlayers.org> #3035: Inconsistency in return value for Renderer.setExtent() ------------------------+--------------------------------------------------- Reporter: paparazzia | Owner: Type: bug | Status: new Priority: trivial | Milestone: 2.11 Release Component: Renderer | Version: SVN Keywords: | State: ------------------------+--------------------------------------------------- Changes (by paparazzia): * component: general => Renderer -- Ticket URL: OpenLayers A free AJAX map viewer