[OpenLayers-Trac] Re: [OpenLayers] #2984: Popup appears
automatically when using Google Maps API v3
OpenLayers
trac-20090302 at openlayers.org
Wed Jan 5 08:58:36 EST 2011
#2984: Popup appears automatically when using Google Maps API v3
------------------------------+---------------------------------------------
Reporter: vladimirc | Owner: euzuro
Type: bug | Status: reopened
Priority: major | Milestone: 2.11 Release
Component: Layer.Google.v3 | Version: 2.10
Resolution: | Keywords: google api v3, popup
State: Review |
------------------------------+---------------------------------------------
Changes (by ahocevar):
* status: closed => reopened
* resolution: fixed =>
* state: => Review
* component: Popup => Layer.Google.v3
Comment:
I did some investigation on this, and apparently r10974 is a workaround,
not a fix. Fact is that this popup is not something that Google displays.
It is that our logic for moving attribution and logo to the container does
not work any more, because the popup was added as hidden element as last
child of the google map div, and we made it visible by messing with
style.display.
The attached patch moves this hidden element (if available, i.e. if using
a new v3 api that has it) to the container without modifying it. The
copyright is also no longer switched between hidden and visible, because
we move it to an invisible position (-9999px) anyway.
Another positive side effect of this patch is that the PoweredBy logo is
clickable again - this was also broken because of this new hidden popup.
Because Google now also sets the position of the copyright and logo using
element styles, we need to use {{{!important}}} in our css. So this patch
also fixes the css, and modifies google.css to use the correct original
positions for v3.
Tests still pass. Thanks for any review.
--
Ticket URL: <http://trac.openlayers.org/ticket/2984#comment:2>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer
More information about the Trac
mailing list