[OpenLayers-Trac] Re: [OpenLayers] #2936: Handler.Drag: Does not
move until the cursor, and does not finish properly.
OpenLayers
trac-20090302 at openlayers.org
Sun Jan 23 12:25:01 EST 2011
#2936: Handler.Drag: Does not move until the cursor, and does not finish properly.
--------------------------+-------------------------------------------------
Reporter: jorix | Owner: erilem
Type: bug | Status: new
Priority: blocker | Milestone: 2.11 Release
Component: Handler.Drag | Version: 2.10
Keywords: | State: Review
--------------------------+-------------------------------------------------
Comment(by jorix):
Replying to [comment:5 erilem]:
> [attachment:patch-2936-A0.diff] fixes the "jump on mouseup" issue. With
the patch the jump occurs earlier, when the "delayed drag" timeout
expires. So the patch does improve things in my opinion - better user
experience.
Perfect! I watched the patch: {{{this.lastMoveEvt = evt;}}} at the
beginning of the method is very effective. (I put inside, so my code is
more complicated :-()
Question: Can be omitted to assign {{{this.delayedEvt = null;}}} at the
end of drag?
> Small patches with restricted focuses are much easier to review.
Yes, I know. I did not see the two bugs could be independent. I worried
about leaving active {{{setTimeout}}} so I looked at the completions of
the drag.
> Tell me if you think some of your tests could be added to my patch.
Thanks for reporting the issue and the patch.
The tests are designed to testing thoroughly proper completion of drag. In
a new ticket? [[BR]]
Only a very small affect the behavior of your patch, but to add them
should dismantle the structure of the tests. I prefer not to touch the
structure of the tests.
--
Ticket URL: <http://trac.openlayers.org/ticket/2936#comment:6>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer
More information about the Trac
mailing list