[OpenLayers-Trac] [OpenLayers] #3035: Inconsistency in return value for Renderer.setExtent()

OpenLayers trac-20090302 at openlayers.org
Mon Jan 31 15:46:31 EST 2011


#3035: Inconsistency in return value for Renderer.setExtent()
------------------------+---------------------------------------------------
 Reporter:  paparazzia  |       Owner:              
     Type:  bug         |      Status:  new         
 Priority:  trivial     |   Milestone:  2.11 Release
Component:  general     |     Version:  SVN         
 Keywords:              |       State:              
------------------------+---------------------------------------------------
 The Layer.Vector.moveTo() method makes use of a return value from the
 Renderer.setExtent() method.

 (line 483 in current trunk)

 {{{
             coordSysUnchanged = this.renderer.setExtent(extent,
 zoomChanged);

 }}}

 This is OK for SVG and VML renderers. However, in the abstract class,
 setExtent() doesn't return anything.

 Not sure if this can cause bugs, but this seems weird when reading the
 code.

 Patch is obvious, but I don't know what should be the default return value
 for setExtent().

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3035>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list