[OpenLayers-Trac] Re: [OpenLayers] #3407: Option to always write Multi geometries

OpenLayers trac-20090302 at openlayers.org
Fri Jul 15 07:16:03 EDT 2011

#3407: Option to always write Multi geometries
  Reporter:  ahocevar         |       Owner:  tschaub     
      Type:  feature          |      Status:  reopened    
  Priority:  minor            |   Milestone:  2.12 Release
 Component:  Format.WFST      |     Version:  SVN         
Resolution:                   |    Keywords:              
     State:  Needs More Work  |  

Comment(by ahocevar):

 Thanks Bart for the review.
 Replying to [comment:6 bartvde]:
 >  * using your current patch I cannot create a multi mapping for only
 lines for instance. Can we allow people to define their own
 This also is not possible with the current solution, so I'd suggest making
 a new ticket for this if it is needed.
 >  * can we avoid expressions with side effects on the right side of
 logical operators?
 (http://docstore.mik.ua/orelly/webprog/jscript/ch05_07.htm) This also
 avoids jslint warnings.
 No such expression was in the previous patch, but I'm using a different
 approach in the new one which I hope you like better :-).
 >  * I have a failing test in FF5: test_write_multi planned 2 assertions
 but got 0; fail 0 ok 0, exception: : object: this.writers[prefix][local]
 is undefined
 Hm. Never underestimate the power of the browser cache. You are right, the
 tests failed for me as well. In fact this approach requires more changes.

 New patch attached, tests now really pass. Thanks for another review.

Ticket URL: <http://trac.openlayers.org/ticket/3407#comment:7>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer

More information about the Trac mailing list