[OpenLayers-Trac] Re: [OpenLayers] #3407: Option to always write Multi geometries

OpenLayers trac-20090302 at openlayers.org
Fri Jul 15 09:13:32 EDT 2011


#3407: Option to always write Multi geometries
--------------------------+-------------------------------------------------
  Reporter:  ahocevar     |       Owner:  tschaub     
      Type:  feature      |      Status:  reopened    
  Priority:  minor        |   Milestone:  2.12 Release
 Component:  Format.WFST  |     Version:  SVN         
Resolution:               |    Keywords:              
     State:  Commit       |  
--------------------------+-------------------------------------------------
Changes (by bartvde):

  * state:  Review => Commit


Comment:

 Hey Andreas,

 this is good to go now, thanks for the work on this, 2 remarks:

  * some of the for loops miss the use of var len
  * I still get jslint errors on some of the code, e.g.:

 {{{
 options.multi === true && this.setGeometryTypes();
 }}}

 gives:
 Expected an assignment or function call and instead saw an expression.

 why not just use:
 {{{
 if (options.multi === true) {
     this.setGeometryTypes();
 }
 }}}
 ?

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3407#comment:9>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list