[OpenLayers-Trac] Re: [OpenLayers] #3343: methods for programmatic control of sketches while drawing

OpenLayers trac-20090302 at openlayers.org
Fri Jun 17 11:02:15 EDT 2011


#3343: methods for programmatic control of sketches while drawing
---------------------------------+------------------------------------------
 Reporter:  tschaub              |       Owner:  tschaub     
     Type:  feature              |      Status:  assigned    
 Priority:  minor                |   Milestone:  2.12 Release
Component:  Control.DrawFeature  |     Version:  2.10        
 Keywords:                       |       State:  Commit      
---------------------------------+------------------------------------------
Changes (by bartvde):

  * state:  Review => Commit


Comment:

 Solid patch( full of trigonometry), nice work, some very minor remarks:

  * {Integer} instead of {Number} for getCurrentPointIndex
  * test_insertXY and test_insertDeltaXY have a duplicate testcase (the
 first one), the same is true for the other tests
  * the comment "Editing method tests: insertXY, insertDeltaXY,
 insertDirectionXY, ...." should be moved up 4 test cases
  * the change for list-tests.html is not meant for this patch

 Good to go.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3343#comment:5>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list