[OpenLayers-Trac] Re: [OpenLayers] #3367: Automagically detect featureType and featureNS

[OpenLayers]

#3367: Automagically detect featureType and featureNS
------------------------+---------------------------------------------------
 Reporter:  ahocevar    |       Owner:  tschaub     
     Type:  feature     |      Status:  new         
 Priority:  minor       |   Milestone:  2.12 Release
Component:  Format.GML  |     Version:  2.11 RC1    
 Keywords:              |       State:  Commit      
------------------------+---------------------------------------------------
Changes (by bartvde):

  * state:  Review => Commit


Comment:

 Hi Andreas, this looks good, 2 minor comments/questions:

  * readNode in WFST 1.0 and 1.1 misses "return".
  * this is minor and I am not sure what the convention is, but would it
 not be cleaner if we filter out the third parameter of readNode before
 calling Format.XML's readNode, i.e. return
 OpenLayers.Format.XML.prototype.readNode.call(this, [node, obj]);

 Relevant tests also pass in IE8 and FF4.

 One thing I am still missing from the new Format.GML parser is that we
 need a versioned parser in between that will figure out the version (GML2
 or GML3) by itself.

 As a proof of concept I changed all the Format.GML tests to use GML.v2
 however 13 tests are failing in that case, so to replace it would require
 some more work, however might be just fixing up the testcases (I see some
 small differences with namespaces declaration for xsi etc. missing in the
 old Format, it doesn't seem like anything major).

 However ofcourse this is out of scope for this ticket. I'll open up
 tickets once this gets in.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3367#comment:5>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer