[OpenLayers-Trac] Re: [OpenLayers] #3016: ModifyFeature - "del" key press outside vertice should delete the feature

[OpenLayers]

#3016: ModifyFeature - "del" key press outside vertice should delete the feature
-----------------------------------+----------------------------------------
 Reporter:  adube                  |       Owner:  tschaub        
     Type:  feature                |      Status:  new            
 Priority:  minor                  |   Milestone:  2.11 Release   
Component:  Control.ModifyFeature  |     Version:  2.10           
 Keywords:  del, delete, key       |       State:  Needs More Work
-----------------------------------+----------------------------------------
Changes (by erilem):

  * state:  Review => Needs More Work


Comment:

 Replying to [comment:6 adube]:
 > I set the State for this ticket to Review.  Two things are remaining to
 think for now :
 >  * should an added feature with a state != null trigger the
 "featurestatechanged" event ?

 I don't think so. The user can listen to {{{featureadded}}} and take
 appropriate action if the feature state is set.


 >  * should the feature be redrawn or should that be left to do on client-
 side (for example, using the toState("delete") on del key pressed using
 the ModifyFeature control, should the feature be redrawn) ?

 I would leave that to the application developper.


 Your patch looks good. I'll do a more thorough review when time permits.
 I'm setting the ticket state to Needs More Work as the current patch
 doesn't include tests.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3016#comment:7>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer