[OpenLayers-Trac] Re: [OpenLayers] #2946: Panel: New icons and new displayClass for use with panels.

[OpenLayers]

#2946: Panel: New icons and new displayClass for use with panels.
------------------------------------------+---------------------------------
 Reporter:  jorix                         |       Owner:  jorix          
     Type:  feature                       |      Status:  new            
 Priority:  minor                         |   Milestone:  2.11 Release   
Component:  Control.Panel                 |     Version:  2.10           
 Keywords:  CSS displayClass Panel icons  |       State:  Needs More Work
------------------------------------------+---------------------------------
Changes (by marcjansen):

  * state:  Review => Needs More Work


Comment:

 Hi jorix,

 thanks a lot for your contribution.

 I have a few remarks:

   * When adding {{{.olPanelIconsLeft}}} to the panel, the
   controls appear in reversed order which feels strange and unexpected to
 me.
   From the name one would expect that only the panel changes the position,
   right? I suggest renaming the class to e.g. {{{.olPanelIconsReversed}}}
   * Could you please update the other examples you mentioned so that they
 look
   functional with your patch applied? I only had a look at {{{snap-
 split.html}}}
   and that looked broken.
   * It would be great to have the possible CSS-classes documented
   in {{{OpenLayers.Control.Panel::initialize()}}}
   * Do you think it is possible to enhance the styles for the CSS class
   {{{olPanelIconsLeft}}} so that the class is a drop in replacement for
   {{{.olPanelIcons}}}? Do you see a chance of getting rid of the need to
 add
   two classes? If not, the documentation of
   {{{OpenLayers.Control.Panel::initialize()}}} should clearly indicate how
 to
   reorder panel items (At least a link to the example would be
 appropriate)
   * If it is possible, it would be very nice if you could explain the
   positioning of the panels in the example with visible CSS-code
   * As you provide a "blank" panel background-image
   ({{{olControlItemInactive}}}) you might enhance the example with code
 that
   shows how to add simple custom icons using the CSS property
 {{{content}}},
   e.g.
   {{{
 div.olControlItemInactive:after {
     content: "?";
     text-align: center;
     font-size: 14px;
     font-weight: bold;
     margin-left: 8px;
 }
   }}}
   * You have a typo in the example: it says {{{olPanelIconsVertival}}}
 instead
   of {{{olPanelIconsVertical}}} once
   * Could you update the patch so it applies at current trunk?

-- 
Ticket URL: <http://trac.openlayers.org/ticket/2946#comment:2>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer