[OpenLayers-Trac] Re: [OpenLayers] #2906: Panel: Simplify the method "redraw"

OpenLayers trac-20090302 at openlayers.org
Thu Mar 17 12:42:03 EDT 2011


#2906: Panel: Simplify the method "redraw"
---------------------------+------------------------------------------------
 Reporter:  jorix          |       Owner:  erilem      
     Type:  feature        |      Status:  new         
 Priority:  minor          |   Milestone:  2.11 Release
Component:  Control.Panel  |     Version:  2.10        
 Keywords:                 |       State:  Review      
---------------------------+------------------------------------------------

Comment(by jorix):

 Replying to [comment:4 erilem]:
 > The description ...
 > What do you think?
 >
 This ticket comes from this concern: What happens when we make
 {{{activateControl}}} a {{{TYPE_TOGGLE}}} control? There are two rewrites,
 one for deactivate the active control and another to activate the request,
 and this requires two passes of the "for".

 I know it's one question almost more aesthetic than performance.

 And more: "this" in {{{iconOn}}} and {{{iconOff}}} is not the panel is the
 control itself, and the panel can forget what the displayClass of their
 controls. This is also a matter of aesthetics (but olso may be interesting
 to simplify code)

 Your proposal does not fit into the line of my concern described.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/2906#comment:5>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list