[OpenLayers-Trac] Re: [OpenLayers] #3207: hit detection with canvas

[OpenLayers]

#3207: hit detection with canvas
-----------------------------+----------------------------------------------
 Reporter:  tschaub          |       Owner:  tschaub     
     Type:  feature          |      Status:  assigned    
 Priority:  minor            |   Milestone:  2.11 Release
Component:  Renderer.Canvas  |     Version:  2.10        
 Keywords:                   |       State:  Commit      
-----------------------------+----------------------------------------------

Comment(by tschaub):

 Thanks for the review.

 Replying to [comment:8 fredj]:
 > Two minor comment issues:
 >   * hitDetection comment: change "Default is false" to "Default is true"

 Will change.

 >   * getFeatureIdFromEvent comment: the function returns a feature, not a
 feature id.

 Will change.

 > In getFeatureIdFromEvent, is there a reason that a bitwise or (|) is
 used instead of a logical or (||) ?

 A bitwise | truncates a number to an integer.  A logical || is not what is
 wanted here.

 > Thanks Tim for this patch

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3207#comment:10>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer