[OpenLayers-Trac] Re: [OpenLayers] #3225: Missing return value in
the Renderer.Canvas.drawFeature() method
OpenLayers
trac-20090302 at openlayers.org
Thu Mar 31 18:22:14 EDT 2011
#3225: Missing return value in the Renderer.Canvas.drawFeature() method
-------------------------------------------+--------------------------------
Reporter: vog | Owner: crschmidt
Type: bug | Status: new
Priority: minor | Milestone: 2.11 Release
Component: Renderer.Canvas | Version: 2.10
Keywords: performance, canvas, renderer | State: Review
-------------------------------------------+--------------------------------
Comment(by tschaub):
This is a fairly major bug. It means that we're unnecessarily redrawing
every feature with every call to {{{moveTo}}} (since we iterate through
all {{{unrenderedFeatures}}} there). There is also this weird bit about
returning {{{undefined}}} if no geometry and {{{false}}} if not rendered.
I don't see where the difference is used, but I think it makes sense to
follow suit here as well. If the difference is really not needed, we
should do a strict {{{===}}} check for {{{false}}} before adding to the
unrendered features object.
--
Ticket URL: <http://trac.openlayers.org/ticket/3225#comment:1>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer
More information about the Trac
mailing list