[OpenLayers-Trac] Re: [OpenLayers] #3288: Adding vector layer to invisible map throw an error

[OpenLayers]

#3288: Adding vector layer to invisible map throw an error
----------------------+-----------------------------------------------------
 Reporter:  jlacroix  |       Owner:              
     Type:  bug       |      Status:  new         
 Priority:  minor     |   Milestone:  2.12 Release
Component:  Renderer  |     Version:  2.10        
 Keywords:            |       State:  Review      
----------------------+-----------------------------------------------------

Comment(by erilem):

 My review comments:

  * In {{{Renderer.setSize}}} you could do {{{this.size = size &&
 size.clone();}}}
  * I'd actually rather not change the base class and have the specific
 classes' {{{setSize}}} functions return right away if !size, not to call
 the parent when it's not necessary
  * I'd rather put the new test in the renderer test files, that
 duplicating it for all the renderers for which the problem triggers (all
 maybe?)
  * I think the test should go in its own function, and have a link to this
 ticket
  * In the test you could check that the renderer size, as opposed to the
 map size, has actually changed

 Hope these comments make sense.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3288#comment:3>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer