[OpenLayers-Trac] Re: [OpenLayers] #3312: Google XYZ layer with with tiles provided by the GMaps v3 JavaScript API

[OpenLayers]

#3312: Google XYZ layer with with tiles provided by the GMaps v3 JavaScript API
----------------------+-----------------------------------------------------
 Reporter:  ahocevar  |       Owner:  euzuro         
     Type:  feature   |      Status:  new            
 Priority:  minor     |   Milestone:  2.12 Release   
Component:  Layer     |     Version:  2.10           
 Keywords:            |       State:  Needs More Work
----------------------+-----------------------------------------------------
Changes (by bartvde):

  * state:  Review => Needs More Work


Comment:

 Hey Andreas, thanks for this great work.

 Here is my review (all minor):

  * Google Tile: this.node should be nullified in destructor
  * typo: prelaoded instead of preloaded
  * constructor of Layer.GoogleNG: options instead of config, and type
 should be google.maps.MapTypeId instead of string?
  * initLayer: options.restrictedMinZoom -> should be this instead of
 options?
  * addOptions: use restrictedMinZoom instead of mapType.minZoom?
  * addTile docs: Goolge instead of Google
  * should we really trigger a changelayer event when the attribution
 changes? If I read the APIDocs in Map.js I would not think so. When would
 people use this?

 Thanks again.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3312#comment:6>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer