[OpenLayers-Trac] Re: [OpenLayers] #3521: Dateline handling improvements for grid layers

OpenLayers trac-20090302 at openlayers.org
Wed Sep 28 03:42:25 EDT 2011


#3521: Dateline handling improvements for grid layers
------------------------+---------------------------------------------------
 Reporter:  ahocevar    |       Owner:  elemoine    
     Type:  feature     |      Status:  new         
 Priority:  minor       |   Milestone:  2.12 Release
Component:  Layer.Grid  |     Version:  2.11        
 Keywords:              |       State:  Commit      
------------------------+---------------------------------------------------
Changes (by bartvde):

  * state:  Review => Commit


Comment:

 Hey Andreas, thanks for your work on this, I have a few questions/remarks:

  * setBounds: worldExtent can be moved inside of if statement
  * shouldDraw: should we not only push if maxExtent is changed, so when
 the if conditions are true?
  * it seems to me that currently the two if statements are exactly the
 same?
 {{{
 maxExtent.left > maxExtent.right
 maxExtent.right < maxExtent.left
 }}}
  * the manual test uses a local GeoServer

 Other than this it looks great to me. Feel free to commit once these
 questions/remarks are addressed.
 Tests pass in Safari 5.1.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3521#comment:3>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list