[osgeo4w-dev] Re: msys update

[Matt Wilkie]

Ahh, sorry. I knew I shouldn't have been lazy and created a diff!
Attached this time.

I meant lines 13-16 of msys.bat from the msys-1.0.11-3.tar.bz2 which is 
what I had installed at the time.

> I would assume that only one line is needed, right?
There are two xxmklink commands, one for creating the Desktop shortcut, 
the second for the Startmenu. The  only thing different from the source 
is changing the number "1" to "7" in the two lines.  Once again, a diff 
would have been clearer. :) I apologize for the confusion. Diff attached.

matt wilkie
--------------------------------------------
Geomatics Analyst
Information Management and Technology
Yukon Department of Environment
10 Burns Road * Whitehorse, Yukon * Y1A 4Y9
867-667-8133 Tel * 867-393-7003 Fax
http://environmentyukon.gov.yk.ca/geomatics/
--------------------------------------------


On 09/02/2012 2:19 AM, Martin Landa wrote:
> Hi Matt,
>
> 2012/2/8 Matt Wilkie<matt.wilkie at gov.yk.ca>:
>
>> `apps\msys\msys.bat` could be simplified a little bit by changing lines
>> 13-16 inclusive as they just duplicate what o4w_env.bat always does anyway.
>> This also enables msys to be portable.
>>
>> rem source OSGeo4W changes
>> call "~dp0\..\..\bin\o4w_env.bat
> 13-16 are
>
> """
> rem to represent.
>
> rem ember value of GOTO: is used to know recursion has happened.
> if "%1" == "GOTO:" goto %2
> """
> I guess you are referring to something else.
>
>> And in `postinstall\msys.bat` setting the window property for the menu and
>> desktop shortcuts to 7 (minimized) will stop the console window flicker on
>> startup:
>>
>> xxmklink ... "msys" 7 "%OSGEO4W_ROOT%\apps\msys\m.ico"
>> xxmklink ... "msys" 7 "%OSGEO4W_ROOT%\apps\msys\m.ico"
> I would assume that only one line is needed, right?
>
>> If you add 'maintainer: MartinLanda" to the `setup.hint` file the package
>> vesions page will show your name and link trac homepage automatically
>> (http://download.osgeo.org/osgeo4w/versions.html).
> Done. Thanks for very useful tips.
>
> Martin
>
-------------- next part --------------
--- B:/o4w/apps/msys/old_msys.bat	Thu Feb 09 09:31:28 2012
+++ B:/o4w/apps/msys/msys_matt.bat	Thu Feb 09 09:31:40 2012
@@ -11,9 +11,7 @@
 @echo off
 
 rem source OSGeo4W changes
-SET OSGEO4W_ROOT=@osgeo4w@
-PATH %OSGEO4W_ROOT%\bin;%PATH%
-for %%f in ("%OSGEO4W_ROOT%"\etc\ini\*.bat) do call "%%f"
+call "%~dp0\..\..\bin\o4w_env.bat"
 
 rem ember to set the "Start in:" field of the shortcut.
 rem A value similar to C:\msys\1.0\bin is what the "Start in:" field needs
-------------- next part --------------
--- B:/o4w/apps/msys-1.0.11-6_msys.bat	Fri Jan 16 20:26:17 2009
+++ B:/o4w/apps/msys_matt.bat	Thu Feb 09 09:46:48 2012
@@ -1,5 +1,3 @@
 mkdir "%OSGEO4W_STARTMENU%"
-xxmklink "%OSGEO4W_STARTMENU%\msys.lnk"       "%OSGEO4W_ROOT%\apps\msys\msys.bat" " " \ "msys" 1 "%OSGEO4W_ROOT%\apps\msys\m.ico"
-xxmklink "%ALLUSERSPROFILE%\Desktop\msys.lnk" "%OSGEO4W_ROOT%\apps\msys\msys.bat" " " \ "msys" 1 "%OSGEO4W_ROOT%\apps\msys\m.ico"
-
-textreplace -std -t apps/msys/msys.bat
+xxmklink "%OSGEO4W_STARTMENU%\msys.lnk"       "%OSGEO4W_ROOT%\apps\msys\msys.bat" " " \ "msys" 7 "%OSGEO4W_ROOT%\apps\msys\m.ico"
+xxmklink "%ALLUSERSPROFILE%\Desktop\msys.lnk" "%OSGEO4W_ROOT%\apps\msys\msys.bat" " " \ "msys" 7 "%OSGEO4W_ROOT%\apps\msys\m.ico"