[osgeo4w-dev] [osgeo4w] #554: saga-ltr pkg creates link without icon in start menu and desktop

[OSGeo4W]

#554: saga-ltr pkg creates link without icon in start menu and desktop
------------------------+---------------------------
Reporter:  andreaerdna  |      Owner:  osgeo4w-dev@…
    Type:  defect       |     Status:  new
Priority:  minor        |  Component:  Package
 Version:               |   Keywords:  saga-ltr
------------------------+---------------------------
 saga-ltr pkg (2.3.2-2) postinstall batch file fails to add start menu and
 desktop links with properly set icons (the links are created with blank
 icons) because incorrect use of double quotes with nircmd command.

 In etc\postinstall\saga-ltr.bat there is only one double quote after
 ''exec hide'' but we need to put two double quote in order to let nircmd
 do its job correctly.

 To solve the problem, the following lines in saga-ltr.bat

 {{{
 if not %OSGEO4W_DESKTOP_LINKS%==0 nircmd shortcut
 "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_DESKTOP%" "SAGA GIS (2.3.2)"
 "exec hide "%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps
 \saga-ltr\saga_gui.exe"
 }}}
 {{{
 if not %OSGEO4W_MENU_LINKS%==0 nircmd shortcut
 "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_STARTMENU%" "SAGA GIS (2.3.2)"
 "exec hide "%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps
 \saga-ltr\saga_gui.exe"
 }}}

 need to be replaced respectively with the following lines

 {{{
 if not %OSGEO4W_DESKTOP_LINKS%==0 nircmd shortcut
 "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_DESKTOP%" "SAGA GIS (2.3.2)"
 "exec hide ""%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps
 \saga-ltr\saga_gui.exe"
 }}}
 {{{
 if not %OSGEO4W_MENU_LINKS%==0 nircmd shortcut
 "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_STARTMENU%" "SAGA GIS (2.3.2)"
 "exec hide ""%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps
 \saga-ltr\saga_gui.exe"
 }}}

 or (using nircmd special string sequence ~q) with

 {{{
 if not %OSGEO4W_DESKTOP_LINKS%==0 nircmd shortcut
 "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_DESKTOP%" "SAGA GIS (2.3.2)"
 "exec hide ~q%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat~q" "%OSGEO4W_ROOT%\apps
 \saga-ltr\saga_gui.exe"
 }}}
 {{{
 if not %OSGEO4W_MENU_LINKS%==0 nircmd shortcut
 "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_STARTMENU%" "SAGA GIS (2.3.2)"
 "exec hide ~q%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat~q" "%OSGEO4W_ROOT%\apps
 \saga-ltr\saga_gui.exe"
 }}}

--
Ticket URL: <https://trac.osgeo.org/osgeo4w/ticket/554>
OSGeo4W <http://trac.osgeo.org/osgeo4w>
OSGeo4W is the Windows installer and package environment for the OSGeo stack.