[osgeo4w-dev] [osgeo4w] #737: Patch needed for GDAL 3.4.2

[OSGeo4W]

#737: Patch needed for GDAL 3.4.2
------------------------+----------------------------
Reporter:  andreaerdna  |       Owner:  osgeo4w-dev@…
    Type:  defect       |      Status:  new
Priority:  major        |   Component:  Package
 Version:               |  Resolution:
Keywords:               |
------------------------+----------------------------
Description changed by andreaerdna:

Old description:

> After the update of the {{{gdal}}} package in OSGeo4W to version 3.4.2 in
> order to enable the fix provided by PR
> ​[https://github.com/qgis/QGIS/pull/47098 QGIS/qgis#47098] for the issue
> ​​[https://github.com/qgis/QGIS/issues/23991 QGIS/qgis#23991], some
> issues caused by the same PR ​[https://github.com/qgis/QGIS/pull/47098
> QGIS/qgis#47098] have been discovered:
>
> 1) [https://github.com/qgis/QGIS/issues/48003 QGIS/qgis#48003]
> "Geopackage from network location is not a valid or recognized data
> source"
>
> 2) [https://github.com/qgis/QGIS/issues/48154 QGIS/qgis#48154] "Adding
> additional layers to GPKG does not load them correctly"
>
> 3) [https://github.com/qgis/QGIS/issues/48024 QGIS/qgis#48024] "Cannot
> add GeoPackage layer with hash symbol # in file path"
>
> These issues affects current QGIS 3.25.0-Master and QGIS 3.24.1 when
> built against GDAL 3.4.2. They doesn't affect QGIS LTR 3.22.5, but they
> will affect QGIS LTR 3.22.6.
>
> While the issues 1) and 2) have been fixed (the first one with
> [https://github.com/qgis/QGIS/pull/48059 qgis#48059] and
> [https://github.com/qgis/QGIS/pull/48119 QGIS/qgis#48119] and the second
> one with [https://github.com/qgis/QGIS/pull/48157 QGIS/qgis#48157]) with
> patches in QGIS (backports for 3.22 and 3.24 branches are awaiting
> merging, which will hopefully happen before the release of the
> forthcoming QGIS versions), the issue 3) has been fixed with a patch in
> GDAL (both in master [https://github.com/OSGeo/gdal/pull/5554
> OSGeo/gdal#5554] and 3.4 [https://github.com/OSGeo/gdal/pull/5571
> OSGeo/gdal#5571] branches).
>
> So, since a GDAL 3.4.3 release that contains the patch for the issue 3)
> is not yet available, I propose to temporary apply the GDAL patch
> [https://github.com/OSGeo/gdal/pull/5571 OSGeo/gdal#5571] in the OSGeo4W
> {{{gdal}}} package to prevent that the issue 3) will affect the
> forthcoming QGIS 3.24.2 and QGIS LTR 3.22.6.

New description:

 After the update of the {{{gdal}}} package in OSGeo4W to version 3.4.2 in
 order to enable the fix provided by PR
 ​[https://github.com/qgis/QGIS/pull/47098 QGIS/qgis#47098] for the issue
 ​​[https://github.com/qgis/QGIS/issues/23991 QGIS/qgis#23991], some issues
 caused by the same PR ​[https://github.com/qgis/QGIS/pull/47098
 QGIS/qgis#47098] have been discovered:

 1) [https://github.com/qgis/QGIS/issues/48003 QGIS/qgis#48003] "Geopackage
 from network location is not a valid or recognized data source"

 2) [https://github.com/qgis/QGIS/issues/48154 QGIS/qgis#48154] "Adding
 additional layers to GPKG does not load them correctly"

 3) [https://github.com/qgis/QGIS/issues/48024 QGIS/qgis#48024] "Cannot add
 GeoPackage layer with hash symbol # in file path"

 These issues affects current QGIS 3.25.0-Master and QGIS 3.24.1 (qgis
 3.24.1-2) when built against GDAL 3.4.2 (qgis 3.24.1-1 is not affected).
 They doesn't affect QGIS LTR 3.22.5, since the offending PR
 ​[https://github.com/qgis/QGIS/pull/47098 QGIS/qgis#47098] has been
 backported to 3.22.6.

 While the issues 1) and 2) have been fixed (the first one with
 [https://github.com/qgis/QGIS/pull/48059 qgis#48059] and
 [https://github.com/qgis/QGIS/pull/48119 QGIS/qgis#48119] and the second
 one with [https://github.com/qgis/QGIS/pull/48157 QGIS/qgis#48157]) with
 patches in QGIS (backports for 3.22 and 3.24 branches are awaiting
 merging, which will hopefully happen before the release of the forthcoming
 QGIS versions), the issue 3) has been fixed with a patch in GDAL (both in
 master [https://github.com/OSGeo/gdal/pull/5554 OSGeo/gdal#5554] and 3.4
 [https://github.com/OSGeo/gdal/pull/5571 OSGeo/gdal#5571] branches).

 So, since a GDAL 3.4.3 release that contains the patch for the issue 3) is
 not yet available, I propose to temporary apply the GDAL patch
 [https://github.com/OSGeo/gdal/pull/5571 OSGeo/gdal#5571] in the OSGeo4W
 {{{gdal}}} package to prevent that the issue 3) will affect the
 forthcoming QGIS 3.24.2 and QGIS LTR 3.22.6.

--

-- 
Ticket URL: <https://trac.osgeo.org/osgeo4w/ticket/737#comment:1>
OSGeo4W <http://trac.osgeo.org/osgeo4w>
OSGeo4W is the Windows installer and package environment for the OSGeo stack.