[pdal-commits] [PDAL/PDAL] e3ab71: Fix segfault when reading from las into multiple b...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: e3ab7125b993542e7e793a28e3e61ec04d7279d9
      https://github.com/PDAL/PDAL/commit/e3ab7125b993542e7e793a28e3e61ec04d7279d9
  Author: Chris Foster <chris42f at gmail.com>
  Date:   2013-06-28 (Fri, 28 Jun 2013)

  Changed paths:
    M include/pdal/drivers/las/Reader.hpp
    M src/drivers/las/Reader.cpp

  Log Message:
  -----------
  Fix segfault when reading from las into multiple buffers

In the presence of multiple buffers (such as the temporary buffers used
by the Mosaic stage) caching the dimensions when reading las doesn't
work: dimensions may be in different locations in different buffers.
The previously used buffers may even be deallocated, in which case the
cached dimensions will be stale pointers, leading to segfaults.

The fix here simply removes dimension caching entirely.  With any
reasonable chunk size this shouldn't lead to performance degradation.


  Commit: 7672ab0042ba89f106971123dd35912b801b31e3
      https://github.com/PDAL/PDAL/commit/7672ab0042ba89f106971123dd35912b801b31e3
  Author: Howard Butler <hobu.inc at gmail.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M include/pdal/drivers/las/Reader.hpp
    M src/drivers/las/Reader.cpp

  Log Message:
  -----------
  Merge pull request #146 from c42f/las_reader_cache_dim_fix

Fix segfault when reading from las into multiple buffers


Compare: https://github.com/PDAL/PDAL/compare/418fffb0fb0c...7672ab0042ba