[pdal-commits] [PDAL/PDAL] 616c78: related to #234 and #235, CMake "improvements"

GitHub noreply at github.com
Mon Jan 27 10:35:26 PST 2014


  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 616c7858dbfc1e354395380d50033eaa9f775b88
      https://github.com/PDAL/PDAL/commit/616c7858dbfc1e354395380d50033eaa9f775b88
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-01-27 (Mon, 27 Jan 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/CMakeLists.txt
    A cmake/pdal_options.cmake
    A cmake/pdal_targets.cmake
    M cmake/pdal_utils.cmake
    M src/CMakeLists.txt
    M test/unit/CMakeLists.txt

  Log Message:
  -----------
  related to #234 and #235, CMake "improvements"

  - moved some options (e.g., PDAL_BUILD_STATIC) to pdal_options.cmake
  - created (really borrowed from PCL) macros for adding libraries and
    executables: PDAL_ADD_LIBRARY, PDAL_ADD_EXECUTABLE
  - library linkage (i.e., PUBLIC/PRIVATE) determined at the top level
    in pdal_options.cmake
  - embedded boost lib name does not need quotes, in fact, we lose the
    correct path on Windows if they're there
  - install commands (mostly) moved inside the PDAL_ADD_* macros


  Commit: c9052de97b57e5ef03646b41746c5349e095cf72
      https://github.com/PDAL/PDAL/commit/c9052de97b57e5ef03646b41746c5349e095cf72
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-01-27 (Mon, 27 Jan 2014)

  Changed paths:
    M test/unit/CMakeLists.txt

  Log Message:
  -----------
  tests don't fail locally, perhaps this has something to do with the unit
tests being installed, or linked with boost libraries multiple times,
let's try without the macro


  Commit: b3474b9e842e22ce625b8ac4326ae61632ead639
      https://github.com/PDAL/PDAL/commit/b3474b9e842e22ce625b8ac4326ae61632ead639
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-01-27 (Mon, 27 Jan 2014)

  Changed paths:
    M cmake/pdal_options.cmake

  Log Message:
  -----------
  if (NOT PDAL_BUILD_STATIC) seemed a little confusing; also seeing if the boost linkage is the problem with the build


  Commit: 8fb52738ba9af52320e879af66077fd117d6a431
      https://github.com/PDAL/PDAL/commit/8fb52738ba9af52320e879af66077fd117d6a431
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-01-27 (Mon, 27 Jan 2014)

  Changed paths:
    M apps/CMakeLists.txt
    M cmake/pdal_options.cmake

  Log Message:
  -----------
  linking PDAL_UTILITY against Boost appears to have been the source of all the havoc


  Commit: e4b8f212b44546d62a08f9b5a60366c146382bae
      https://github.com/PDAL/PDAL/commit/e4b8f212b44546d62a08f9b5a60366c146382bae
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-01-27 (Mon, 27 Jan 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/CMakeLists.txt
    A cmake/pdal_options.cmake
    A cmake/pdal_targets.cmake
    M cmake/pdal_utils.cmake
    M src/CMakeLists.txt
    M test/unit/CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #237 from PDAL/tweaking-cmake-files

proposed CMake modifications


Compare: https://github.com/PDAL/PDAL/compare/1a37e0a3377e...e4b8f212b445


More information about the pdal-commits mailing list