[pdal-commits] [PDAL/PDAL] 5d3e8f: Build and test bpf without zlib

GitHub noreply at github.com
Tue Jun 3 13:31:30 PDT 2014 

  Branch: refs/heads/point-context
  Home:   https://github.com/PDAL/PDAL
  Commit: 5d3e8f60a2bac914f43b6eb9209043ef89254361
      https://github.com/PDAL/PDAL/commit/5d3e8f60a2bac914f43b6eb9209043ef89254361
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M include/pdal/drivers/bpf/BpfSeqIterator.hpp
    M src/drivers/bpf/BpfSeqIterator.cpp
    M test/unit/drivers/bpf/BPFTest.cpp

  Log Message:
  -----------
  Build and test bpf without zlib

zlib support was baked into parts of the bpf driver, via the
`BpfSeqIterator::inflate` method and the logic in
`BpfSeqIterator::readBlock`. This patch only defines `inflate` if we
have zlib support, throws a runtime error if the bpf iterator tries to
read a block without zlib, and disables zlib tests if there's no zlib
support.

I'm not sure that my treatment of `readBlock` is correct, as for all I
know there could be a way to read a block without zlib. However, since I
don't know better, I kept things dumb and just threw an error if we
don't have zlib. @abellgithub can we do better?


  Commit: bd27732cc3b026ae4db4a5f6743b7f7f39c88228
      https://github.com/PDAL/PDAL/commit/bd27732cc3b026ae4db4a5f6743b7f7f39c88228
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M test/unit/MetadataTest.cpp
    M test/unit/drivers/las/LasWriterTest.cpp
    M test/unit/filters/StatsFilterTest.cpp

  Log Message:
  -----------
  Guard tests that require srs support

Add `#ifdef PDAL_SRS_ENABLED` around tests that require SRS support, and
in once case split out the srs-dependent parts of a test into a seperate
(guarded) test.

In the stats filter test, ther could be potential for simplifying those
the guarded tests to they don't depend on srs functionality. However,
that would be work for another commit.


  Commit: 6530d1d1f2a1d80889fd2e4364af2fc05792b9f5
      https://github.com/PDAL/PDAL/commit/6530d1d1f2a1d80889fd2e4364af2fc05792b9f5
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M include/pdal/Filters.hpp
    M include/pdal/filters/Colorization.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    M test/unit/CMakeLists.txt

  Log Message:
  -----------
  Exclude colorization filter if we don't have GDAL

It doesn't make much sense to overlay a GDAL raster without GDAL. This
patch also reorganizes the GDAL files in src/CMakeLists.txt.


  Commit: 7b79183d35e2627911b4a4e7ebe631a0655e30dd
      https://github.com/PDAL/PDAL/commit/7b79183d35e2627911b4a4e7ebe631a0655e30dd
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M apps/pdal.cpp
    M include/pdal/Filters.hpp
    M include/pdal/kernel/Kernel.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp

  Log Message:
  -----------
  Conditionally exclude PCL

All the PCL code is now turned off if WITH_PCL == FALSE. We also remove
the command-line help text that mentions PCL.


  Commit: 52c2bf4ccf92d304b04c23faab4911aadde6859c
      https://github.com/PDAL/PDAL/commit/52c2bf4ccf92d304b04c23faab4911aadde6859c
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M include/pdal/Filters.hpp
    M src/CMakeLists.txt

  Log Message:
  -----------
  Conditionally exclude python-dependent filters

Programmable and Predicate.


  Commit: 2b7ca1b49b6615962fd6739c64ca410354182bdf
      https://github.com/PDAL/PDAL/commit/2b7ca1b49b6615962fd6739c64ca410354182bdf
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-05-29 (Thu, 29 May 2014)

  Changed paths:
    M include/pdal/PointBuffer.hpp

  Log Message:
  -----------
  Add missing include required by lround. Closes #382


  Commit: 9deacb84e554b75023cd00718e34c95bb651f287
      https://github.com/PDAL/PDAL/commit/9deacb84e554b75023cd00718e34c95bb651f287
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-05-29 (Thu, 29 May 2014)

  Changed paths:
    M doc/apps.txt

  Log Message:
  -----------
  Update documentation for apps. Closes #380


  Commit: 70ee171aa11f16443f7088cda9ecb727ecfa7675
      https://github.com/PDAL/PDAL/commit/70ee171aa11f16443f7088cda9ecb727ecfa7675
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2014-05-29 (Thu, 29 May 2014)

  Changed paths:
    M doc/apps.txt

  Log Message:
  -----------
  Merge pull request #381 from chambbj/issues/380-apps-documentation-update

Update documentation for apps. Closes #380


  Commit: efaa8dd109749f72a2467bc44212b91806efbaf2
      https://github.com/PDAL/PDAL/commit/efaa8dd109749f72a2467bc44212b91806efbaf2
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2014-05-29 (Thu, 29 May 2014)

  Changed paths:
    M include/pdal/PointBuffer.hpp

  Log Message:
  -----------
  Merge pull request #383 from chambbj/issues/382-include-pdal_macros

Add missing include required by lround.


  Commit: 359915f5b3fa7ffa7c267857cf8e5aaa516fce29
      https://github.com/PDAL/PDAL/commit/359915f5b3fa7ffa7c267857cf8e5aaa516fce29
  Author: Howard Butler <hobu.inc at gmail.com>
  Date:   2014-05-30 (Fri, 30 May 2014)

  Changed paths:
    M Vagrantfile

  Log Message:
  -----------
  add smb-shared folder for win32 clients


  Commit: 20b44b9de30c5fa44ed229a69634b3371cbdd8cc
      https://github.com/PDAL/PDAL/commit/20b44b9de30c5fa44ed229a69634b3371cbdd8cc
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M scripts/vagrant/pdal.sh

  Log Message:
  -----------
  PCL block is in master now, Vagrant users are missing out on other improvements in master


  Commit: 4a0f0582a8164edf4c199ae5c7dc7d10ad02bf03
      https://github.com/PDAL/PDAL/commit/4a0f0582a8164edf4c199ae5c7dc7d10ad02bf03
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M scripts/vagrant/pdal.sh

  Log Message:
  -----------
  Merge pull request #385 from chambbj/issues/384-fix-vagrant-pdal-script

Closes #384


  Commit: 0f3efb7178a27e32339eeeb06e5e314d138bc95d
      https://github.com/PDAL/PDAL/commit/0f3efb7178a27e32339eeeb06e5e314d138bc95d
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M apps/pdal.cpp
    M include/pdal/Filters.hpp
    M include/pdal/drivers/bpf/BpfSeqIterator.hpp
    M include/pdal/filters/Colorization.hpp
    M include/pdal/kernel/Kernel.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    M src/drivers/bpf/BpfSeqIterator.cpp
    M test/unit/CMakeLists.txt
    M test/unit/MetadataTest.cpp
    M test/unit/drivers/bpf/BPFTest.cpp
    M test/unit/drivers/las/LasWriterTest.cpp
    M test/unit/filters/StatsFilterTest.cpp

  Log Message:
  -----------
  Merge pull request #374 from gadomski/build-without-optional-components

Build without optional components


  Commit: 7aa2f6a1c071e9a19442085b85c8eb33fcfa7b29
      https://github.com/PDAL/PDAL/commit/7aa2f6a1c071e9a19442085b85c8eb33fcfa7b29
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-06-03 (Tue, 03 Jun 2014)

  Changed paths:
    M .travis.yml
    M scripts/ci/before_install.sh
    M scripts/ci/script.sh

  Log Message:
  -----------
  Add a second Travis build config

@hobu mentioned in
https://github.com/PDAL/PDAL/pull/370#issuecomment-43626129 that we're a
bit lazy about our conditional file inclusion, since many PDAL developers
have relatively static Cmake configurations during development. Issues
like #370 can pop up when developers don't test out various build
configurations.

This patch adds a second Travis build configuration via the
[env](http://docs.travis-ci.com/user/build-configuration/#Set-environment-variables)
option. `.travis.yml` now sets the `PDAL_OPTIONAL_COMPONENTS`
environment variable to either "all" or "none", and this variable is
then used to control the installation of dependencies and the CMake
configuration.

I aimed to make this patch as low-impact as possible by only switching
on/off CMake variables that were either:

1. Previously controlled by `scripts/ci/script.sh` (e.g. `WITH_GDAL`)
2. Defaulted to `ON` (e.g. `WITH_ZLIB`)

All other CMake options were explicitly turned off (e.g. `WITH_SQLITE`).
These can (should?) be turned on in a later patch.


  Commit: bf6b6c502b624dc02a2e974845bb32f753a1f4a8
      https://github.com/PDAL/PDAL/commit/bf6b6c502b624dc02a2e974845bb32f753a1f4a8
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-06-03 (Tue, 03 Jun 2014)

  Changed paths:
    M .travis.yml
    M scripts/ci/before_install.sh
    M scripts/ci/script.sh

  Log Message:
  -----------
  Merge pull request #372 from gadomski/travis-build-without-optionals

Add a second Travis build config


  Commit: 6c6903d964622a30c12d165b8bd3cde89ac65f38
      https://github.com/PDAL/PDAL/commit/6c6903d964622a30c12d165b8bd3cde89ac65f38
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-06-03 (Tue, 03 Jun 2014)

  Changed paths:
    M include/pdal/Drivers.hpp
    A include/pdal/drivers/oci/OciReader.hpp
    A include/pdal/drivers/oci/OciSeqIterator.hpp
    R include/pdal/drivers/oci/Reader.hpp
    M include/pdal/drivers/oci/Writer.hpp
    M include/pdal/drivers/oci/common.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    A src/drivers/oci/OciReader.cpp
    A src/drivers/oci/OciSeqIterator.cpp
    R src/drivers/oci/Reader.cpp
    M src/drivers/oci/Writer.cpp
    M src/drivers/oci/common.cpp

  Log Message:
  -----------
  OCI reader with PointContext.


  Commit: 17e7294a34223385ba457a10f3b1272e9041c3ce
      https://github.com/PDAL/PDAL/commit/17e7294a34223385ba457a10f3b1272e9041c3ce
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-06-03 (Tue, 03 Jun 2014)

  Changed paths:
    M src/drivers/oci/Writer.cpp
    M test/unit/CMakeLists.txt
    M test/unit/drivers/oci/OCITest.cpp

  Log Message:
  -----------
  Merge branch 'point-context' of https://github.com/PDAL/PDAL into point-context


  Commit: 52d22aad464ab2fcdbea3ecc6896f2067ecd5b8c
      https://github.com/PDAL/PDAL/commit/52d22aad464ab2fcdbea3ecc6896f2067ecd5b8c
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-06-03 (Tue, 03 Jun 2014)

  Changed paths:
    M include/pdal/drivers/oci/Writer.hpp
    M src/drivers/oci/Writer.cpp
    M test/unit/drivers/oci/OCITest.cpp

  Log Message:
  -----------
  Minor writer change/question.
Fix test? to work with new reader.


  Commit: 1a8530477e1e3947ff4ff7e0aa60cd912612cae9
      https://github.com/PDAL/PDAL/commit/1a8530477e1e3947ff4ff7e0aa60cd912612cae9
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-06-03 (Tue, 03 Jun 2014)

  Changed paths:
    M .travis.yml
    M Vagrantfile
    M apps/pdal.cpp
    M doc/apps.txt
    M include/pdal/Filters.hpp
    M include/pdal/PointBuffer.hpp
    M include/pdal/drivers/bpf/BpfSeqIterator.hpp
    M include/pdal/filters/Colorization.hpp
    M include/pdal/kernel/Kernel.hpp
    M scripts/ci/before_install.sh
    M scripts/ci/script.sh
    M scripts/vagrant/pdal.sh
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    M src/drivers/bpf/BpfSeqIterator.cpp
    M test/unit/CMakeLists.txt
    M test/unit/MetadataTest.cpp
    M test/unit/drivers/bpf/BPFTest.cpp
    M test/unit/drivers/las/LasWriterTest.cpp
    M test/unit/filters/StatsFilterTest.cpp

  Log Message:
  -----------
  Merge branch 'master' of https://github.com/PDAL/PDAL into point-context

Conflicts:
	test/unit/CMakeLists.txt


  Commit: 7681119a7e97b2569eeb3b6d2ade6f39268b6c38
      https://github.com/PDAL/PDAL/commit/7681119a7e97b2569eeb3b6d2ade6f39268b6c38
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-06-03 (Tue, 03 Jun 2014)

  Changed paths:
    M include/pdal/drivers/oci/OciSeqIterator.hpp
    M src/drivers/oci/OciReader.cpp

  Log Message:
  -----------
  Get normalization flag to iterator.


Compare: https://github.com/PDAL/PDAL/compare/910fdb20cf81...7681119a7e97

More information about the pdal-commits mailing list