[pdal-commits] [PDAL/PDAL] ad291d: Delay filename requirement until processOptions
GitHub
noreply at github.com
Tue Oct 7 12:25:26 PDT 2014
Branch: refs/heads/master
Home: https://github.com/PDAL/PDAL
Commit: ad291d010916392c12541e1a371e26f0c273da03
https://github.com/PDAL/PDAL/commit/ad291d010916392c12541e1a371e26f0c273da03
Author: Pete Gadomski <pete.gadomski at gmail.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M include/pdal/drivers/las/Writer.hpp
M src/drivers/las/Writer.cpp
Log Message:
-----------
Delay filename requirement until processOptions
The las writer previously opened up the output stream on writer
construction, which mandated that the options passed to Writer(Options)
needed to include a "filename" option. This patch defers the "filename"
requirement until `processOptions`.
In order to maintain compatibility with existing code, this patch keeps
the Writer(ostream) and Writer(Options, ostream) signatures. This means
that a las Writer created with an ostream will *not* require a
"filename" argument, and will in fact ignore any filename argument when
constructing the ostream. This is consistent with past behavior.
This patch also changes the protected member variable m_streamManager on
Writer from a OutputStreamManager to a unique_ptr<OutputStreamManager>.
This is to support OutputStreamManager construction *after* Writer
construction.
Commit: 073586482135119ae607e3bb4259a1f214bc24cc
https://github.com/PDAL/PDAL/commit/073586482135119ae607e3bb4259a1f214bc24cc
Author: Pete Gadomski <pete.gadomski at gmail.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M src/kernel/Pipeline.cpp
Log Message:
-----------
Allow extra command line options for pdal pipeline
This was not previously supported.
Commit: d87ddc89af45e1fe2ac8fccfa5f9f9d0da0f8064
https://github.com/PDAL/PDAL/commit/d87ddc89af45e1fe2ac8fccfa5f9f9d0da0f8064
Author: Pete Gadomski <pete.gadomski at gmail.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M src/kernel/Pipeline.cpp
Log Message:
-----------
Remove spurious options dump
Do'h. [ci skip]
Commit: 1e5b5f1680f7706afee8435fe7f0da2a5c722141
https://github.com/PDAL/PDAL/commit/1e5b5f1680f7706afee8435fe7f0da2a5c722141
Author: Howard Butler <howard at hobu.co>
Date: 2014-10-07 (Tue, 07 Oct 2014)
Changed paths:
M include/pdal/drivers/las/Writer.hpp
M src/drivers/las/Writer.cpp
M src/kernel/Pipeline.cpp
Log Message:
-----------
Merge pull request #506 from gadomski/pipeline-commandline-options
Allow extra command line options for `pdal pipeline`
Compare: https://github.com/PDAL/PDAL/compare/84697d852735...1e5b5f1680f7
More information about the pdal-commits
mailing list