[pdal-commits] [PDAL/PDAL] 627a88: add PCLVisualizer writer and View kernel

[GitHub]

  Branch: refs/heads/issues/482-processOptions
  Home:   https://github.com/PDAL/PDAL
  Commit: 627a88e4ec4afe24d6d77918a0dd42a39a6e6934
      https://github.com/PDAL/PDAL/commit/627a88e4ec4afe24d6d77918a0dd42a39a6e6934
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M apps/CMakeLists.txt
    M apps/pdal.cpp
    M doc/apps.rst
    A doc/stages/drivers.pclvisualizer.writer.rst
    M include/pdal/Drivers.hpp
    A include/pdal/drivers/pclvisualizer/PCLVisualizer.hpp
    M include/pdal/kernel/Kernel.hpp
    A include/pdal/kernel/View.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    A src/drivers/pclvisualizer/PCLVisualizer.cpp
    A src/kernel/View.cpp

  Log Message:
  -----------
  add PCLVisualizer writer and View kernel

PCLVisualizer writer can be used as an endpoint to spawn a simple
viewer. To use the PCLVisualizer, PCL must be built with
BUILD_visualization=ON and WITH_VTK=ON, and PCL must be enabled within
PDAL.

PDAL_BUNDLE=ON creates the pdal app as application bundle, which is not
explicitly required, but enables some PCL keyboard/mouse interactions in
PCLVisualizer. As reported by Kitware
(http://vtk.1045678.n5.nabble.com/Keyboard-and-mouse-interaction-on-OSX-td5719379.html).

The View kernel allows us to create a simple viewer with only an input
filename, e.g., pdal view input.las.

The writer can also be invoked through existing kernels by passing a
dummy filename with the .pclviz extension. This is a bit of a hack, and
perhaps we should consider adding a "visualize" option that both writes
the requested output format and spawns the viewer.


  Commit: 1154577599b7d1379a1f8bfb95c267d5c8ce720e
      https://github.com/PDAL/PDAL/commit/1154577599b7d1379a1f8bfb95c267d5c8ce720e
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M include/stubs/pcl/point_types.h
    A include/stubs/pcl/visualization/pcl_visualizer.h
    A include/stubs/pcl/visualization/point_cloud_color_handlers.h

  Log Message:
  -----------
  fix the PCL stubs for PCLVisualizer


  Commit: 20808b499de5fd1b5b6c4a917c2bd249a39b45c8
      https://github.com/PDAL/PDAL/commit/20808b499de5fd1b5b6c4a917c2bd249a39b45c8
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/pdal.cpp
    M include/pdal/Drivers.hpp
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Kernel.hpp
    M pdal_defines.h.in
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp

  Log Message:
  -----------
  add --visualize flag at the Application level that will cause Ground,
PCL, Random, and Translate kernels to spawn a PCLVisualizer after
writing the result to disk


  Commit: 31b37f90588484f0912e6797da372540393c17d8
      https://github.com/PDAL/PDAL/commit/31b37f90588484f0912e6797da372540393c17d8
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M src/kernel/Application.cpp

  Log Message:
  -----------
  getVisualize should return false if PCLVisualize not available


  Commit: c73f1edcc517923d3718f8abcf54b579531d7bb7
      https://github.com/PDAL/PDAL/commit/c73f1edcc517923d3718f8abcf54b579531d7bb7
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M src/kernel/Ground.cpp

  Log Message:
  -----------
  visualize both input and output


  Commit: 8322c09f776070be5decbb578398c1df3b4a43d1
      https://github.com/PDAL/PDAL/commit/8322c09f776070be5decbb578398c1df3b4a43d1
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Translate.hpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp

  Log Message:
  -----------
  move the visualization code to the Application class

Kernels now call `visualize(*pbSetOut.begin())` to display the output
buffer or `visualize(*pbSetIn.begin(), *pbSetOut.begin())` to display
input and output buffers.

`Random` displays only the output (there is no input buffer), while
`ground`, `pcl`, and `translate` display both input and output buffers.


  Commit: 91128f4ea79b6a190127b0449998d2d1cf571ccb
      https://github.com/PDAL/PDAL/commit/91128f4ea79b6a190127b0449998d2d1cf571ccb
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M include/pdal/kernel/Translate.hpp
    M src/kernel/Translate.cpp

  Log Message:
  -----------
  fix memory issue


  Commit: c2bc8ff9cafaf5279911ce7c1e228e03d8872dab
      https://github.com/PDAL/PDAL/commit/c2bc8ff9cafaf5279911ce7c1e228e03d8872dab
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/CMakeLists.txt
    M apps/pdal.cpp
    M doc/apps.rst
    A doc/stages/drivers.pclvisualizer.writer.rst
    M include/pdal/Drivers.hpp
    A include/pdal/drivers/pclvisualizer/PCLVisualizer.hpp
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Kernel.hpp
    M include/pdal/kernel/Translate.hpp
    A include/pdal/kernel/View.hpp
    M include/stubs/pcl/point_types.h
    A include/stubs/pcl/visualization/pcl_visualizer.h
    A include/stubs/pcl/visualization/point_cloud_color_handlers.h
    M pdal_defines.h.in
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    A src/drivers/pclvisualizer/PCLVisualizer.cpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp
    A src/kernel/View.cpp

  Log Message:
  -----------
  Merge pull request #508 from chambbj/PCLVisualizer

add PCLVisualizer writer and View kernel


  Commit: 1876bef95a304623faade07fcba73b4d479ceaff
      https://github.com/PDAL/PDAL/commit/1876bef95a304623faade07fcba73b4d479ceaff
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/CMakeLists.txt
    M apps/pdal.cpp
    M doc/apps.rst
    A doc/stages/drivers.pclvisualizer.writer.rst
    M include/pdal/Drivers.hpp
    A include/pdal/drivers/pclvisualizer/PCLVisualizer.hpp
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Kernel.hpp
    M include/pdal/kernel/Translate.hpp
    A include/pdal/kernel/View.hpp
    M include/stubs/pcl/point_types.h
    A include/stubs/pcl/visualization/pcl_visualizer.h
    A include/stubs/pcl/visualization/point_cloud_color_handlers.h
    M pdal_defines.h.in
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    A src/drivers/pclvisualizer/PCLVisualizer.cpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp
    A src/kernel/View.cpp

  Log Message:
  -----------
  Merge branch 'master' into issues/482-processOptions

Conflicts:
	src/kernel/Ground.cpp
	src/kernel/PCL.cpp
	src/kernel/Translate.cpp


Compare: https://github.com/PDAL/PDAL/compare/9dd7de2d9bb5...1876bef95a30