[pdal-commits] [PDAL/PDAL] 530184: Windows clean-up (mostly warnings)

[GitHub]

  Branch: refs/heads/pdal-tindex
  Home:   https://github.com/PDAL/PDAL
  Commit: 530184006783642f1adf45f8c4ee4d5b83fed4bc
      https://github.com/PDAL/PDAL/commit/530184006783642f1adf45f8c4ee4d5b83fed4bc
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2015-03-19 (Thu, 19 Mar 2015)

  Changed paths:
    M cmake/win32_compiler_options.cmake
    M filters/chipper/ChipperFilter.cpp
    M filters/chipper/ChipperFilter.hpp
    M filters/colorization/ColorizationFilter.hpp
    M filters/crop/CropFilter.cpp
    M filters/range/RangeFilter.cpp
    M filters/reprojection/ReprojectionFilter.cpp
    M filters/stats/StatsFilter.cpp
    M include/pdal/KDIndex.hpp
    M include/pdal/Metadata.hpp
    M include/pdal/PipelineManager.hpp
    M include/pdal/PointView.hpp
    M include/pdal/QuadIndex.hpp
    M include/pdal/Utils.hpp
    M include/pdal/pdal_macros.hpp
    M include/pdal/pdal_types.hpp
    M include/pdal/util/IStream.hpp
    M include/pdal/util/OStream.hpp
    M io/las/LasReader.cpp
    M io/las/VariableLengthRecord.cpp
    M io/text/TextWriter.cpp
    M kernels/delta/DeltaKernel.cpp
    M kernels/delta/DeltaKernel.hpp
    M kernels/diff/DiffKernel.cpp
    M kernels/info/InfoKernel.cpp
    M plugins/attribute/filters/AttributeFilter.cpp
    M plugins/nitf/test/NitfReaderTest.cpp
    M plugins/nitf/test/NitfWriterTest.cpp
    M plugins/pcl/io/PcdReader.cpp
    M plugins/pcl/test/PCLBlockFilterTest.cpp
    M src/KDIndex.cpp
    M src/KernelSupport.cpp
    M src/PDALUtils.cpp
    M src/QuadIndex.cpp
    M src/SpatialReference.cpp
    M src/StageFactory.cpp
    M src/pdal_config.cpp
    M src/util/Bounds.cpp
    M test/unit/BoundsTest.cpp
    M test/unit/MetadataTest.cpp
    M test/unit/PipelineManagerTest.cpp
    A test/unit/PointContextTest.cpp
    M test/unit/StreamFactoryTest.cpp
    M test/unit/Support.cpp
    M test/unit/Support.hpp
    M test/unit/UserCallbackTest.cpp
    M test/unit/filters/CropFilterTest.cpp
    M test/unit/filters/DecimationFilterTest.cpp
    M test/unit/filters/FerryFilterTest.cpp
    M test/unit/filters/RangeFilterTest.cpp
    M test/unit/filters/StatsFilterTest.cpp
    M test/unit/filters/TransformationFilterTest.cpp
    M test/unit/io/bpf/BPFTest.cpp
    M test/unit/io/las/LasReaderTest.cpp
    M test/unit/io/las/LasWriterTest.cpp
    M test/unit/io/optech/OptechReaderTest.cpp
    M test/unit/io/qfit/QFITReaderTest.cpp
    M test/unit/io/rialto/RialtoWriterTest.cpp

  Log Message:
  -----------
  Windows clean-up (mostly warnings)

Compiler is VC 11.0. Compiler warning is referenced in parens.

Stop getting PluginManager instance when it is not needed (C4189).

Remove initialized, but unreferenced variables (C4189).

Use EXPECT_DOUBLE_EQ vice EXPECT_FLOAT_EQ where appropriate. Rearrange
comparisons such that the expected value comes first (not strictly
necessary, just a convention). Compute some expected values rather than
typing (and truncating) them.

Change point_count_t and PointId to uint32_t vice size_t. Change datatypes
throughout the codebase to try to adhere to this convention, using PointId
vice size_t for point indices, and point_count_t vice size_t for point
counts.

Standardize handling of `-Wfloat-equal` on various compilers, generally
when sucking in GDAL/OGR headers.

Stop casting values to bool. Compare `non_bool != 0` instead (C4800).

Safer tolower/toupper implementation (so sayeth stackoverflow). See
http://stackoverflow.com/questions/19876746/stdtolower-and-visual-studio-2013.

Omit termination test from for loop (rather than using `true`) to avoid
warning about constant conditional expression (C4127).

Globally suppress warning about nameless union/struct (C4201).

Globally suppress warning about exception specifications. These are used
extensively in Nitro (C4290).


  Commit: 007666d38b04f23935505fa9dcf0de9e2bd88624
      https://github.com/PDAL/PDAL/commit/007666d38b04f23935505fa9dcf0de9e2bd88624
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2015-03-19 (Thu, 19 Mar 2015)

  Changed paths:
    M cmake/win32_compiler_options.cmake
    M filters/colorization/ColorizationFilter.hpp
    M filters/crop/CropFilter.cpp
    M filters/range/RangeFilter.cpp
    M filters/reprojection/ReprojectionFilter.cpp
    M include/pdal/Metadata.hpp
    M include/pdal/PipelineManager.hpp
    M include/pdal/Utils.hpp
    M include/pdal/util/IStream.hpp
    M include/pdal/util/OStream.hpp
    M plugins/attribute/filters/AttributeFilter.cpp
    M plugins/nitf/test/NitfReaderTest.cpp
    M plugins/nitf/test/NitfWriterTest.cpp
    M plugins/pcl/test/PCLBlockFilterTest.cpp
    M src/SpatialReference.cpp
    M src/pdal_config.cpp
    M src/util/Bounds.cpp
    M test/unit/filters/CropFilterTest.cpp
    M test/unit/filters/DecimationFilterTest.cpp
    M test/unit/filters/FerryFilterTest.cpp
    M test/unit/filters/RangeFilterTest.cpp
    M test/unit/filters/StatsFilterTest.cpp
    M test/unit/filters/TransformationFilterTest.cpp
    M test/unit/io/optech/OptechReaderTest.cpp
    M test/unit/io/rialto/RialtoWriterTest.cpp

  Log Message:
  -----------
  revert some changes, use /W3 instead of /W4


  Commit: 9176f4c17123464844bdbb944f041dc528f69e7c
      https://github.com/PDAL/PDAL/commit/9176f4c17123464844bdbb944f041dc528f69e7c
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2015-03-19 (Thu, 19 Mar 2015)

  Changed paths:
    M test/unit/Support.hpp

  Log Message:
  -----------
  fix bad rebase with master


  Commit: edccf8c1ed1403cc2a0ea5b04bf93387a2afc109
      https://github.com/PDAL/PDAL/commit/edccf8c1ed1403cc2a0ea5b04bf93387a2afc109
  Author: Sandro Santilli <strk at keybit.net>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M cmake/macros.cmake

  Log Message:
  -----------
  Request ctest to load plugins from the build dir

Fix #840


  Commit: df651454fc31c599702b65b5488e244f52b102d4
      https://github.com/PDAL/PDAL/commit/df651454fc31c599702b65b5488e244f52b102d4
  Author: Sandro Santilli <strk at keybit.net>
  Date:   2015-03-25 (Wed, 25 Mar 2015)

  Changed paths:
    M scripts/ci/before_install.sh
    M scripts/ci/script.sh

  Log Message:
  -----------
  Have Travis run pgpointcloud tests

Fixes #839


  Commit: bdce5792d2d95487efe583890378b30b303dcb41
      https://github.com/PDAL/PDAL/commit/bdce5792d2d95487efe583890378b30b303dcb41
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-03-25 (Wed, 25 Mar 2015)

  Changed paths:
    M doc/index.rst

  Log Message:
  -----------
  Fix small typo in homepage index

"its wides formant coverage" didn't mean much to me.

[skip ci]


  Commit: d85b6b7ba5ddc745098dd4120990d61ed09c9d9e
      https://github.com/PDAL/PDAL/commit/d85b6b7ba5ddc745098dd4120990d61ed09c9d9e
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M scripts/ci/before_install.sh

  Log Message:
  -----------
  see if ninja works out of the box with the existing cmake ppa


  Commit: 2f47112d512c92e47087bb0c528de3aa46e38892
      https://github.com/PDAL/PDAL/commit/2f47112d512c92e47087bb0c528de3aa46e38892
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M include/pdal/PDALUtils.hpp

  Log Message:
  -----------
  export overloaded toJSON, make appveyor/windows happy


  Commit: 899cf2c104cd75bcd7573a6144e6aad0ce19f2ad
      https://github.com/PDAL/PDAL/commit/899cf2c104cd75bcd7573a6144e6aad0ce19f2ad
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M doc/index.rst

  Log Message:
  -----------
  Merge pull request #848 from gadomski/homepage-typo

Fix small typo in homepage index


  Commit: a015528463da400d79b7183a2f67748405ea948a
      https://github.com/PDAL/PDAL/commit/a015528463da400d79b7183a2f67748405ea948a
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M scripts/ci/before_install.sh
    M scripts/ci/script.sh

  Log Message:
  -----------
  Merge pull request #846 from strk/travis

Try installing postgresql server headers


  Commit: 41747b089f0c4881756d58a0acd0f3383f6a5380
      https://github.com/PDAL/PDAL/commit/41747b089f0c4881756d58a0acd0f3383f6a5380
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M cmake/win32_compiler_options.cmake
    M filters/chipper/ChipperFilter.cpp
    M filters/chipper/ChipperFilter.hpp
    M filters/colorization/ColorizationFilter.hpp
    M filters/range/RangeFilter.cpp
    M filters/reprojection/ReprojectionFilter.cpp
    M filters/stats/StatsFilter.cpp
    M include/pdal/KDIndex.hpp
    M include/pdal/PointView.hpp
    M include/pdal/QuadIndex.hpp
    M include/pdal/Utils.hpp
    M include/pdal/pdal_macros.hpp
    M include/pdal/pdal_types.hpp
    M io/las/LasReader.cpp
    M io/las/VariableLengthRecord.cpp
    M io/text/TextWriter.cpp
    M kernels/delta/DeltaKernel.cpp
    M kernels/delta/DeltaKernel.hpp
    M kernels/diff/DiffKernel.cpp
    M kernels/info/InfoKernel.cpp
    M plugins/attribute/filters/AttributeFilter.cpp
    M plugins/pcl/io/PcdReader.cpp
    M src/KDIndex.cpp
    M src/KernelSupport.cpp
    M src/PDALUtils.cpp
    M src/QuadIndex.cpp
    M src/StageFactory.cpp
    M src/util/Bounds.cpp
    M test/unit/BoundsTest.cpp
    M test/unit/MetadataTest.cpp
    M test/unit/PipelineManagerTest.cpp
    A test/unit/PointContextTest.cpp
    M test/unit/StreamFactoryTest.cpp
    M test/unit/Support.cpp
    M test/unit/Support.hpp
    M test/unit/UserCallbackTest.cpp
    M test/unit/filters/FerryFilterTest.cpp
    M test/unit/io/bpf/BPFTest.cpp
    M test/unit/io/las/LasReaderTest.cpp
    M test/unit/io/las/LasWriterTest.cpp
    M test/unit/io/optech/OptechReaderTest.cpp
    M test/unit/io/qfit/QFITReaderTest.cpp

  Log Message:
  -----------
  Merge pull request #842 from PDAL/windows-warnings

Windows clean-up (mostly warnings)


  Commit: da0d2babca12a97e998f81da94b44046739f3b22
      https://github.com/PDAL/PDAL/commit/da0d2babca12a97e998f81da94b44046739f3b22
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M include/pdal/PDALUtils.hpp

  Log Message:
  -----------
  Merge pull request #850 from PDAL/export-toJSON

export overloaded toJSON, make appveyor/windows happy


  Commit: a8730b6f0f57b750fd88dc314440ea8c22a51224
      https://github.com/PDAL/PDAL/commit/a8730b6f0f57b750fd88dc314440ea8c22a51224
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M scripts/ci/before_install.sh

  Log Message:
  -----------
  Merge pull request #849 from PDAL/travis-optimization

ninja works out of the box with the existing cmake ppa


  Commit: b17b31839d87f940e8997e53a10b76b62cb6cf40
      https://github.com/PDAL/PDAL/commit/b17b31839d87f940e8997e53a10b76b62cb6cf40
  Author: Connor Manning <connor at hobu.co>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M include/pdal/PointView.hpp
    M include/pdal/QuadIndex.hpp
    M io/rialto/RialtoWriter.cpp
    M src/QuadIndex.cpp
    M test/unit/PipelineManagerTest.cpp

  Log Message:
  -----------
  Fix warnings.  Add virtual destructor to PointView.


  Commit: dbe21e988949b28cc308c17fd7ae3e1dc95bbc8c
      https://github.com/PDAL/PDAL/commit/dbe21e988949b28cc308c17fd7ae3e1dc95bbc8c
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M include/pdal/Kernel.hpp
    M io/las/LasError.hpp
    M io/las/LasReader.cpp
    M io/las/LasWriter.cpp
    M kernels/info/InfoKernel.cpp
    M kernels/info/InfoKernel.hpp
    M kernels/tindex/TIndexKernel.cpp
    M kernels/tindex/TIndexKernel.hpp
    M src/GlobalEnvironment.cpp

  Log Message:
  -----------
  run InfoKernel for every file requested for TIndexKernel


  Commit: b470dbfa368092502f7a659c365eedba31e81952
      https://github.com/PDAL/PDAL/commit/b470dbfa368092502f7a659c365eedba31e81952
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M io/las/LasReader.cpp
    M io/las/LasWriter.cpp

  Log Message:
  -----------
  tweak log at ready(), not processOptions()


  Commit: f472e64262c25076cc88f07f8bfe50e252f07603
      https://github.com/PDAL/PDAL/commit/f472e64262c25076cc88f07f8bfe50e252f07603
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M plugins/oci/io/OciWriter.cpp

  Log Message:
  -----------
  Debug.


  Commit: 9e98ba21ffd0413654e052d6ccebca21787c2d0b
      https://github.com/PDAL/PDAL/commit/9e98ba21ffd0413654e052d6ccebca21787c2d0b
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-03-26 (Thu, 26 Mar 2015)

  Changed paths:
    M cmake/win32_compiler_options.cmake
    M filters/chipper/ChipperFilter.cpp
    M filters/chipper/ChipperFilter.hpp
    M filters/colorization/ColorizationFilter.hpp
    M filters/range/RangeFilter.cpp
    M filters/reprojection/ReprojectionFilter.cpp
    M filters/stats/StatsFilter.cpp
    M include/pdal/KDIndex.hpp
    M include/pdal/PDALUtils.hpp
    M include/pdal/PointView.hpp
    M include/pdal/QuadIndex.hpp
    M include/pdal/Utils.hpp
    M include/pdal/pdal_macros.hpp
    M include/pdal/pdal_types.hpp
    M io/las/LasReader.cpp
    M io/las/VariableLengthRecord.cpp
    M io/rialto/RialtoWriter.cpp
    M io/text/TextWriter.cpp
    M kernels/delta/DeltaKernel.cpp
    M kernels/delta/DeltaKernel.hpp
    M kernels/diff/DiffKernel.cpp
    M kernels/info/InfoKernel.cpp
    M plugins/attribute/filters/AttributeFilter.cpp
    M plugins/pcl/io/PcdReader.cpp
    M scripts/ci/before_install.sh
    M src/KDIndex.cpp
    M src/KernelSupport.cpp
    M src/PDALUtils.cpp
    M src/QuadIndex.cpp
    M src/StageFactory.cpp
    M src/util/Bounds.cpp
    M test/unit/BoundsTest.cpp
    M test/unit/MetadataTest.cpp
    M test/unit/PipelineManagerTest.cpp
    A test/unit/PointContextTest.cpp
    M test/unit/StreamFactoryTest.cpp
    M test/unit/Support.cpp
    M test/unit/Support.hpp
    M test/unit/UserCallbackTest.cpp
    M test/unit/filters/FerryFilterTest.cpp
    M test/unit/io/bpf/BPFTest.cpp
    M test/unit/io/las/LasReaderTest.cpp
    M test/unit/io/las/LasWriterTest.cpp
    M test/unit/io/optech/OptechReaderTest.cpp
    M test/unit/io/qfit/QFITReaderTest.cpp

  Log Message:
  -----------
  Merge branch 'master' of https://github.com/PDAL/PDAL


  Commit: 986f0487f10bde2b34e5fe54e064c0100df99d77
      https://github.com/PDAL/PDAL/commit/986f0487f10bde2b34e5fe54e064c0100df99d77
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M cmake/macros.cmake

  Log Message:
  -----------
  Merge pull request #844 from strk/test-built-plugins

Request ctest to load plugins from the build dir


  Commit: 3a82ffbc6844601e6397c84b624f2406224e118e
      https://github.com/PDAL/PDAL/commit/3a82ffbc6844601e6397c84b624f2406224e118e
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M cmake/geotiff.cmake
    M src/CMakeLists.txt
    M test/unit/CMakeLists.txt

  Log Message:
  -----------
  Allow fresh cmake builds w/o geotiff

If WITH_GEOTIFF was set to off, a fresh cmake would fail because
always-used variabled GEOTIFF_LIBRARY and GEOTIFF_INCLUDE_DIRS were set
to *-Notfound. This patch moves the use of those variables inside
conditionals.


  Commit: da41bb3424822c82ef176eb330b6e0f18aa08dd3
      https://github.com/PDAL/PDAL/commit/da41bb3424822c82ef176eb330b6e0f18aa08dd3
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M cmake/geotiff.cmake
    M src/CMakeLists.txt
    M test/unit/CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #852 from PDAL/geotiff-optional-cmake

Allow fresh cmake builds w/o geotiff


  Commit: c645588739831e26e6306bfc7e3cc0e62b0ff67a
      https://github.com/PDAL/PDAL/commit/c645588739831e26e6306bfc7e3cc0e62b0ff67a
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-03-30 (Mon, 30 Mar 2015)

  Changed paths:
    M kernels/tindex/TIndexKernel.cpp
    M kernels/tindex/TIndexKernel.hpp

  Log Message:
  -----------
  OGR layer creation now working for pdal tindex


  Commit: 0f238a4b2d2e2c3575144dbb6c27c8fd8090e896
      https://github.com/PDAL/PDAL/commit/0f238a4b2d2e2c3575144dbb6c27c8fd8090e896
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-03-30 (Mon, 30 Mar 2015)

  Changed paths:
    M cmake/geotiff.cmake
    M cmake/macros.cmake
    M cmake/win32_compiler_options.cmake
    M doc/index.rst
    M filters/chipper/ChipperFilter.cpp
    M filters/chipper/ChipperFilter.hpp
    M filters/colorization/ColorizationFilter.hpp
    M filters/range/RangeFilter.cpp
    M filters/reprojection/ReprojectionFilter.cpp
    M filters/stats/StatsFilter.cpp
    M include/pdal/KDIndex.hpp
    M include/pdal/PDALUtils.hpp
    M include/pdal/PointView.hpp
    M include/pdal/QuadIndex.hpp
    M include/pdal/Utils.hpp
    M include/pdal/pdal_macros.hpp
    M include/pdal/pdal_types.hpp
    M io/las/LasReader.cpp
    M io/las/VariableLengthRecord.cpp
    M io/rialto/RialtoWriter.cpp
    M io/text/TextWriter.cpp
    M kernels/delta/DeltaKernel.cpp
    M kernels/delta/DeltaKernel.hpp
    M kernels/diff/DiffKernel.cpp
    M kernels/info/InfoKernel.cpp
    M plugins/attribute/filters/AttributeFilter.cpp
    M plugins/oci/io/OciWriter.cpp
    M plugins/pcl/io/PcdReader.cpp
    M scripts/ci/before_install.sh
    M scripts/ci/script.sh
    M src/CMakeLists.txt
    M src/KDIndex.cpp
    M src/KernelSupport.cpp
    M src/PDALUtils.cpp
    M src/QuadIndex.cpp
    M src/StageFactory.cpp
    M src/util/Bounds.cpp
    M test/unit/BoundsTest.cpp
    M test/unit/CMakeLists.txt
    M test/unit/MetadataTest.cpp
    M test/unit/PipelineManagerTest.cpp
    A test/unit/PointContextTest.cpp
    M test/unit/StreamFactoryTest.cpp
    M test/unit/Support.cpp
    M test/unit/Support.hpp
    M test/unit/UserCallbackTest.cpp
    M test/unit/filters/FerryFilterTest.cpp
    M test/unit/io/bpf/BPFTest.cpp
    M test/unit/io/las/LasReaderTest.cpp
    M test/unit/io/las/LasWriterTest.cpp
    M test/unit/io/optech/OptechReaderTest.cpp
    M test/unit/io/qfit/QFITReaderTest.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master' into pdal-tindex


Compare: https://github.com/PDAL/PDAL/compare/2411cc3f93c0...0f238a4b2d2e