[pdal-commits] [PDAL/PDAL] 7a1a00: Failing test for invalid pointcount in las header

Wed May 13 12:33:34 PDT 2015

  Branch: refs/heads/rialto-tiling
  Home:   https://github.com/PDAL/PDAL
  Commit: 7a1a00a05f36394ae3d764d10a80ad0adf2dd12a
      https://github.com/PDAL/PDAL/commit/7a1a00a05f36394ae3d764d10a80ad0adf2dd12a
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-05-04 (Mon, 04 May 2015)

  Changed paths:
    M test/unit/io/las/LasReaderTest.cpp

  Log Message:
  -----------
  Failing test for invalid pointcount in las header

If the las header says that the file has more points than it really
does, those extra points will (probably) be zero-filled.

Via bisect, c63f198db2f08caa2a47b34f4c7409a248e22a12 is the first bad
commit.

  Commit: bae837ba541821d9503baab45ebee27486f18e3d
      https://github.com/PDAL/PDAL/commit/bae837ba541821d9503baab45ebee27486f18e3d
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-07 (Thu, 07 May 2015)

  Changed paths:
    A doc/stages/filters.splitter.rst
    M filters/splitter/SplitterFilter.cpp
    M filters/splitter/SplitterFilter.hpp

  Log Message:
  -----------
  Add origin support for SplitterFilter.

  Commit: f6306ed387fe479b92b9e9b6b050fad8d789fb3e
      https://github.com/PDAL/PDAL/commit/f6306ed387fe479b92b9e9b6b050fad8d789fb3e
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-07 (Thu, 07 May 2015)

  Changed paths:
    M include/pdal/Utils.hpp

  Log Message:
  -----------
  Merge branch 'master' of https://github.com/PDAL/PDAL

  Commit: e36510cdeb7b847462ed722b9be25c75f3760ba6
      https://github.com/PDAL/PDAL/commit/e36510cdeb7b847462ed722b9be25c75f3760ba6
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M include/pdal/util/Bounds.hpp
    M src/util/Bounds.cpp
    M test/unit/BoundsTest.cpp

  Log Message:
  -----------
  added note and test case for #897

Also took the liberty of moving the 2D ctor from cpp file to the hpp
file, to be consistent with the other ctors.

  Commit: c48f819681fcccc9786078957b60f6d168127e73
      https://github.com/PDAL/PDAL/commit/c48f819681fcccc9786078957b60f6d168127e73
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M include/pdal/util/Bounds.hpp
    M src/util/Bounds.cpp
    M test/unit/BoundsTest.cpp

  Log Message:
  -----------
  (fails on MSVC, see #897 and #900)

Revert "added note and test case for #897"

This reverts commit e36510cdeb7b847462ed722b9be25c75f3760ba6.

  Commit: 4aa5b27a65a01ad3c7b5cdcc8c0aced5dd48b831
      https://github.com/PDAL/PDAL/commit/4aa5b27a65a01ad3c7b5cdcc8c0aced5dd48b831
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M include/pdal/util/Bounds.hpp
    M test/unit/BoundsTest.cpp

  Log Message:
  -----------
  committing again, this time without gratuitous actor fix

  Commit: d3650b0bc2a77cd30d4b3d1049d8caace292c3eb
      https://github.com/PDAL/PDAL/commit/d3650b0bc2a77cd30d4b3d1049d8caace292c3eb
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M test/unit/io/las/LasReaderTest.cpp

  Log Message:
  -----------
  Merge branch 'gadomski-las-header-incorrect-pointcount' into las-header-incorrect-pointcount

  Commit: 7c1b66943d31f0a367385fafee4b912c20e374eb
      https://github.com/PDAL/PDAL/commit/7c1b66943d31f0a367385fafee4b912c20e374eb
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M io/las/LasReader.cpp

  Log Message:
  -----------
  Attempt to support mis-labeled LAS headers in the case where
the header's size is larger than the actual number of bytes in
the file would otherwise suggest. This supercedes #893.

  Commit: 75c9bf491003886813b8872f4086102a89182b1b
      https://github.com/PDAL/PDAL/commit/75c9bf491003886813b8872f4086102a89182b1b
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M io/las/LasReader.cpp
    M test/unit/io/las/LasReaderTest.cpp

  Log Message:
  -----------
  Merge pull request #902 from PDAL/las-header-incorrect-pointcount

Read mislabeled LAS files where the header says there are more

  Commit: 1e886489fa8ee6bdafb487b29c0f0c18db4471bd
      https://github.com/PDAL/PDAL/commit/1e886489fa8ee6bdafb487b29c0f0c18db4471bd
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M include/pdal/util/Bounds.hpp
    M test/unit/BoundsTest.cpp

  Log Message:
  -----------
  Merge pull request #901 from PDAL/issue-897

Added note & test for "2D" BBOX3 question

  Commit: 41aec1f071101f277af11d02b1fee3b6452c68a4
      https://github.com/PDAL/PDAL/commit/41aec1f071101f277af11d02b1fee3b6452c68a4
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M plugins/pcl/filters/GroundFilter.cpp
    M plugins/pcl/filters/GroundFilter.hpp
    M plugins/pcl/kernel/GroundKernel.cpp
    M plugins/pcl/kernel/GroundKernel.hpp

  Log Message:
  -----------
  Add --approximate option to 'pdal ground' for much faster computation #883

  Commit: ea4d6f88cb8715117540688a29176949199edb4a
      https://github.com/PDAL/PDAL/commit/ea4d6f88cb8715117540688a29176949199edb4a
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-09 (Sat, 09 May 2015)

  Changed paths:
    M io/las/LasHeader.cpp

  Log Message:
  -----------
  Don't blindly read LAS files that don't have the first four magic 'LASF' bytes

  Commit: d281c0bf16c166a4313f5b236688340aa263df44
      https://github.com/PDAL/PDAL/commit/d281c0bf16c166a4313f5b236688340aa263df44
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-09 (Sat, 09 May 2015)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  clean up extra tabs in gitignore

  Commit: 1af541c3270bf00e50facdb1055e910070bdc786
      https://github.com/PDAL/PDAL/commit/1af541c3270bf00e50facdb1055e910070bdc786
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M filters/splitter/SplitterFilter.cpp

  Log Message:
  -----------
  Fix nan comparison.

  Commit: c67ebaa3d8c03f7947d8aa22b1fba487178d168c
      https://github.com/PDAL/PDAL/commit/c67ebaa3d8c03f7947d8aa22b1fba487178d168c
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M .gitignore
    M README.md
    M doc/stages/writers.pgpointcloud.rst
    M include/pdal/PluginManager.hpp
    M include/pdal/pdal_macros.hpp
    M include/pdal/util/Bounds.hpp
    M io/las/LasReader.cpp
    M plugins/sqlite/io/SQLiteCommon.hpp
    M plugins/sqlite/test/SQLiteTest.cpp
    M src/KernelFactory.cpp
    M src/PluginManager.cpp
    M src/StageFactory.cpp
    M test/unit/BoundsTest.cpp
    M test/unit/io/las/LasReaderTest.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master'

  Commit: ae374d3c3a54ca48063fd442a216be1fb944a128
      https://github.com/PDAL/PDAL/commit/ae374d3c3a54ca48063fd442a216be1fb944a128
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M filters/splitter/SplitterFilter.cpp

  Log Message:
  -----------
  Add cmath.

  Commit: 8b8de889ebaac4c2359c186acc79243ed19cdfec
      https://github.com/PDAL/PDAL/commit/8b8de889ebaac4c2359c186acc79243ed19cdfec
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M filters/splitter/SplitterFilter.cpp

  Log Message:
  -----------
  Use a != a instead of isnan().

  Commit: 23eecaaf78b3db847837d725300d798d9099a754
      https://github.com/PDAL/PDAL/commit/23eecaaf78b3db847837d725300d798d9099a754
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M io/las/LasHeader.cpp

  Log Message:
  -----------
  Merge pull request #904 from PDAL/detect-bad-las-files

Don't blindly read LAS files that don't have the first four magic 'LASF' bytes

  Commit: 3a56acd61b67410cf31ecef7ca9a3b1cb9c6b82a
      https://github.com/PDAL/PDAL/commit/3a56acd61b67410cf31ecef7ca9a3b1cb9c6b82a
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M plugins/pcl/filters/GroundFilter.cpp
    M plugins/pcl/filters/GroundFilter.hpp
    M plugins/pcl/kernel/GroundKernel.cpp
    M plugins/pcl/kernel/GroundKernel.hpp

  Log Message:
  -----------
  Merge pull request #903 from PDAL/approximate-pdal-ground

Add --approximate option to 'pdal ground' for much faster computation #883

  Commit: cae0e1022fc5a9e8af3c7880547a74b9a1b7e365
      https://github.com/PDAL/PDAL/commit/cae0e1022fc5a9e8af3c7880547a74b9a1b7e365
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M include/pdal/util/Bounds.hpp
    M test/unit/BoundsTest.cpp

  Log Message:
  -----------
  Fix for bbox precision loss (#909)

  Commit: 37762a883684007455543a00334eb99a87fc6ea2
      https://github.com/PDAL/PDAL/commit/37762a883684007455543a00334eb99a87fc6ea2
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M plugins/sqlite/io/SQLiteCommon.hpp
    M plugins/sqlite/io/SQLiteReader.cpp
    M plugins/sqlite/io/SQLiteWriter.cpp
    M plugins/sqlite/test/SQLiteTest.cpp

  Log Message:
  -----------
  misc refactoring and cleanups

- regularized the log() function
- added getVersion functions
- lifted a couple spatialite operations up into the header
- fixed a bug when column type is null (hit by spatialite version call)
- passing “1” to the spatiality init function now, which yields a big
speedup (http://hub.qgis.org/issues/8340)

  Commit: 02977f10f6a043e4fbec0a0a8f593d6ed60fad14
      https://github.com/PDAL/PDAL/commit/02977f10f6a043e4fbec0a0a8f593d6ed60fad14
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M plugins/sqlite/test/SQLiteTest.cpp

  Log Message:
  -----------
  cleaner LogPtr

and less whitespace

  Commit: 16294591702c3cc7a9e4cdd07586cab0b487108b
      https://github.com/PDAL/PDAL/commit/16294591702c3cc7a9e4cdd07586cab0b487108b
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M plugins/sqlite/io/SQLiteCommon.hpp

  Log Message:
  -----------
  boost removals

as per code review

and no one-line ifs anymore

  Commit: 5fa6e5996f1e34c680ce387c92304de7e9437d0d
      https://github.com/PDAL/PDAL/commit/5fa6e5996f1e34c680ce387c92304de7e9437d0d
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M test/unit/io/las/LasReaderTest.cpp

  Log Message:
  -----------
  lint

warning under OS X build

  Commit: 053285c90d8041ec472697fc4d506c08712e48d4
      https://github.com/PDAL/PDAL/commit/053285c90d8041ec472697fc4d506c08712e48d4
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M test/unit/io/las/LasReaderTest.cpp

  Log Message:
  -----------
  Merge pull request #912 from PDAL/lasreadertest-lint

lint - lasreadertest

  Commit: 246ff7ff29cd4bc70ed233fe482cc7c4ba69706b
      https://github.com/PDAL/PDAL/commit/246ff7ff29cd4bc70ed233fe482cc7c4ba69706b
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M plugins/sqlite/io/SQLiteCommon.hpp
    M plugins/sqlite/io/SQLiteReader.cpp
    M plugins/sqlite/io/SQLiteWriter.cpp
    M plugins/sqlite/test/SQLiteTest.cpp

  Log Message:
  -----------
  Merge pull request #911 from PDAL/sqlite_improvements

misc SQLite refactoring and cleanups

  Commit: 6034ab2c69cecb031cca445205b6e2a80edb9f22
      https://github.com/PDAL/PDAL/commit/6034ab2c69cecb031cca445205b6e2a80edb9f22
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M include/pdal/util/Bounds.hpp
    M test/unit/BoundsTest.cpp

  Log Message:
  -----------
  Merge pull request #910 from PDAL/bbox_precisionloss

Fix for bbox precision loss (#909)

  Commit: 0a3ec6203c6fc02f545b4f51776a91fd7b9a7864
      https://github.com/PDAL/PDAL/commit/0a3ec6203c6fc02f545b4f51776a91fd7b9a7864
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  remove spurious line

  Commit: 9376449617fa68c5a3b8d78ab0d385b879a862a7
      https://github.com/PDAL/PDAL/commit/9376449617fa68c5a3b8d78ab0d385b879a862a7
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M plugins/rialto/CMakeLists.txt
    M plugins/rialto/test/RialtoTest.cpp
    M plugins/rialto/test/RialtoTest.hpp

  Log Message:
  -----------
  fixing linkage issue

test support files are header only?

  Commit: 56f75ae6cb376c7596d00ce2f8099145be12df8f
      https://github.com/PDAL/PDAL/commit/56f75ae6cb376c7596d00ce2f8099145be12df8f
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M plugins/rialto/io/RialtoDb.cpp
    M plugins/rialto/io/RialtoDb.hpp
    M plugins/rialto/io/RialtoDbReader.cpp
    M plugins/rialto/io/RialtoDbReader.hpp
    M plugins/rialto/io/RialtoDbWriter.hpp
    M plugins/rialto/io/RialtoFileWriter.cpp
    M plugins/rialto/io/RialtoWriter.cpp
    M plugins/rialto/io/RialtoWriter.hpp
    M plugins/rialto/test/RialtoDbWriterTest.cpp

  Log Message:
  -----------
  remove namespacing, further test support linkage

  Commit: c9984daaff6bd8f42fb016abdb68e04f0b9aa753
      https://github.com/PDAL/PDAL/commit/c9984daaff6bd8f42fb016abdb68e04f0b9aa753
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M .gitignore
    A doc/stages/filters.splitter.rst
    M filters/splitter/SplitterFilter.cpp
    M filters/splitter/SplitterFilter.hpp
    M include/pdal/util/Bounds.hpp
    M io/las/LasHeader.cpp
    M io/las/LasReader.cpp
    M plugins/pcl/filters/GroundFilter.cpp
    M plugins/pcl/filters/GroundFilter.hpp
    M plugins/pcl/kernel/GroundKernel.cpp
    M plugins/pcl/kernel/GroundKernel.hpp
    M plugins/sqlite/io/SQLiteCommon.hpp
    M plugins/sqlite/io/SQLiteReader.cpp
    M plugins/sqlite/io/SQLiteWriter.cpp
    M plugins/sqlite/test/SQLiteTest.cpp
    M test/unit/BoundsTest.cpp
    M test/unit/io/las/LasReaderTest.cpp

  Log Message:
  -----------
  merge master into branch

two conflicts resolved

  Commit: f6a49eb7ff72ed618691e6eb110ffe3f4b0713ba
      https://github.com/PDAL/PDAL/commit/f6a49eb7ff72ed618691e6eb110ffe3f4b0713ba
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M plugins/rialto/CMakeLists.txt
    M plugins/rialto/test/RialtoDbWriterTest.cpp
    M plugins/rialto/test/RialtoFileWriterTest.cpp
    R plugins/rialto/test/RialtoTest.cpp
    M plugins/rialto/test/RialtoTest.hpp

  Log Message:
  -----------
  refactored writer tests

  Commit: d6e04c362550ae156cd4b912aa2bd32d66a5b677
      https://github.com/PDAL/PDAL/commit/d6e04c362550ae156cd4b912aa2bd32d66a5b677
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M plugins/rialto/io/RialtoDb.cpp
    M plugins/rialto/io/RialtoDb.hpp
    M plugins/rialto/io/RialtoDbReader.cpp
    M plugins/rialto/io/RialtoDbReader.hpp
    M plugins/rialto/io/RialtoDbWriter.cpp
    M plugins/rialto/test/RialtoDbReaderTest.cpp
    M plugins/rialto/test/RialtoDbWriterTest.cpp

  Log Message:
  -----------
  db reader now working

  Commit: 38002f4a23b2ecffb66ec60ba406b6192cc54154
      https://github.com/PDAL/PDAL/commit/38002f4a23b2ecffb66ec60ba406b6192cc54154
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M plugins/rialto/CMakeLists.txt
    M plugins/rialto/io/RialtoDbReader.cpp
    M plugins/rialto/io/RialtoDbReader.hpp
    R plugins/rialto/io/RialtoFileReader.cpp
    R plugins/rialto/io/RialtoFileReader.hpp
    R plugins/rialto/io/RialtoReader.cpp
    R plugins/rialto/io/RialtoReader.hpp
    M plugins/rialto/test/RialtoDbReaderTest.cpp
    R plugins/rialto/test/RialtoFileReaderTest.cpp
    M plugins/rialto/test/RialtoTest.hpp

  Log Message:
  -----------
  removed unused FileReader support

  Commit: f98599036379c57d120410ea82eea3bb30346082
      https://github.com/PDAL/PDAL/commit/f98599036379c57d120410ea82eea3bb30346082
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M plugins/rialto/io/RialtoDb.cpp
    M plugins/rialto/io/RialtoDb.hpp
    M plugins/rialto/test/RialtoDbReaderTest.cpp
    M plugins/rialto/test/RialtoDbWriterTest.cpp
    M plugins/rialto/test/RialtoTest.hpp

  Log Message:
  -----------
  starting to time things

Compare: https://github.com/PDAL/PDAL/compare/0c06c135844e...f98599036379